build: index.php and updater.phar

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Author: blizzz

index.php

@@ -7,6 +7,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
+
 class UpdateException extends \Exception {
 
 	/** @param list<string> $data */
@@ -63,18 +64,7 @@ class Updater {
 	public function __construct(string $baseDir) {
 		$this->baseDir = $baseDir;
 
-		if ($dir = getenv('NEXTCLOUD_CONFIG_DIR')) {
-			$configFileName = rtrim($dir, '/') . '/config.php';
-		} else {
-			$configFileName = $this->baseDir . '/../config/config.php';
-		}
-		if (!file_exists($configFileName)) {
-			throw new \Exception('Could not find config.php. Is this file in the "updater" subfolder of Nextcloud?');
-		}
-
-		/** @var array $CONFIG */
-		require_once $configFileName;
-		$this->configValues = $CONFIG;
+		[$this->configValues] = $this->readConfigFile();
 
 		if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false)) {
 			// updater disabled
@@ -116,6 +106,38 @@ public function __construct(string $baseDir) {
 		$this->buildTime = $buildTime;
 	}
 
+	/**
+	 * @return array{array, string}
+	 */
+	private function readConfigFile(): array {
+		if ($dir = getenv('NEXTCLOUD_CONFIG_DIR')) {
+			$configFileName = realpath($dir . '/config.php');
+		} else {
+			$configFileName = $this->nextcloudDir . '/config/config.php';
+		}
+		if (!file_exists($configFileName)) {
+			throw new \Exception('Could not find config.php (' . $configFileName . '). Is this file in the "updater" subfolder of Nextcloud?');
+		}
+		$filePointer = @fopen($configFileName, 'r');
+		if ($filePointer === false) {
+			throw new \Exception('Could not open config.php (' . $configFileName . ').');
+		}
+		if (!flock($filePointer, LOCK_SH)) {
+			throw new \Exception('Could not acquire a shared lock on the config file (' . $configFileName . ')');
+		}
+
+		try {
+			require $configFileName;
+		} finally {
+			// Close the file pointer and release the lock
+			flock($filePointer, LOCK_UN);
+			fclose($filePointer);
+		}
+
+		/** @var array $CONFIG */
+		return [$CONFIG,$configFileName];
+	}
+
 	/**
 	 * Returns whether the web updater is disabled
 	 *
@@ -374,27 +396,17 @@ public function checkWritePermissions(): void {
 	public function setMaintenanceMode(bool $state): void {
 		$this->silentLog('[info] setMaintenanceMode("' . ($state ? 'true' : 'false') .  '")');
 
-		if ($dir = getenv('NEXTCLOUD_CONFIG_DIR')) {
-			$configFileName = rtrim($dir, '/') . '/config.php';
-		} else {
-			$configFileName = $this->baseDir . '/../config/config.php';
-		}
+		[$CONFIG, $configFileName] = $this->readConfigFile();
 		$this->silentLog('[info] configFileName ' . $configFileName);
 
-		// usually is already tested in the constructor but just to be on the safe side
-		if (!file_exists($configFileName)) {
-			throw new \Exception('Could not find config.php.');
-		}
-		/** @var array $CONFIG */
-		require $configFileName;
 		$CONFIG['maintenance'] = $state;
 		$content = "<?php\n";
 		$content .= '$CONFIG = ';
 		$content .= var_export($CONFIG, true);
 		$content .= ";\n";
-		$state = file_put_contents($configFileName, $content);
-		if ($state === false) {
-			throw new \Exception('Could not write to config.php');
+		$writeSuccess = file_put_contents($configFileName, $content, LOCK_EX);
+		if ($writeSuccess === false) {
+			throw new \Exception('Could not write to config.php (' . $configFileName . ')');
 		}
 		$this->silentLog('[info] end of setMaintenanceMode()');
 	}