test(updater): add tests to new error handling in getUpdateServerResponse

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

Author: joshtrichards

tests/features/bootstrap/FeatureContext.php

@@ -204,7 +204,7 @@ public function theCliUpdaterIsRun() {
 		copy($this->buildDir . 'updater.phar', $this->serverDir . 'nextcloud/updater/updater');
 		chdir($this->serverDir . 'nextcloud/updater');
 		chmod($this->serverDir . 'nextcloud/updater/updater', 0755);
-		exec('./updater -n', $output, $returnCode);
+		exec('./updater -n 2>&1', $output, $returnCode);
 
 		// sleep to let the opcache do it's work and invalidate the status.php
 		sleep(5);
@@ -564,4 +564,54 @@ public function thereIsAConfigForASecondaryAppsDirectoryCalled($name) {
 	public function phpIsAtLeastInVersion($version) {
 		$this->skipIt = in_array(version_compare($version, PHP_VERSION, '<'), [0, false], true);
 	}
+
+	/**
+	 * @Given the update server returns HTTP status :statusCode
+	 */
+	public function theUpdateServerReturnsHttpStatus(int $statusCode) {
+		if ($this->skipIt) {
+			return;
+		}
+
+		$this->runUpdateServer();
+
+		$content = '<?php http_response_code(' . $statusCode . '); echo "Server Error";';
+		file_put_contents($this->updateServerDir . 'index.php', $content);
+	}
+
+	/**
+	 * @Given the update server returns invalid XML
+	 */
+	public function theUpdateServerReturnsInvalidXml() {
+		if ($this->skipIt) {
+			return;
+		}
+
+		$this->runUpdateServer();
+
+		$content = '<?php header("Content-Type: application/xml"); echo "this is not valid xml <><><";';
+		file_put_contents($this->updateServerDir . 'index.php', $content);
+	}
+
+	/**
+	 * @Given the update server is unreachable
+	 */
+	public function theUpdateServerIsUnreachable() {
+		if ($this->skipIt) {
+			return;
+		}
+
+		// Point updater.server.url at a port with nothing listening
+		$configFile = $this->serverDir . 'nextcloud/config/config.php';
+		$content = file_get_contents($configFile);
+		$content = preg_replace(
+			'!\$CONFIG\s*=\s*array\s*\(!',
+			"\$CONFIG = array(\n 'updater.server.url' => 'http://localhost:8871/',",
+			$content
+		);
+		file_put_contents($configFile, $content);
+
+		// Intentionally do NOT start any server on port 8871
+	}
 }
+

tests/features/cli.feature

@@ -84,3 +84,33 @@ Feature: CLI updater
     And the installed version should be 26.0.0
     And maintenance mode should be off
     And upgrade is not required
+
+  Scenario: Update server returns HTTP 500 - 26.0.0
+    Given the current installed version is 26.0.0
+    And the update server returns HTTP status 500
+    When the CLI updater is run
+    Then the return code should not be 0
+    And the output should contain "Update server returned unexpected HTTP status 500"
+    And the installed version should be 26.0.0
+    And maintenance mode should be off
+    And upgrade is not required
+
+  Scenario: Update server returns invalid XML - 26.0.0
+    Given the current installed version is 26.0.0
+    And the update server returns invalid XML
+    When the CLI updater is run
+    Then the return code should not be 0
+    And the output should contain "Could not parse updater server XML response"
+    And the installed version should be 26.0.0
+    And maintenance mode should be off
+    And upgrade is not required
+
+  Scenario: Update server is unreachable - 26.0.0
+    Given the current installed version is 26.0.0
+    And the update server is unreachable
+    When the CLI updater is run
+    Then the return code should not be 0
+    And the output should contain "Could not do request to updater server"
+    And the installed version should be 26.0.0
+    And maintenance mode should be off
+    And upgrade is not required