fix: log and write the output of the 'occ maintenance:mode --off' command if it fails

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

lib/UpdateCommand.php

@@ -269,7 +269,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 			//
 			// Handle `occ upgrade` run
 			//
-			
+
 			if ($this->skipUpgrade) {
 				$this->updater->log('[info] "occ upgrade" was skipped');
 				$this->updater->log('[info] updater finished');
@@ -324,7 +324,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 			//
 			// Handle maintenance mode toggle
 			//
-			
+
 			$output->writeln('');
 			if ($input->isInteractive()) {
 				/** @var QuestionHelper */
@@ -344,7 +344,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 			}
 
 			$this->updater->log('[info] Disabling maintenance mode');
-			system($occRunCommand . ' maintenance:mode --off', $returnValueMaintenanceMode);
+			$systemOutput = system($occRunCommand . ' maintenance:mode --off', $returnValueMaintenanceMode);
 			if ($returnValueMaintenanceMode === 0) {
 				$this->updater->log('[info] maintenance mode disabled');
 				$output->writeln('');
@@ -354,6 +354,13 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 				$this->updater->log('[info] Disabling maintenance mode failed - return code: ' . $returnValueMaintenanceMode);
 				$output->writeln('');
 				$output->writeln('Disabling Maintenance mode failed - return code:' . $returnValueMaintenanceMode);
+				if ($systemOutput === false) {
+					$this->updater->log('[info] System call failed');
+					$output->writeln('System call failed');
+				} else {
+					$this->updater->log('[info] occ output: ' . $systemOutput);
+					$output->writeln('occ output: ' . $systemOutput);
+				}
 				$this->updater->log('[info] updater finished - with errors');
 				return $returnValueMaintenanceMode;
 			}