Copy error when trying to update 32.0.5 -> 32.0.6

[egg-tech-js]

When trying to update from 32.0.5 to 32.0.6 i get an copy error, see updater message below. No difference if using the web based updater or the cli updater. The error always appears on the same file nextlcoud.html. Is there a superfluous slash character in the file path?

Start update? [y/N] y

Info: Pressing Ctrl-C will finish the currently running step and then stops the updater.

[✔] Check for expected files
[✔] Check for write permissions
[ ] Create backup ...PHP Warning:  copy(): The second argument to copy() function cannot be a directory in phar:///nextcloud/updater/updater.phar/lib/Updater.php on line 447
[✘] Create backup failed
Could not copy "/nextcloud/core/doc/admin/configuration_files/external_storage/nextcloud.html" to "/nextcloud/data/updater-occov4ibhgrz/backups/nextcloud-32.0.5.0-1771838831//core/doc/admin/configuration_files/external_storage"

Update failed. To resume or retry just execute the updater again.

Server config

OS: Debian 12 (Bookworm)
Web Servr: Apache 2.4.66
DB: 10.11.14
PHP: 8.2.29

inxi -Fz

System:
  Kernel: 6.1.0-43-amd64 arch: x86_64 bits: 64 Console: pty pts/5 Distro: Debian GNU/Linux 12
    (bookworm)
Machine:
  Type: Kvm System: Hetzner product: vServer v: 20171111 serial: <filter>
  Mobo: KVM model: Standard PC (Q35 + ICH9, 2009) v: pc-q35-4.2 serial: N/A BIOS: Hetzner
    v: 20171111 date: 11/11/2017
CPU:
  Info: dual core model: Intel Xeon (Skylake IBRS no TSX) bits: 64 type: MCP cache: L2: 8 MiB
  Speed (MHz): avg: 2295 min/max: N/A cores: 1: 2295 2: 2295
Graphics:
  Device-1: Red Hat Virtio 1.0 GPU driver: virtio-pci v: 1
  Display: server: No display server data found. Headless machine? tty: 205x50
    resolution: 1280x800
  API: OpenGL Message: GL data unavailable in console for root.
Audio:
  Message: No device data found.
Network:
  Device-1: Red Hat Virtio 1.0 network driver: virtio-pci
  IF-ID-1: enp1s0 state: up speed: -1 duplex: unknown mac: <filter>
Drives:
  Local Storage: total: 88.15 GiB used: 75.31 GiB (85.4%)
  ID-1: /dev/sda vendor: QEMU model: HARDDISK size: 38.15 GiB
  ID-2: /dev/sdb model: 0HC Volume size: 50 GiB
Partition:
  ID-1: / size: 82.52 GiB used: 74.03 GiB (89.7%) fs: ext4 dev: /dev/dm-0
  ID-2: /boot size: 469.4 MiB used: 91.5 MiB (19.5%) fs: ext2 dev: /dev/sda1
  ID-3: /var size: 2.65 GiB used: 1.19 GiB (45.0%) fs: ext4 dev: /dev/dm-1
Swap:
  ID-1: swap-1 type: partition size: 976 MiB used: 0 KiB (0.0%) dev: /dev/dm-2
Sensors:
  Src: lm-sensors+/sys Message: No sensor data found using /sys/class/hwmon or lm-sensors.
Info:
  Processes: 139 Uptime: 56m Memory: 3.73 GiB used: 732.6 MiB (19.2%) Init: systemd
  target: graphical (5) Shell: Bash inxi: 3.3.26

Nextcloud config

"system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "nextcloud.solevi.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "32.0.5.0",
        "overwrite.cli.url": "https:\/\/nextcloud.solevi.de",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "DE",
        "default_language": "de",
        "default_locale": "de_DE",
        "mail_smtpauth": 1,
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtptimeout": 30,
        "mail_smtpport": "587",
        "mail_smtpdebug": true,
        "mail_smtpsecure": "tls",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "skeletondirectory": "",
        "profile.enabled": "false",
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "maintenance_window_start": 1,
        "trashbin_retention_obligation": "auto",
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

[Keeper-of-the-Keys]

I've been having the same issue for a while now (not sure if it started in 32 or before that), as I am able to work around it with --no-backup on the CLI (and I can just take a VM snapshot) I hadn't yet looked into it more.

Based on the error message and https://www.php.net/manual/en/function.copy.php

It seems that copy() is being used wrong unless it is supposed to use a Nextcloud version of copy that does support having a directory as a to argument.

Though it should be noted that the PHP doc makes no explicit mention of this limitation it only implies that to is a full file path, the comments though do warn about it and a quick test with the following code also shows this error.

~$ cat /tmp/cp.php 
<?php
copy('/home/user/somefile', '/tmp/user/');
?>
~$ php /tmp/cp.php 
PHP Warning:  copy(): The second argument to copy() function cannot be a directory in /tmp/cp.php on line 3
PHP Stack trace:
PHP   1. {main}() /tmp/cp.php:0
PHP   2. copy($from = '/home/user/somefile', $to = '/tmp/user/') /tmp/cp.php:3

HTH

[Keeper-of-the-Keys]

Hey I did some more digging reading the code, and I think the issue is not copy but the logic that splits the path:

updater/index.php

Line 505 in c7a0bb9

$relativePath = explode($this->nextcloudDir, $absolutePath)[1];

Because I installed nextcloud at /nextcloud on my server and I also happen to have the nextcloud_announcements app (I believe it is part of the default distribution because I don't recall installing it) and explode() seems to use /nextcloud as its delimiter it would "break" on the path /nextcloud/apps/nextcloud_announcements/composer.lock.

The fix for this is probably that $this->nextcloudDir should include a trailing /

[Keeper-of-the-Keys]

Based on my understanding the solution would need to live in the constructor (

updater/index.php

Line 59 in c7a0bb9

public function __construct(

)

And add a slash to the path if the path is longer than just '/', I also wonder if a path of just '/' should cause an exception or not....