Skip to content

Commit 3ad9554

Browse files
authored
Merge branch 'master' into prevent-group-removal
2 parents 67dde5d + 0200795 commit 3ad9554

File tree

11 files changed

+82
-23
lines changed

11 files changed

+82
-23
lines changed

.github/workflows/integration.yml

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,25 @@ jobs:
3838
strategy:
3939
fail-fast: false
4040
matrix:
41-
php-versions: [ "8.0", "8.1", "8.2", "8.3" ]
41+
php-versions: [ "8.0", "8.1", "8.2", "8.3", "8.4" ]
4242
databases: [ "mysql" ]
43-
server-versions: [ "stable28", "stable29", "stable30", "master" ]
43+
server-versions: [ "stable28", "stable29", "stable30", "stable31", "master" ]
4444
exclude:
4545
- server-versions: "master"
4646
php-versions: "8.0"
4747
databases: "mysql"
4848
- server-versions: "master"
4949
php-versions: "8.2"
5050
databases: "mysql"
51+
- server-versions: "stable31"
52+
php-versions: "8.2"
53+
databases: "mysql"
54+
- server-versions: "stable31"
55+
php-versions: "8.1"
56+
databases: "mysql"
57+
- server-versions: "stable31"
58+
php-versions: "8.0"
59+
databases: "mysql"
5160
- server-versions: "stable30"
5261
php-versions: "8.2"
5362
databases: "mysql"
@@ -66,6 +75,15 @@ jobs:
6675
- server-versions: "stable28"
6776
php-versions: "8.1"
6877
databases: "mysql"
78+
- server-versions: "stable28"
79+
php-versions: "8.4"
80+
databases: "mysql"
81+
- server-versions: "stable29"
82+
php-versions: "8.4"
83+
databases: "mysql"
84+
- server-versions: "stable30"
85+
php-versions: "8.4"
86+
databases: "mysql"
6987
include:
7088
- server-versions: "stable28"
7189
php-versions: "8.2"

CHANGELOG.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,26 @@
55
# Changelog
66
All notable changes to this project will be documented in this file.
77

8+
## 6.5.0
9+
10+
### Added
11+
12+
* [Feat(deps): Add Nextcloud 32 support (user_saml#921)](https://github.com/nextcloud/user_saml/pull/921)
13+
14+
### Fixed
15+
16+
* [Fix(UI): set value to the require_provisioned_account option also in env mode (user_saml#916)](https://github.com/nextcloud/user_saml/pull/916)
17+
* [Fix(GroupMigration): issue debug info on why a group is not being migrated (user_saml#923)](https://github.com/nextcloud/user_saml/pull/923)
18+
19+
### Dependencies
20+
21+
* [Build(deps): bump firebase/php-jwt from 6.10.2 to 6.11.0 (user_saml#924)](https://github.com/nextcloud/user_saml/pull/924)
22+
23+
### Under the hood
24+
25+
* [Chore(CI): Adjust testing matrix for Nextcloud 31 on master (user_saml#920)](https://github.com/nextcloud/user_saml/pull/920)
26+
* [Ci(integration): also test against PHP 8.4 (user_saml#922)](https://github.com/nextcloud/user_saml/pull/922)
27+
828
## 6.4.1
929

1030
### Fixed

appinfo/info.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ The following providers are supported and tested at the moment:
2020
* Any other provider that authenticates using the environment variable
2121
2222
While theoretically any other authentication provider implementing either one of those standards is compatible, we like to note that they are not part of any internal test matrix.]]></description>
23-
<version>6.4.1</version>
23+
<version>6.5.0</version>
2424
<licence>agpl</licence>
2525
<author>Lukas Reschke</author>
2626
<namespace>User_SAML</namespace>
@@ -37,7 +37,7 @@ While theoretically any other authentication provider implementing either one of
3737
<screenshot>https://raw.githubusercontent.com/nextcloud/user_saml/master/screenshots/1.png</screenshot>
3838
<screenshot>https://raw.githubusercontent.com/nextcloud/user_saml/master/screenshots/2.png</screenshot>
3939
<dependencies>
40-
<nextcloud min-version="28" max-version="31" />
40+
<nextcloud min-version="28" max-version="32" />
4141
</dependencies>
4242
<repair-steps>
4343
<post-migration>

composer.lock

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

l10n/es.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

l10n/es.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
"URL Location of the IdP where the SP will send the SLO Request" : "Dirección URL de el IdP donde el SP enviará las peticiones SLO",
7272
"URL Location of the IDP's SLO Response" : "Dirección URL de la respuesta SLO del IDP",
7373
"Public X.509 certificate of the IdP" : "Certificado público X.509 del IdP",
74+
"Request parameters to pass-through to IdP (comma separated list)" : "Parámetros de solicitud a transferir a IdP (lista separada por comas)",
7475
"Attribute mapping" : "Definición de atributos",
7576
"If you want to optionally map attributes to the user you can configure these here." : "Si opcionalmente quieres mapear atributos al usuario puedes configurar éstos aquí.",
7677
"Show attribute mapping settings…" : "Mostrar configuración de mapeado de atributos...",

l10n/sk.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

l10n/sk.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
"URL Location of the IdP where the SP will send the SLO Request" : "Umiestnenie URL IdP, kam SP zašle SLO požiadavku",
7272
"URL Location of the IDP's SLO Response" : "Umiestnenie URL IDP, kam SLO pošle odpoveď",
7373
"Public X.509 certificate of the IdP" : "Verejný certifikát X.509 poskytovateľa prihlasovacích údajov",
74+
"Request parameters to pass-through to IdP (comma separated list)" : "Parametre žiadosti pre predanie do IdP (zoznam oddelený čiarkou)",
7475
"Attribute mapping" : "Mapovanie atribútov",
7576
"If you want to optionally map attributes to the user you can configure these here." : "Ak chcete voliteľne priradiť atribúty k používateľom, môžete ich nastaviť tu.",
7677
"Show attribute mapping settings…" : "Zobraziť nastavenia priradzovania atribútov ...",

lib/Jobs/MigrateGroups.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,31 @@ protected function getGroupsToMigrate(array $samlGroups, array $pool): array {
111111

112112
$group = $this->groupManager->get($gid);
113113
if ($group === null) {
114+
$this->logger->debug('Not migrating group "{gid}": not found by the group manager', [
115+
'app' => 'user_saml',
116+
'gid' => $gid,
117+
]);
114118
return false;
115119
}
116120

117121
$backendNames = $group->getBackendNames();
118122
if (!in_array('Database', $backendNames, true)) {
123+
$this->logger->debug('Not migrating group "{gid}": not belonging to local database backend', [
124+
'app' => 'user_saml',
125+
'gid' => $gid,
126+
'backends' => $backendNames,
127+
]);
119128
return false;
120129
}
121130

122131
foreach ($group->getUsers() as $user) {
123132
if ($user->getBackendClassName() !== 'user_saml') {
133+
$this->logger->debug('Not migrating group "{gid}": user "{userId}" from a different backend "{userBackend}"', [
134+
'app' => 'user_saml',
135+
'gid' => $gid,
136+
'userId' => $user->getUID(),
137+
'userBackend' => $user->getBackendClassName(),
138+
]);
124139
return false;
125140
}
126141
}

lib/Settings/Admin.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,13 +175,14 @@ public function getForm() {
175175
}
176176

177177
$type = $this->config->getAppValue('user_saml', 'type');
178+
179+
$generalSettings['require_provisioned_account'] = [
180+
'text' => $this->l10n->t('Only allow authentication if an account exists on some other backend (e.g. LDAP).', [$this->defaults->getName()]),
181+
'type' => 'checkbox',
182+
'global' => true,
183+
'value' => $this->config->getAppValue('user_saml', 'general-require_provisioned_account', '0')
184+
];
178185
if ($type === 'saml') {
179-
$generalSettings['require_provisioned_account'] = [
180-
'text' => $this->l10n->t('Only allow authentication if an account exists on some other backend (e.g. LDAP).', [$this->defaults->getName()]),
181-
'type' => 'checkbox',
182-
'global' => true,
183-
'value' => $this->config->getAppValue('user_saml', 'general-require_provisioned_account', '0')
184-
];
185186
$generalSettings['idp0_display_name'] = [
186187
'text' => $this->l10n->t('Optional display name of the identity provider (default: "SSO & SAML log in")'),
187188
'type' => 'line',

0 commit comments

Comments
 (0)