Skip to content

Commit 797d9da

Browse files
authored
Merge pull request #458 from nextcloud/fix/logout_if_slo_errors
Handle failing SLO
2 parents ca771d4 + 160ad27 commit 797d9da

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lib/Controller/SAMLController.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,12 @@ public function singleLogoutService() {
406406
$nameIdNameQualifier = $this->session->get('user_saml.samlNameIdNameQualifier');
407407
$nameIdSPNameQualifier = $this->session->get('user_saml.samlNameIdSPNameQualifier');
408408
$sessionIndex = $this->session->get('user_saml.samlSessionIndex');
409-
$targetUrl = $auth->logout(null, [], $nameId, $sessionIndex, $stay, $nameIdFormat, $nameIdNameQualifier, $nameIdSPNameQualifier);
409+
try {
410+
$targetUrl = $auth->logout(null, [], $nameId, $sessionIndex, $stay, $nameIdFormat, $nameIdNameQualifier, $nameIdSPNameQualifier);
411+
} catch (Error $e) {
412+
$this->logger->logException($e, ['level' => ILogger::WARN]);
413+
$this->userSession->logout();
414+
}
410415
}
411416
if(!empty($targetUrl) && !$auth->getLastErrorReason()){
412417
$this->userSession->logout();

0 commit comments

Comments
 (0)