From dc70636b1be115f355bf183fa760d919346adc2e Mon Sep 17 00:00:00 2001 From: Git'Fellow <12234510+solracsf@users.noreply.github.com> Date: Fri, 15 Aug 2025 19:04:13 +0200 Subject: [PATCH 1/2] fix: remove unsupported function Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> --- lib/GroupManager.php | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/lib/GroupManager.php b/lib/GroupManager.php index 17ab71fe2..652ee0964 100644 --- a/lib/GroupManager.php +++ b/lib/GroupManager.php @@ -90,8 +90,6 @@ public function handleIncomingGroups(IUser $user, array $samlGroupNames): void { } $this->updateUserGroups($user, $samlGroupNames); - // TODO: drop following line with dropping NC 28 support - $this->evaluateGroupMigrations($samlGroupNames); } protected function updateUserGroups(IUser $user, array $samlGroupNames): void { @@ -223,15 +221,6 @@ protected function hasSamlBackend(IGroup $group): bool { return in_array('user_saml', $group->getBackendNames()); } - protected function evaluateGroupMigrations(array $groups): void { - $candidateInfo = $this->getCandidateInfoIfValid(); - if ($candidateInfo === null) { - return; - } - - $this->jobList->add(MigrateGroups::class, ['gids' => $groups]); - } - protected function isGroupInTransitionList(string $groupId): bool { $candidateInfo = $this->getCandidateInfoIfValid(); if (!$candidateInfo) { From 8c3f6d7c4a86e712d0dce5e319a08f2fa5d5535e Mon Sep 17 00:00:00 2001 From: Git'Fellow <12234510+solracsf@users.noreply.github.com> Date: Fri, 15 Aug 2025 19:06:44 +0200 Subject: [PATCH 2/2] fix: lint Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> --- lib/GroupManager.php | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/GroupManager.php b/lib/GroupManager.php index 652ee0964..6b2d4149d 100644 --- a/lib/GroupManager.php +++ b/lib/GroupManager.php @@ -9,7 +9,6 @@ use OCA\User_SAML\Exceptions\GroupNotFoundException; use OCA\User_SAML\Exceptions\NonMigratableGroupException; -use OCA\User_SAML\Jobs\MigrateGroups; use OCP\BackgroundJob\IJobList; use OCP\EventDispatcher\IEventDispatcher; use OCP\Group\Events\BeforeGroupCreatedEvent;