Fix NPE when getting error message and add HTTP response information (#4)

* Fix NPE when getting error message and add HTTP response information

Signed-off-by: jorgee <[email protected]>

* Print entity response when it is not an Error Message

Signed-off-by: jorgee <[email protected]>

* add custom exception and remove message parsing

Signed-off-by: jorgee <[email protected]>

---------

Signed-off-by: jorgee <[email protected]>

Author: jorgee

src/main/groovy/io/nextflow/gradle/registry/RegistryClient.groovy

@@ -2,10 +2,14 @@ package io.nextflow.gradle.registry
 
 import com.google.gson.Gson
 import groovy.transform.CompileStatic
+import groovy.util.logging.Slf4j
+import org.apache.http.client.methods.CloseableHttpResponse
 import org.apache.http.client.methods.HttpPost
 import org.apache.http.entity.mime.MultipartEntityBuilder
 import org.apache.http.impl.client.HttpClients
+import org.apache.http.util.EntityUtils
 
+@Slf4j
 @CompileStatic
 class RegistryClient {
     private final Gson gson = new Gson()
@@ -33,18 +37,21 @@ class RegistryClient {
              def rep = http.execute(req)) {
 
             if (rep.statusLine.statusCode != 200) {
-                def err = gson.fromJson(new InputStreamReader(rep.entity.content), ErrorResponse)
-                throw new RuntimeException("Failed to publish plugin: ${err.type} - ${err.message}")
+                throw new RegistryPublishException(getErrorMessage(rep))
             }
         } catch (ConnectException e) {
             throw new RuntimeException("Unable to connect to plugin repository: (${e.message})")
         }
     }
 
-    // ----------------------------------------------------------------------------
-
-    private static class ErrorResponse {
-        String type
-        String message
+    private String getErrorMessage(CloseableHttpResponse rep) {
+        def message = "Failed to publish plugin to registry $url: HTTP Response:${rep.statusLine}"
+        if( rep.entity ) {
+            final String entityStr = EntityUtils.toString(rep.entity)
+            if (entityStr) {
+                return "$message - $entityStr".toString()
+            }
+        }
+        return message.toString()
     }
 }

src/main/groovy/io/nextflow/gradle/registry/RegistryPublishException.groovy

@@ -0,0 +1,10 @@
+package io.nextflow.gradle.registry
+
+/**
+ * Custom exception class for registry publish task
+ */
+class RegistryPublishException extends Exception{
+    RegistryPublishException(String s) {
+        super(s)
+    }
+}