Revert Plugins.init() at run command to original location #6568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
|
Before we do this, I would like to understand why the params-file can be an S3 path but not an Azure path It doesn't seem like either of these use cases were ever intentionally supported, considering that the params file is loaded before the config, which means the params file shouldn't be able to access remote storage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6566
Commit 9e4c975 moved the Plugins.init() later in the code- Plugins.init() initializes the plugins manager, so autoStartIfMissing call done before loading the configuration will fail. It includes getting the Repository providers implemented in plugins or downloading remote param-files.
This PR moves again the Plugins.init() to begining of run command. This change doesn't affect secrets loading (tested in platform with
bentsherman/nf-tests -r plugin-secrets). The first time that the config is loaded, it uses the EmptySecretsProvider, it doesn't affect if a plugin has been loaded before.