Skip to content

Commit e356439

Browse files
committed
rethink the state level tests [ci skip]
1 parent 36560b2 commit e356439

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

plugins/nf-nomad/src/main/nextflow/nomad/executor/NomadTaskHandler.groovy

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,10 @@ class NomadTaskHandler extends TaskHandler implements FusionAwareTask {
102102
if(isSubmitted()) {
103103
def state = taskState0()
104104

105-
log.debug "[NOMAD] checkIfRunning task=$task.name; state=${state?.state}"
105+
log.debug "[NOMAD] checkIfRunning task=$task.name ; state=${state?.state}"
106106

107-
// include `terminated` state to allow the handler status to progress
108-
if( state && ( ["running","pending","unknown"].contains(state.state))){
107+
// if a state exists, include an array of states to determine task status
108+
if( state?.state && ( ["running","pending","unknown"].contains(state?.state))){
109109
this.status = TaskStatus.RUNNING
110110
determineClientNode()
111111
return true
@@ -121,9 +121,10 @@ class NomadTaskHandler extends TaskHandler implements FusionAwareTask {
121121

122122
def state = taskState0()
123123

124-
log.debug "[NOMAD] checkIfCompleted task=$task.name; state=${state?.state}"
124+
log.debug "[NOMAD] checkIfCompleted task=$task.name ; state=${state?.state}"
125125

126-
if( state && ( ["dead","complete"].contains(state.state))){
126+
// if a state exists, include an array of states to determine task status
127+
if( state?.state && ( ["dead"].contains(state.state))){
127128
// finalize the task
128129
task.exitStatus = readExitFile()
129130
task.stdout = outputFile
@@ -157,9 +158,8 @@ class NomadTaskHandler extends TaskHandler implements FusionAwareTask {
157158
}
158159

159160
String submitTask() {
160-
log.debug "[NOMAD] Submitting task ${task.name} - work-dir=${task.workDirStr}"
161161
if (!task.container)
162-
throw new ProcessSubmitException("Missing container image for process `$task.processor.name`")
162+
throw new ProcessSubmitException("[NOMAD] Missing container image for process `$task.processor.name`")
163163

164164
def builder = createBashWrapper(task)
165165
builder.build()
@@ -172,7 +172,7 @@ class NomadTaskHandler extends TaskHandler implements FusionAwareTask {
172172
nomadService.submitTask(this.jobName, task, taskLauncher, taskEnv, debugPath())
173173

174174
// submit the task execution
175-
log.debug "[NOMAD] Submitted task ${task.name} with taskId=${this.jobName}"
175+
log.debug "[NOMAD] submitTask task=${task.name} ; taskId=${this.jobName} ; work-dir=${task.workDirStr}"
176176
// update the status
177177
this.status = TaskStatus.SUBMITTED
178178
}
@@ -219,7 +219,7 @@ class NomadTaskHandler extends TaskHandler implements FusionAwareTask {
219219
if (!status || delta >= 1_000) {
220220

221221
def newState = nomadService.getTaskState(jobName)
222-
log.debug "[NOMAD] taskState0 jobName=$jobName currentState=${state?.state} newState=${newState?.state}"
222+
log.debug "[NOMAD] taskState0 task=$jobName ; currentState=${state?.state} ; newState=${newState?.state}"
223223

224224
if (newState) {
225225
state = newState
@@ -244,12 +244,11 @@ class NomadTaskHandler extends TaskHandler implements FusionAwareTask {
244244
}
245245

246246

247-
248247
private void determineClientNode(){
249248
try {
250249
if ( !clientName )
251250
clientName = nomadService.getClientOfJob( jobName )
252-
log.debug "[NOMAD] determineClientNode: jobName:$jobName; clientName:$clientName"
251+
log.debug "[NOMAD] determineClientNode: jobName:$jobName ; clientName:$clientName"
253252
} catch ( Exception e ){
254253
log.debug ("[NOMAD] Unable to get the client name of job $jobName -- awaiting for a client to be assigned.")
255254
}

validation/sun-nomadlab/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
2+
3+

0 commit comments

Comments
 (0)