finish refactoring tests

Author: nvnieuwk

.groovylintrc.json

@@ -6,6 +6,15 @@
         },
         "DuplicateStringLiteral": {
             "enabled": false
+        },
+        "JUnitLostTest": {
+            "enabled": false
+        },
+        "JUnitPublicNonTestMethod": {
+            "enabled": false
+        },
+        "JUnitTestMethodWithoutAssert": {
+            "enabled": false
         }
     }
 }

src/test/groovy/nextflow/validation/ConfigTest.groovy

@@ -1,10 +1,9 @@
-/* groovylint-disable LineLength, TrailingWhitespace */
+/* groovylint-disable LineLength, MethodName, TrailingWhitespace */
 package nextflow.validation
 
-import java.nio.file.Path
+import groovy.transform.CompileDynamic
 
 import nextflow.Session
-import spock.lang.Shared
 import org.junit.Rule
 import test.Dsl2Spec
 import test.OutputCapture
@@ -14,27 +13,18 @@ import nextflow.validation.config.ValidationConfig
 /**
  * @author : nvnieuwk <[email protected]>
  */
+
+@CompileDynamic
 class ConfigTest extends Dsl2Spec {
 
     @Rule
-    OutputCapture capture = new OutputCapture()
-
-    @Shared String pluginsMode
-
-    Path root = Path.of('.').toAbsolutePath().normalize()
-    Path getRoot() { this.root }
-    String getRootString() { this.root.toString() }
+    final private OutputCapture capture = new OutputCapture()
 
-    private Session session
-
-    def setup() {
-        session = Mock(Session)
-        session.getBaseDir() >> getRoot()
-    }
+    final private Session session = Mock(Session)
 
-    def 'test valid config' () {
+    void 'test valid config'() {
         given:
-        def config = [
+        Map config = [
             lenientMode: true,
             monochromeLogs: true,
             maxErrValSize: 20,
@@ -60,25 +50,24 @@ class ConfigTest extends Dsl2Spec {
                 unrecognisedHeaders: 'error'
             ]
         ]
-        def params = [:]
 
         when:
         new ValidationConfig(config, session)
-        def stdout = capture
+        List<String> stdout = capture
             .toString()
             .readLines()
-            .findResults { it.contains('WARN') ? it : null }
+            .findResults { line -> line.contains('WARN') ? line : null }
 
         then:
         noExceptionThrown()
         !stdout
     }
 
-    def 'test valid config - GStrings' () {
+    void 'test valid config - GStrings'() {
         given:
-        def randomString = 'randomString'
-        def errorLevel = 'error'
-        def config = [
+        String randomString = 'randomString'
+        String errorLevel = 'error'
+        Map config = [
             lenientMode: true,
             monochromeLogs: true,
             maxErrValSize: 20,
@@ -104,23 +93,22 @@ class ConfigTest extends Dsl2Spec {
                 unrecognisedHeaders: "${errorLevel}"
             ]
         ]
-        def params = [:]
 
         when:
         new ValidationConfig(config, session)
-        def stdout = capture
+        List<String> stdout = capture
             .toString()
             .readLines()
-            .findResults { it.contains('WARN') ? it : null }
+            .findResults { line -> line.contains('WARN') ? line : null }
 
         then:
         noExceptionThrown()
         !stdout
     }
 
-    def 'test invalid config' () {
+    void 'test invalid config'() {
         given:
-        def config = [
+        Map config = [
             lenientMode: 'notABoolean',
             monochromeLogs: 12,
             showHiddenParams: 'notABoolean',
@@ -147,14 +135,13 @@ class ConfigTest extends Dsl2Spec {
                 unrecognisedHeaders: 589654
             ]
         ]
-        def params = [:]
 
         when:
         new ValidationConfig(config, session)
-        def stdout = capture
+        List<String> stdout = capture
             .toString()
             .readLines()
-            .findResults { it.contains('WARN') ? it : null }
+            .findResults { line -> line.contains('WARN') ? line : null }
 
         then:
         noExceptionThrown()