Skip to content

Commit d7c6e64

Browse files
Issue 22187: [sflow] Remove unnecessary 'config reload' call (sonic-net#21190)
There is an extra 'config reload' call in the test_sflow.py test setup code. It was added as a workaround for a bug that was filed in 2019, and the workaround was supposed to have been removed in 2021, but the commend and the 'config reload' call are still there. The test passes fine without it, and it adds several minutes of overhead.
1 parent 202aa79 commit d7c6e64

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

tests/sflow/test_sflow.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,16 +112,10 @@ def setup_ptf(ptfhost, collector_ports):
112112

113113

114114
def config_dut_ports(duthost, ports, vlan):
115-
# https://github.com/sonic-net/sonic-buildimage/issues/2665
116-
# Introducing config vlan member add and remove for the test port due to above mentioned PR.
117-
# Even though port is deleted from vlan , the port shows its master as Bridge upon assigning ip address.
118-
# Hence config reload is done as workaround. ##FIXME
119115
for i in range(len(ports)):
120116
duthost.command('config vlan member del %s %s' % (vlan, ports[i]), module_ignore_errors=True)
121117
duthost.command('config interface ip add %s %s/24' %
122118
(ports[i], var['dut_intf_ips'][i]))
123-
duthost.command('config save -y')
124-
config_reload(duthost, config_source='config_db', wait=120)
125119
time.sleep(5)
126120

127121
# ----------------------------------------------------------------------------------$

0 commit comments

Comments
 (0)