解决logger中polling_topic_sub指针判断错误

Signed-off-by: latercomer <[email protected]>

Author: ComerLater

.github/workflows/build-action-test.yml

@@ -50,15 +50,27 @@ jobs:
         with:
           python-version: "3.11"
 
-      - name: Install Build Toolchain
+      - name: Setup Compile System
         shell: bash
         run: |
+          sudo apt-get update -y
+          sudo apt-get upgrade -y
           sudo apt-get install gcc gdb-multiarch -y
           sudo apt-get install gcc-arm-none-eabi binutils-arm-none-eabi -y
           sudo apt-get install qemu-system-arm -y
           # sudo apt-get install libncurses5 libncurses5-dev libncursesw5-dev -y
           python3 -m pip install -r tools/install/requirements_v3.txt
 
+      - name: Display Toolchain Info
+        shell: bash
+        run: |
+          echo "python: $(python3 -V), $(which python3)"
+          echo "pip: $(pip3 -V)"
+          echo "scons: $(which scons)"
+          echo "$(scons --version)"
+          echo "gcc: $(which arm-none-eabi-gcc)"
+          echo "$(arm-none-eabi-gcc --version)"
+
       - name: Build bsps/silt/qemu
         shell: bash
         run: |

apps/storage/logger/logger.cpp

@@ -634,7 +634,7 @@ void Logger::run() {
     }
 
     /* init the update timer */
-    struct hrt_call timer_call {};
+    struct hrt_call timer_call{};
 
     rt_sem_init(&_timer_callback_data.semaphore, "callback_lock", 0, RT_IPC_FLAG_PRIO);
     /* timer_semaphore use case is a signal */
@@ -645,7 +645,7 @@ void Logger::run() {
     if (_polling_topic_meta) {
         polling_topic_sub = orb_subscribe(_polling_topic_meta);
 
-        if (polling_topic_sub < 0) {
+        if (!polling_topic_sub) {
             PX4_ERR("Failed to subscribe (%i)", errno);
         }
 
@@ -913,7 +913,7 @@ void Logger::run() {
     // stop the writer thread
     _writer.thread_stop();
 
-    if (polling_topic_sub >= 0) {
+    if (polling_topic_sub) {
         orb_unsubscribe(polling_topic_sub);
     }