Skip to content

Change static data file property names  #1196

@genehack

Description

@genehack

I like "maintainers" and "title" since those are the key names in the Auspice JSON schema. Why not change SARS-CoV2-Datasets.yaml instead?

Because it wouldn't be just changing SARS-CoV2-Datasets.yaml; the change here wasn't to synch the community datasets YAML with the Covid YAML, but to synch it with the property names used by the DatasetType of components/dataset-select/types.ts.

Changing the Covid data file would require matching changes across the entire <DatasetSelect> component (and probably in the /ncov and /sars-cov-2 page components). The scope of that change felt much larger than "make /community work under App Router".

If folks feel strongly about making this change in the other direction, I'll make a distinct issue for it, but I don't think it belongs in this PR.

Originally posted by @genehack in #1194 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions