Skip to content

Review of initial commit #2

@PeterC-DLS

Description

@PeterC-DLS

A quick review shows some issues to be addressed:

  • NeXusOntology_V1.1.py should not have the version in its name. Derive version from branch or constant, instead.
  • Remove the notebook as it duplicates the script.
  • FedIDs should be removed L23-4
  • Reading non-existent files will fail L113-6
  • Use endswith L166 and later lines
  • Append to list instead of combining new lists L167 and later lines
  • Use a string's join method L180
  • Use temporary variable instead of repeatedly dereferencing multiple dictionaries L188-207
  • Allow GH token to be passed as argument or obtained from the shell environment
  • Split script to functions
  • Avoid use of wildcard import on L342
  • Reformat string in L419
  • Do not run test code L534
  • Remove extraneous comments

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions