-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
A quick review shows some issues to be addressed:
NeXusOntology_V1.1.pyshould not have the version in its name. Derive version from branch or constant, instead.- Remove the notebook as it duplicates the script.
- FedIDs should be removed L23-4
- Reading non-existent files will fail L113-6
- Use endswith L166 and later lines
- Append to list instead of combining new lists L167 and later lines
- Use a string's
joinmethod L180 - Use temporary variable instead of repeatedly dereferencing multiple dictionaries L188-207
- Allow GH token to be passed as argument or obtained from the shell environment
- Split script to functions
- Avoid use of wildcard import on L342
- Reformat string in L419
- Do not run test code L534
- Remove extraneous comments
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels