refactor: cleanup DatabaseHandler::gc() for session (codeigniter4#9230)

grimpirate · michalsn · web-flow · commit 11d97212edf8 · 2024-10-22T08:25:43.000+02:00
* Removal of unneeded operations/variables

* Update system/Session/Handlers/DatabaseHandler.php

---------

Co-authored-by: Michal Sniatala &lt;michal@sniatala.pl&gt;
diff --git a/system/Session/Handlers/DatabaseHandler.php b/system/Session/Handlers/DatabaseHandler.php
@@ -282,12 +282,9 @@ public function destroy($id): bool
     #[ReturnTypeWillChange]
     public function gc($max_lifetime)
     {
-        $separator = ' ';
-        $interval  = implode($separator, ['', "{$max_lifetime} second", '']);
-
         return $this->db->table($this->table)->where(
             'timestamp <',
-            "now() - INTERVAL {$interval}",
+            "now() - INTERVAL {$max_lifetime} second",
             false
         )->delete() ? 1 : $this->fail();
     }

Original file line number	Diff line number	Diff line change
`@@ -282,12 +282,9 @@ public function destroy($id): bool`
`282`	`282`	`#[ReturnTypeWillChange]`
`283`	`283`	`public function gc($max_lifetime)`
`284`	`284`	`{`
`285`		`- $separator = ' ';`
`286`		`- $interval = implode($separator, ['', "{$max_lifetime} second", '']);`
`287`		`-`
`288`	`285`	`return $this->db->table($this->table)->where(`
`289`	`286`	`'timestamp <',`
`290`		`- "now() - INTERVAL {$interval}",`
	`287`	`+ "now() - INTERVAL {$max_lifetime} second",`
`291`	`288`	`false`
`292`	`289`	`)->delete() ? 1 : $this->fail();`
`293`	`290`	`}`