skip FinalizeTestCaseClassRector and DeclareStrictTypesTestsRector config

Author: samsonasik

rector.php

@@ -37,6 +37,7 @@
 use Rector\PHPUnit\CodeQuality\Rector\Class_\RemoveDataProviderParamKeysRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
 use Rector\PHPUnit\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector;
+use Rector\PHPUnit\CodeQuality\Rector\StmtsAwareInterface\DeclareStrictTypesTestsRector;
 use Rector\Privatization\Rector\Class_\FinalizeTestCaseClassRector;
 use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
@@ -180,8 +181,11 @@
             __DIR__ . '/tests/system/AutoReview/FrameworkCodeTest.php',
         ],
 
-        FinalizeTestCaseClassRector::class => [
-            __DIR__ . '/tests/system/Validation/FormatRulesTest.php',
+        // some tests extended by other tests
+        FinalizeTestCaseClassRector::class,
+
+        DeclareStrictTypesTestsRector::class => [
+            __DIR__ . '/tests/system/Debug/ExceptionsTest.php',
         ],
     ])
     // auto import fully qualified class names

tests/system/Autoloader/FileLocatorTest.php

@@ -25,12 +25,12 @@
  * @no-final
  */
 #[Group('Others')]
-final class FileLocatorTest extends CIUnitTestCase
+class FileLocatorTest extends CIUnitTestCase
 {
     /**
      * @var FileLocator|FileLocatorCached
      */
-    private FileLocatorInterface $locator;
+    protected FileLocatorInterface $locator;
 
     protected function setUp(): void
     {

tests/system/Database/Live/TransactionDBDebugTrueTest.php

@@ -26,7 +26,7 @@
  * @no-final
  */
 #[Group('DatabaseLive')]
-final class TransactionDBDebugTrueTest extends CIUnitTestCase
+class TransactionDBDebugTrueTest extends CIUnitTestCase
 {
     use DatabaseTestTrait;
 

tests/system/Debug/ExceptionsTest.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * This file is part of CodeIgniter 4 framework.
  *

tests/system/HTTP/CURLRequestTest.php

@@ -30,9 +30,9 @@
  * @no-final
  */
 #[Group('Others')]
-final class CURLRequestTest extends CIUnitTestCase
+class CURLRequestTest extends CIUnitTestCase
 {
-    private MockCURLRequest $request;
+    protected MockCURLRequest $request;
 
     protected function setUp(): void
     {

tests/system/Validation/RulesTest.php

@@ -26,14 +26,14 @@
  * @no-final
  */
 #[Group('Others')]
-final class RulesTest extends CIUnitTestCase
+class RulesTest extends CIUnitTestCase
 {
-    private Validation $validation;
+    protected Validation $validation;
 
     /**
      * @var array<string, array<int|string, array<string, string>|string>>
      */
-    private array $config = [
+    protected array $config = [
         'ruleSets' => [
             Rules::class,
             FormatRules::class,

tests/system/Validation/StrictRules/CreditCardRulesTest.php

@@ -25,14 +25,14 @@
  * @no-final
  */
 #[Group('Others')]
-final class CreditCardRulesTest extends CIUnitTestCase
+class CreditCardRulesTest extends CIUnitTestCase
 {
-    private Validation $validation;
+    protected Validation $validation;
 
     /**
      * @var array<string, array<int|string, array<string, string>|string>>
      */
-    private array $config = [
+    protected array $config = [
         'ruleSets' => [
             Rules::class,
             FormatRules::class,

tests/system/Validation/StrictRules/DatabaseRelatedRulesTest.php

@@ -28,11 +28,11 @@
  * @no-final
  */
 #[Group('DatabaseLive')]
-final class DatabaseRelatedRulesTest extends CIUnitTestCase
+class DatabaseRelatedRulesTest extends CIUnitTestCase
 {
     use DatabaseTestTrait;
 
-    private Validation $validation;
+    protected Validation $validation;
 
     /**
      * @var array{
@@ -41,7 +41,7 @@ final class DatabaseRelatedRulesTest extends CIUnitTestCase
      *   groupA_errors: array<string, array<string, string>>,
      * }
      */
-    private array $config = [
+    protected array $config = [
         'ruleSets' => [
             Rules::class,
             FormatRules::class,

tests/system/Validation/StrictRules/FileRulesTest.php

@@ -25,14 +25,14 @@
  * @no-final
  */
 #[Group('Others')]
-final class FileRulesTest extends CIUnitTestCase
+class FileRulesTest extends CIUnitTestCase
 {
-    private Validation $validation;
+    protected Validation $validation;
 
     /**
      * @var array<string, array<int|string, array<string, string>|string>>
      */
-    private array $config = [
+    protected array $config = [
         'ruleSets' => [
             Rules::class,
             FormatRules::class,

tests/system/Validation/ValidationTest.php

@@ -33,14 +33,14 @@
  * @no-final
  */
 #[Group('Others')]
-final class ValidationTest extends CIUnitTestCase
+class ValidationTest extends CIUnitTestCase
 {
-    private Validation $validation;
+    protected Validation $validation;
 
     /**
      * @var array<string, array<int|string, array<string, array<string, string>|string>|string>|string>
      */
-    private static array $config = [
+    protected static array $config = [
         'ruleSets' => [
             Rules::class,
             FormatRules::class,
@@ -82,7 +82,7 @@ final class ValidationTest extends CIUnitTestCase
     protected function setUp(): void
     {
         parent::setUp();
-        $this->validation = new Validation((object) self::$config, service('renderer'));
+        $this->validation = new Validation((object) static::$config, service('renderer'));
         $this->validation->reset();
     }
 
@@ -227,7 +227,7 @@ public static function provideSetRuleRulesFormat(): iterable
 
         yield 'fail-deep-object' => [
             false,
-            new Validation((object) self::$config, service('renderer')),
+            new Validation((object) static::$config, service('renderer')),
         ];
 
         yield 'pass-multiple-string' => [
@@ -1007,18 +1007,18 @@ public function testShowBadTemplate(): void
     public function testNoRuleSetsSetup(): void
     {
         try {
-            $rulesets = self::$config['ruleSets'];
+            $rulesets = static::$config['ruleSets'];
 
-            self::$config['ruleSets'] = null;
-            (new Validation((object) self::$config, service('renderer')))
+            static::$config['ruleSets'] = null;
+            (new Validation((object) static::$config, service('renderer')))
                 ->reset()
                 ->run(['foo' => '']);
 
             $this->fail(sprintf('%s should throw %s.', __METHOD__, ValidationException::class));
         } catch (Throwable $e) {
             $this->assertInstanceOf(ValidationException::class, $e);
         } finally {
-            self::$config['ruleSets'] = $rulesets;
+            static::$config['ruleSets'] = $rulesets;
         }
     }