Skip to content

Commit 13a6a44

Browse files
authored
Merge pull request #473 from atrigila/deseq_formula
Add formula to `DESEQ2`
2 parents 79603fc + 0b22661 commit 13a6a44

File tree

26 files changed

+1009
-476
lines changed

26 files changed

+1009
-476
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
### Added
99

10+
- [[#473](https://github.com/nf-core/differentialabundance/pull/473)] - Allow formula-based contrasts in DESEQ2. ([@atrigila](https://github.com/atrigila), review by [@pinin4fjords](https://github.com/pinin4fjords) and [@grst](https://github.com/grst)).
1011
- [[#443](https://github.com/nf-core/differentialabundance/pull/443)] - Add toolsheet-related implementations. ([@suzannejin](https://github.com/suzannejin), review by [@pinin4fjords](https://github.com/pinin4fjords), [@mirpedrol](https://github.com/mirpedrol) and [@JoseEspinosa](https://github.com/JoseEspinosa))
1112
- [[#450](https://github.com/nf-core/differentialabundance/pull/441)] - Allow usage of strings for makeContrasts in DREAM. ([@atrigila](https://github.com/atrigila), review by [@pinin4fjords](https://github.com/pinin4fjords), [@suzannejin](https://github.com/suzannejin) and [@grst](https://github.com/grst)).
1213
- [[#441](https://github.com/nf-core/differentialabundance/pull/441)] - Add dream differential module. ([@nschcolnicov](https://github.com/nschcolnicov) and [@alanmmobbs93](https://github.com/alanmobbs93), review by [@pinin4fjords](https://github.com/pinin4fjords), [@suzannejin](https://github.com/suzannejin) and [@grst](https://github.com/grst)).

conf/modules.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ process {
267267
"--vst_nsub $meta.params.deseq2_vst_nsub",
268268
"--shrink_lfc $meta.params.deseq2_shrink_lfc",
269269
"--cores $meta.params.deseq2_cores",
270+
"--seed $meta.params.deseq2_seed",
270271
"--subset_to_contrast_samples $meta.params.differential_subset_to_contrast_samples",
271272
((meta.params.round_digits != null && meta.params.round_digits > 0) ? "--round_digits $meta.params.round_digits" : ""),
272273
((meta.blocking == null) ? '' : "--blocking_variables $meta.blocking")

docs/usage.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,7 @@ contrasts:
200200
The necessary fields in order are:
201201

202202
- `formula` - A string representation of the model formula. It is used to build the design matrix.
203-
- `make_contrasts_str` - An explicit literal contrast string (e.g., "treatmenthND6 - treatmentmCherry") that is passed directly to [`limma::makeContrasts()`](https://rdrr.io/bioc/limma/man/makeContrasts.html) in `VARIANCEPARTITION_DREAM` and `LIMMA_DIFFERENTIAL`. The parameter names must be syntactically valid variable names in R (see [`make.names`](https://stat.ethz.ch/R-manual/R-devel/library/base/html/make.names.html)). This field provides full control for complex designs. Requires `formula`.
204-
205-
> [!WARNING]
206-
> Formula-based contrasts are currently only supported by `VARIANCEPARTITION_DREAM` and `LIMMA_DIFFERENTIAL`. They **do not work** with tools like `DESEQ2` yet.
203+
- `make_contrasts_str` - An explicit literal contrast string (e.g., "treatmenthND6 - treatmentmCherry") that is passed directly to [`limma::makeContrasts()`](https://rdrr.io/bioc/limma/man/makeContrasts.html) in `VARIANCEPARTITION_DREAM`, `LIMMA_DIFFERENTIAL` and `DESEQ2_DIFFERENTIAL`. The parameter names must be syntactically valid variable names in R (see [`make.names`](https://stat.ethz.ch/R-manual/R-devel/library/base/html/make.names.html)). This field provides full control for complex designs. Requires `formula`.
207204

208205
> [!NOTE]
209206
>
@@ -223,7 +220,6 @@ Beyond the basic one-factor comparison, the YAML contrasts format supports advan
223220
contrasts:
224221
- id: genotype_WT_KO_treatment_Control_Treated
225222
formula: "~ genotype * treatment"
226-
comparison: ["genotype", "WT", "KO"]
227223
make_contrasts_str: "genotypeKO.treatmentTreated"
228224
```
229225

modules.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818
"custom/filterdifferentialtable": {
1919
"branch": "master",
20-
"git_sha": "81880787133db07d9b4c1febd152c090eb8325dc",
20+
"git_sha": "41dfa3f7c0ffabb96a6a813fe321c6d1cc5b6e46",
2121
"installed_by": ["abundance_differential_filter"]
2222
},
2323
"custom/matrixfilter": {
@@ -42,7 +42,7 @@
4242
},
4343
"deseq2/differential": {
4444
"branch": "master",
45-
"git_sha": "25c228dd132d91596e87b636b0e03fd48d4c951a",
45+
"git_sha": "2e24bf8b6b045e1cf56a2907306b008113a686d0",
4646
"installed_by": ["abundance_differential_filter"]
4747
},
4848
"geoquery/getgeo": {
@@ -72,7 +72,7 @@
7272
},
7373
"limma/differential": {
7474
"branch": "master",
75-
"git_sha": "41d1a6ad16756e12a424e508cbe3a1b3b8639946",
75+
"git_sha": "41dfa3f7c0ffabb96a6a813fe321c6d1cc5b6e46",
7676
"installed_by": ["abundance_differential_filter"]
7777
},
7878
"propr/grea": {
@@ -82,7 +82,7 @@
8282
},
8383
"propr/propd": {
8484
"branch": "master",
85-
"git_sha": "ce6e8e8bc0c00d284733d7c48ddc794873f60ffe",
85+
"git_sha": "41dfa3f7c0ffabb96a6a813fe321c6d1cc5b6e46",
8686
"installed_by": ["abundance_differential_filter"]
8787
},
8888
"proteus/readproteingroups": {
@@ -122,7 +122,7 @@
122122
},
123123
"variancepartition/dream": {
124124
"branch": "master",
125-
"git_sha": "c48c4b3d11fb243c888235d1e6b18d6c5059b2bb",
125+
"git_sha": "73b1b0fc276e2a6bd753e4d3d10d754b72a3e345",
126126
"installed_by": ["abundance_differential_filter"]
127127
},
128128
"zip": {
@@ -136,7 +136,7 @@
136136
"nf-core": {
137137
"abundance_differential_filter": {
138138
"branch": "master",
139-
"git_sha": "4006954b7bfbbc61c7d5fb009319ed536d2ffca4",
139+
"git_sha": "2e24bf8b6b045e1cf56a2907306b008113a686d0",
140140
"installed_by": ["subworkflows"]
141141
},
142142
"differential_functional_enrichment": {

modules/nf-core/custom/filterdifferentialtable/meta.yml

Lines changed: 17 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/deseq2/differential/main.nf

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/deseq2/differential/meta.yml

Lines changed: 93 additions & 43 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)