Skip to content

Commit 755ca35

Browse files
authored
Merge pull request #298 from drpatelh/fixes
export CONDA_PREFIX into container when using Singularity and Apptainer
2 parents 03ac573 + cdc31b9 commit 755ca35

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Special thanks to the following for their contributions to the release:
2020
- [Alexandru Mizeranschi](https://github.com/nicolae06)
2121
- [Alexander Blaessle](https://github.com/alexblaessle)
2222
- [Lukas Forer](https://github.com/lukfor)
23+
- [Matt Niederhuber](https://github.com/mniederhuber)
2324
- [Maxime Garcia](https://github.com/maxulysse)
2425
- [Sateesh Peri](https://github.com/sateeshperi)
2526
- [Sebastian Uhrig](https://github.com/suhrig)
@@ -54,6 +55,7 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
5455
- [PR #294](https://github.com/nf-core/fetchngs/pull/294) - Replace mermaid diagram with subway map
5556
- [PR #295](https://github.com/nf-core/fetchngs/pull/295) - Be less stringent with test expectations for CI
5657
- [PR #296](https://github.com/nf-core/fetchngs/pull/296) - Remove params.outdir from tests where required and update snapshots
58+
- [PR #298](https://github.com/nf-core/fetchngs/pull/298) - `export CONDA_PREFIX` into container when using Singularity and Apptainer
5759

5860
### Software dependencies
5961

modules/local/aspera_cli/main.nf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,11 @@ process ASPERA_CLI {
1818

1919
script:
2020
def args = task.ext.args ?: ''
21+
def conda_prefix = ['singularity', 'apptainer'].contains(workflow.containerEngine) ? "export CONDA_PREFIX=/usr/local" : ""
2122
if (meta.single_end) {
2223
"""
24+
$conda_prefix
25+
2326
ascp \\
2427
$args \\
2528
-i \$CONDA_PREFIX/etc/aspera/aspera_bypass_dsa.pem \\
@@ -36,6 +39,8 @@ process ASPERA_CLI {
3639
"""
3740
} else {
3841
"""
42+
$conda_prefix
43+
3944
ascp \\
4045
$args \\
4146
-i \$CONDA_PREFIX/etc/aspera/aspera_bypass_dsa.pem \\

nextflow.config

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,6 @@ try {
7070
// Workflow specific configs
7171
includeConfig './workflows/sra/nextflow.config'
7272

73-
// Load nf-core/fetchngs custom profiles from different institutions.
74-
// Warning: Uncomment only if a pipeline-specific institutional config already exists on nf-core/configs!
75-
// try {
76-
// includeConfig "${params.custom_config_base}/pipeline/fetchngs.config"
77-
// } catch (Exception e) {
78-
// System.err.println("WARNING: Could not load nf-core/config/fetchngs profiles: ${params.custom_config_base}/pipeline/fetchngs.config")
79-
// }
80-
8173
profiles {
8274
debug {
8375
dumpHashes = true

0 commit comments

Comments
 (0)