-
Notifications
You must be signed in to change notification settings - Fork 928
feat: addition of vembrane sort module #9294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert snapshot(process.out).match() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { assert snapshot(process.out).match() } | |
| { assert snapshot( | |
| process.out, | |
| path(process.out.versions[0]).yaml | |
| ).match() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added in the other PR right?, can you remove it here? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what I meant: can you please do one PR per module :) meaning one seperate one for vembrane/table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run
nextflow lint -format -sort-declarations -spaces 4 -harshil-alignment modules/nf-core/vembrane/sort/main.nf
please? :)
|
|
Seems like gzipped vcfs are not allowed. I would suggest to open an issue over at the vembrane repo to request that and remove it from the module for now :) You can link to the PR in the issue you open :) |
| test("homo_sapiens - [vcf] - vcf - compressed_output") { | ||
|
|
||
| config "./nextflow.config" | ||
|
|
||
| when { | ||
| params { | ||
| vembrane_args = '--output-fmt vcf.gz' | ||
| } | ||
| process { | ||
| """ | ||
| input[0] = [ | ||
| [ id:'test_gz' ], // meta map | ||
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/illumina/vcf/test.rnaseq.vcf', checkIfExists: true) | ||
| ] | ||
| input[1] = 'QUAL' | ||
| """ | ||
| } | ||
| } | ||
|
|
||
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert snapshot(process.out).match() } | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| test("homo_sapiens - [vcf] - vcf - compressed_output") { | |
| config "./nextflow.config" | |
| when { | |
| params { | |
| vembrane_args = '--output-fmt vcf.gz' | |
| } | |
| process { | |
| """ | |
| input[0] = [ | |
| [ id:'test_gz' ], // meta map | |
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/illumina/vcf/test.rnaseq.vcf', checkIfExists: true) | |
| ] | |
| input[1] = 'QUAL' | |
| """ | |
| } | |
| } | |
| then { | |
| assertAll( | |
| { assert process.success }, | |
| { assert snapshot(process.out).match() } | |
| ) | |
| } | |
| } |
| - "*.vcf*": | ||
| type: file | ||
| description: Sorted VCF file (can be compressed) | ||
| pattern: "*.{vcf,vcf.gz}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pattern: "*.{vcf,vcf.gz}" | |
| pattern: "*.{vcf,bcf}" |
PR checklist
Fixes #9265
Addition of the vembrane sort module https://github.com/vembrane/vembrane
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda