Use nf-core-bot to do approvals

Author: ewels

.github/workflows/rfc_approval.yml

@@ -6,10 +6,6 @@ on:
   issue_comment:
     types: [created, edited]
 
-permissions:
-  contents: read
-  issues: write
-
 jobs:
   rfc_approval:
     # Only run for RFC proposal issues that are still open
@@ -20,7 +16,7 @@ jobs:
       - name: Handle RFC approval logic
         uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
+          github-token: ${{ secrets.nf_core_bot_auth_token }}
           script: |
             const issueNumber = context.issue.number;
             const org = context.repo.owner;
@@ -30,21 +26,30 @@ jobs:
             // Fetch members of the core team
             // ---------------------------------------------
             async function getTeamMembers() {
-              const res = await github.request('GET /orgs/{org}/teams/{team_slug}/members', {
-                org,
-                team_slug: 'core',
-                per_page: 100
-              });
-              return res.data.map(m => m.login);
+              try {
+                const res = await github.request('GET /orgs/{org}/teams/{team_slug}/members', {
+                  org,
+                  team_slug: 'core',
+                  per_page: 100
+                });
+                console.log(`Fetched ${res.data.length} core team members.`);
+                return res.data.map(m => m.login);
+              } catch (err) {
+                console.error('Failed to fetch core team members:', err);
+                throw err;
+              }
             }
 
             const teamMembers = await getTeamMembers();
+            console.log('Core team members:', teamMembers);
             const quorum = Math.ceil(teamMembers.length / 2);
+            console.log(`Quorum set to ${quorum}.`);
 
             // -------------------------------------------------
             // If this workflow was triggered by issue creation
             // -------------------------------------------------
             if (context.eventName === 'issues' && context.payload.action === 'opened') {
+              console.log('Creating initial comment for review status');
               const body = `# RFC approval status: Pending\n\nCore team approvers:\nRejection from:\nAwaiting approval from:`;
 
               await github.rest.issues.createComment({
@@ -61,6 +66,7 @@ jobs:
             // ---------------------------------------------------------------------
 
             // Collect all comments on the issue (may require pagination)
+            console.log('Fetching issue comments');
             const comments = await github.paginate(github.rest.issues.listComments, {
               owner: org,
               repo,
@@ -87,10 +93,14 @@ jobs:
               }
             }
 
+            console.log(`Approvals (${approvals.size}):`, [...approvals]);
+            console.log(`Rejections (${rejections.size}):`, [...rejections]);
+
             const awaiting = teamMembers.filter(u => !approvals.has(u) && !rejections.has(u));
             const status = approvals.size >= quorum && rejections.size === 0 ? 'Approved' : 'Pending';
 
             const statusBody = `# RFC approval status: ${status}\n\nCore team approvers: ${approvals.size ? [...approvals].join(', ') : 'None'}\nRejection from: ${rejections.size ? [...rejections].join(', ') : 'None'}\nAwaiting approval from: ${awaiting.length ? awaiting.join(', ') : 'None'}`;
+            console.log('New status body to post:\n', statusBody);
 
             // Try to locate the existing status comment (starts with our header)
             let statusComment = comments.find(c => c.body.startsWith('# RFC approval status:'));