From ab5b1fe95d62f1026608d432104f05847f638a8b Mon Sep 17 00:00:00 2001 From: "James A. Fellows Yates" Date: Fri, 15 Aug 2025 10:48:11 +0200 Subject: [PATCH 1/2] Fix minimum quorum for pipeline approval --- .github/workflows/pipeline_approval.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pipeline_approval.yml b/.github/workflows/pipeline_approval.yml index f029667..a0f0980 100644 --- a/.github/workflows/pipeline_approval.yml +++ b/.github/workflows/pipeline_approval.yml @@ -63,7 +63,7 @@ jobs: const teamMembers = await getTeamMembers(); console.log('Core and Maintainers team members:', teamMembers); - const quorum = Math.ceil(teamMembers.length / 2); + const quorum = 2; console.log(`Quorum set to ${quorum}.`); // Helper for list formatting and complete status body @@ -75,7 +75,7 @@ jobs: const approvers = [...approvalsSet]; const rejecters = [...rejectionsSet]; const awaiting = awaitingArr; - let body = `## Pipeline approval status: ${status}\n\nPipeline has approvals from ${approvalsSet.size}/${quorum} required @core-team quorum.\n\n`; + let body = `## Pipeline approval status: ${status}\n\nPipeline has approvals from ${approvalsSet.size}/${quorum} required @core-team and @maintainers-team quorum.\n\n`; if (approvers.length > 0 || rejecters.length > 0 || awaiting.length > 0) { body += `|Review Status|Core and Maintainer Team members|\n|--|--|\n`; if (approvers.length > 0) { From f5410b1a09ceb87dbb117c4c4df2291310e67785 Mon Sep 17 00:00:00 2001 From: "James A. Fellows Yates" Date: Mon, 18 Aug 2025 08:49:07 +0200 Subject: [PATCH 2/2] Update .github/workflows/pipeline_approval.yml Co-authored-by: Maxime U Garcia --- .github/workflows/pipeline_approval.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pipeline_approval.yml b/.github/workflows/pipeline_approval.yml index a0f0980..ee832ec 100644 --- a/.github/workflows/pipeline_approval.yml +++ b/.github/workflows/pipeline_approval.yml @@ -75,7 +75,7 @@ jobs: const approvers = [...approvalsSet]; const rejecters = [...rejectionsSet]; const awaiting = awaitingArr; - let body = `## Pipeline approval status: ${status}\n\nPipeline has approvals from ${approvalsSet.size}/${quorum} required @core-team and @maintainers-team quorum.\n\n`; + let body = `## Pipeline approval status: ${status}\n\nPipeline has approvals from ${approvalsSet.size}/${quorum} required @nf-core/core and @nf-core/maintainers quorum.\n\n`; if (approvers.length > 0 || rejecters.length > 0 || awaiting.length > 0) { body += `|Review Status|Core and Maintainer Team members|\n|--|--|\n`; if (approvers.length > 0) {