Skip to content

Commit 0688de7

Browse files
committed
refactor: nf-core subworkflows install bam_markduplicates_picard
1 parent 295f967 commit 0688de7

File tree

7 files changed

+108
-34
lines changed

7 files changed

+108
-34
lines changed

conf/modules.config

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ if (!params.skip_alignment) {
333333

334334
if (!params.skip_markduplicates) {
335335
process {
336-
withName: '.*:MARK_DUPLICATES_PICARD:PICARD_MARKDUPLICATES' {
336+
withName: '.*:BAM_MARKDUPLICATES_PICARD:PICARD_MARKDUPLICATES' {
337337
ext.args = '--ASSUME_SORTED true --REMOVE_DUPLICATES false --VALIDATION_STRINGENCY LENIENT --TMP_DIR tmp'
338338
ext.prefix = { "${meta.id}.markdup.sorted" }
339339
publishDir = [
@@ -350,7 +350,7 @@ if (!params.skip_alignment) {
350350
]
351351
}
352352

353-
withName: '.*:MARK_DUPLICATES_PICARD:SAMTOOLS_INDEX' {
353+
withName: '.*:BAM_MARKDUPLICATES_PICARD:SAMTOOLS_INDEX' {
354354
ext.args = params.bam_csi_index ? '-c' : ''
355355
ext.prefix = { "${meta.id}.markdup.sorted" }
356356
publishDir = [
@@ -360,7 +360,7 @@ if (!params.skip_alignment) {
360360
]
361361
}
362362

363-
withName: '.*:MARK_DUPLICATES_PICARD:BAM_STATS_SAMTOOLS:.*' {
363+
withName: '.*:BAM_MARKDUPLICATES_PICARD:BAM_STATS_SAMTOOLS:.*' {
364364
ext.prefix = { "${meta.id}.markdup.sorted.bam" }
365365
publishDir = [
366366
path: { "${params.outdir}/${params.aligner}/samtools_stats" },

modules.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
},
4949
"picard/markduplicates": {
5050
"branch": "master",
51-
"git_sha": "5e34754d42cd2d5d248ca8673c0a53cdf5624905"
51+
"git_sha": "eca65aa4a5e2e192ac44d6962c8f9260f314ffb8"
5252
},
5353
"preseq/lcextrap": {
5454
"branch": "master",
@@ -174,6 +174,10 @@
174174
},
175175
"subworkflows": {
176176
"nf-core": {
177+
"bam_markduplicates_picard": {
178+
"branch": "master",
179+
"git_sha": "c9083a16a9a6c5e5beea40a88939b6e1138926f7"
180+
},
177181
"bam_sort_stats_samtools": {
178182
"branch": "master",
179183
"git_sha": "3911652a6b24249358f79e8b8466338d63efb2a2"

modules/nf-core/picard/markduplicates/main.nf

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/picard/markduplicates/meta.yml

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

subworkflows/nf-core/mark_duplicates_picard.nf renamed to subworkflows/nf-core/bam_markduplicates_picard/main.nf

Lines changed: 14 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

subworkflows/nf-core/bam_markduplicates_picard/meta.yml

Lines changed: 61 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

workflows/rnaseq.nf

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ include { CUSTOM_DUMPSOFTWAREVERSIONS } from '../modules/nf-core/custom/dumpsoft
146146
include { FASTQC_UMITOOLS_TRIMGALORE } from '../subworkflows/nf-core/fastqc_umitools_trimgalore'
147147
include { FASTQ_ALIGN_HISAT2 } from '../subworkflows/nf-core/fastq_align_hisat2/main'
148148
include { BAM_SORT_STATS_SAMTOOLS } from '../subworkflows/nf-core/bam_sort_stats_samtools/main'
149-
include { MARK_DUPLICATES_PICARD } from '../subworkflows/nf-core/mark_duplicates_picard'
149+
include { BAM_MARKDUPLICATES_PICARD } from '../subworkflows/nf-core/bam_markduplicates_picard/main'
150150
include { RSEQC } from '../subworkflows/nf-core/rseqc'
151151
include { DEDUP_UMI_UMITOOLS as DEDUP_UMI_UMITOOLS_GENOME } from '../subworkflows/nf-core/dedup_umi_umitools'
152152
include { DEDUP_UMI_UMITOOLS as DEDUP_UMI_UMITOOLS_TRANSCRIPTOME } from '../subworkflows/nf-core/dedup_umi_umitools'
@@ -565,19 +565,21 @@ workflow RNASEQ {
565565
//
566566
ch_markduplicates_multiqc = Channel.empty()
567567
if (!params.skip_alignment && !params.skip_markduplicates) {
568-
MARK_DUPLICATES_PICARD (
569-
ch_genome_bam
568+
BAM_MARKDUPLICATES_PICARD (
569+
ch_genome_bam,
570+
PREPARE_GENOME.out.fasta,
571+
PREPARE_GENOME.out.fai
570572
)
571-
ch_genome_bam = MARK_DUPLICATES_PICARD.out.bam
572-
ch_genome_bam_index = MARK_DUPLICATES_PICARD.out.bai
573-
ch_samtools_stats = MARK_DUPLICATES_PICARD.out.stats
574-
ch_samtools_flagstat = MARK_DUPLICATES_PICARD.out.flagstat
575-
ch_samtools_idxstats = MARK_DUPLICATES_PICARD.out.idxstats
576-
ch_markduplicates_multiqc = MARK_DUPLICATES_PICARD.out.metrics
573+
ch_genome_bam = BAM_MARKDUPLICATES_PICARD.out.bam
574+
ch_genome_bam_index = BAM_MARKDUPLICATES_PICARD.out.bai
575+
ch_samtools_stats = BAM_MARKDUPLICATES_PICARD.out.stats
576+
ch_samtools_flagstat = BAM_MARKDUPLICATES_PICARD.out.flagstat
577+
ch_samtools_idxstats = BAM_MARKDUPLICATES_PICARD.out.idxstats
578+
ch_markduplicates_multiqc = BAM_MARKDUPLICATES_PICARD.out.metrics
577579
if (params.bam_csi_index) {
578-
ch_genome_bam_index = MARK_DUPLICATES_PICARD.out.csi
580+
ch_genome_bam_index = BAM_MARKDUPLICATES_PICARD.out.csi
579581
}
580-
ch_versions = ch_versions.mix(MARK_DUPLICATES_PICARD.out.versions)
582+
ch_versions = ch_versions.mix(BAM_MARKDUPLICATES_PICARD.out.versions)
581583
}
582584

583585
//

0 commit comments

Comments
 (0)