Skip to content

Commit 32a6440

Browse files
committed
Merge branch 'dev' into stubs_everywhere
2 parents 586058b + c1809d1 commit 32a6440

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
Special thanks to the following for their contributions to the release:
1111

1212
- [Adam Talbot](https://github.com/adamrtalbot)
13+
- [David Carlson](https://github.com/davidecarlson)
1314
- [Edmund Miller](https://github.com/edmundmiller)
1415
- [Jonathan Manning](https://github.com/pinin4fjords)
1516
- [Laramie Lindsey](https://github.com/laramiellindsey)
@@ -106,6 +107,8 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
106107
- [PR #1341](https://github.com/nf-core/rnaseq/pull/1341) - Add rename in the MultiQC report for samples without techreps
107108
- [PR #1342](https://github.com/nf-core/rnaseq/pull/1342) - Factor out preprocessing
108109
- [PR #1345](https://github.com/nf-core/rnaseq/pull/1345) - Fix preprocessing call
110+
- [PR #1350](https://github.com/nf-core/rnaseq/pull/1350) - Reduce resource usage for sort process in bedtools/genomecov
111+
- [PR #1353](https://github.com/nf-core/rnaseq/pull/1353) - Correct conditional for salmon indexing in preprocessing workflow
109112

110113
### Parameters
111114

modules/nf-core/bedtools/genomecov/main.nf

Lines changed: 7 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

workflows/rnaseq/main.nf

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,10 @@ workflow RNASEQ {
126126
// Run RNA-seq FASTQ preprocessing subworkflow
127127
//
128128

129+
// The subworkflow only has to do Salmon indexing if it discovers 'auto'
130+
// samples, and if we haven't already made one elsewhere
131+
salmon_index_available = params.salmon_index || (!params.skip_pseudo_alignment && params.pseudo_aligner == 'salmon')
132+
129133
FASTQ_QC_TRIM_FILTER_SETSTRANDEDNESS (
130134
ch_fastq,
131135
ch_fasta,
@@ -139,7 +143,7 @@ workflow RNASEQ {
139143
params.skip_fastqc || params.skip_qc,
140144
params.skip_trimming,
141145
params.skip_umi_extract,
142-
!params.salmon_index && params.pseudo_aligner == 'salmon' && !params.skip_pseudo_alignment,
146+
!salmon_index_available,
143147
!params.sortmerna_index && params.remove_ribo_rna,
144148
params.trimmer,
145149
params.min_trimmed_reads,

0 commit comments

Comments
 (0)