Skip to content

Commit 70d2ad5

Browse files
authored
Merge pull request #806 from drpatelh/updates
Replace vanilla Linux Biocontainer in all modules with Ubuntu
2 parents ed6344a + f26520f commit 70d2ad5

File tree

8 files changed

+43
-21
lines changed

8 files changed

+43
-21
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
### Enhancements & fixes
99

10+
- [[#764](https://github.com/nf-core/rnaseq/issues/764)] - Test fails when using GCP due to missing tools in the basic biocontainer
1011
- [[#791](https://github.com/nf-core/rnaseq/issues/791)] - Add outputs for umitools dedup summary stats
1112
- Updated pipeline template to [nf-core/tools 2.3.2](https://github.com/nf-core/tools/releases/tag/2.3.2)
1213

modules.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
88
},
99
"cat/fastq": {
10-
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
10+
"git_sha": "9aadd9a6d3f5964476582319b3a1c54a3e3fe7c9"
1111
},
1212
"custom/dumpsoftwareversions": {
1313
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
@@ -22,7 +22,7 @@
2222
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
2323
},
2424
"gunzip": {
25-
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
25+
"git_sha": "9aadd9a6d3f5964476582319b3a1c54a3e3fe7c9"
2626
},
2727
"hisat2/align": {
2828
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
@@ -118,7 +118,7 @@
118118
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
119119
},
120120
"untar": {
121-
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
121+
"git_sha": "9aadd9a6d3f5964476582319b3a1c54a3e3fe7c9"
122122
}
123123
}
124124
}

modules/local/rsem_merge_counts.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ process RSEM_MERGE_COUNTS {
33

44
conda (params.enable_conda ? "conda-forge::sed=4.7" : null)
55
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
6-
'https://containers.biocontainers.pro/s3/SingImgsRepo/biocontainers/v1.2.0_cv1/biocontainers_v1.2.0_cv1.img' :
7-
'biocontainers/biocontainers:v1.2.0_cv1' }"
6+
'https://depot.galaxyproject.org/singularity/ubuntu:20.04' :
7+
'ubuntu:20.04' }"
88

99
input:
1010
path ('genes/*')

modules/nf-core/modules/cat/fastq/main.nf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/modules/gunzip/main.nf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/modules/untar/main.nf

Lines changed: 18 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/modules/untar/meta.yml

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

subworkflows/local/prepare_genome.nf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ workflow PREPARE_GENOME {
133133
if ('bbsplit' in prepare_tool_indices) {
134134
if (params.bbsplit_index) {
135135
if (params.bbsplit_index.endsWith('.tar.gz')) {
136-
ch_bbsplit_index = UNTAR_BBSPLIT_INDEX ( params.bbsplit_index ).untar
136+
ch_bbsplit_index = UNTAR_BBSPLIT_INDEX ( [ [:], params.bbsplit_index ] ).untar.map { it[1] }
137137
ch_versions = ch_versions.mix(UNTAR_BBSPLIT_INDEX.out.versions)
138138
} else {
139139
ch_bbsplit_index = file(params.bbsplit_index)
@@ -160,7 +160,7 @@ workflow PREPARE_GENOME {
160160
if ('star_salmon' in prepare_tool_indices) {
161161
if (params.star_index) {
162162
if (params.star_index.endsWith('.tar.gz')) {
163-
ch_star_index = UNTAR_STAR_INDEX ( params.star_index ).untar
163+
ch_star_index = UNTAR_STAR_INDEX ( [ [:], params.star_index ] ).untar.map { it[1] }
164164
ch_versions = ch_versions.mix(UNTAR_STAR_INDEX.out.versions)
165165
} else {
166166
ch_star_index = file(params.star_index)
@@ -178,7 +178,7 @@ workflow PREPARE_GENOME {
178178
if ('star_rsem' in prepare_tool_indices) {
179179
if (params.rsem_index) {
180180
if (params.rsem_index.endsWith('.tar.gz')) {
181-
ch_rsem_index = UNTAR_RSEM_INDEX ( params.rsem_index ).untar
181+
ch_rsem_index = UNTAR_RSEM_INDEX ( [ [:], params.rsem_index ] ).untar.map { it[1] }
182182
ch_versions = ch_versions.mix(UNTAR_RSEM_INDEX.out.versions)
183183
} else {
184184
ch_rsem_index = file(params.rsem_index)
@@ -203,7 +203,7 @@ workflow PREPARE_GENOME {
203203
}
204204
if (params.hisat2_index) {
205205
if (params.hisat2_index.endsWith('.tar.gz')) {
206-
ch_hisat2_index = UNTAR_HISAT2_INDEX ( params.hisat2_index ).untar
206+
ch_hisat2_index = UNTAR_HISAT2_INDEX ( [ [:], params.hisat2_index ] ).untar.map { it[1] }
207207
ch_versions = ch_versions.mix(UNTAR_HISAT2_INDEX.out.versions)
208208
} else {
209209
ch_hisat2_index = file(params.hisat2_index)
@@ -221,7 +221,7 @@ workflow PREPARE_GENOME {
221221
if ('salmon' in prepare_tool_indices) {
222222
if (params.salmon_index) {
223223
if (params.salmon_index.endsWith('.tar.gz')) {
224-
ch_salmon_index = UNTAR_SALMON_INDEX ( params.salmon_index ).untar
224+
ch_salmon_index = UNTAR_SALMON_INDEX ( [ [:], params.salmon_index ] ).untar.map { it[1] }
225225
ch_versions = ch_versions.mix(UNTAR_SALMON_INDEX.out.versions)
226226
} else {
227227
ch_salmon_index = file(params.salmon_index)

0 commit comments

Comments
 (0)