Skip to content

Commit 8102aa3

Browse files
committed
Fix #827
1 parent ef948d4 commit 8102aa3

File tree

8 files changed

+30
-12
lines changed

8 files changed

+30
-12
lines changed

CHANGELOG.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,16 @@ Fixed quite a well hidden bug in the UMI processing mode of the pipeline when us
1313

1414
- [[#824](https://github.com/nf-core/rnaseq/issues/824)] - Add explicit docs for usage of featureCounts in the pipeline
1515
- [[#825](https://github.com/nf-core/rnaseq/issues/825)] - Pipeline fails due to trimming related removal of all reads from a sample
16+
- [[#827](https://github.com/nf-core/rnaseq/issues/827)] - Control generation of --output-stats when running umi-tools dedup
1617
- [[#828](https://github.com/nf-core/rnaseq/issues/828)] - Filter BAM output of UMI-tools dedup before passing to Salmon quant
1718
- Updated pipeline template to [nf-core/tools 2.4.1](https://github.com/nf-core/tools/releases/tag/2.4.1)
1819

1920
### Parameters
2021

21-
| Old parameter | New parameter |
22-
| ------------- | --------------------- |
23-
| | `--min_trimmed_reads` |
22+
| Old parameter | New parameter |
23+
| ------------- | ------------------------ |
24+
| | `--min_trimmed_reads` |
25+
| | `--umitools_dedup_stats` |
2426

2527
## [[3.7](https://github.com/nf-core/rnaseq/releases/tag/3.7)] - 2022-05-03
2628

modules.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
"git_sha": "e20e57f90b6787ac9a010a980cf6ea98bd990046"
113113
},
114114
"umitools/dedup": {
115-
"git_sha": "f425aa3cea10015fe9b345b9d6dcc2336b53155f"
115+
"git_sha": "84f02a08a5d6d881cb18c31fb15faca4e735a1f2"
116116
},
117117
"umitools/extract": {
118118
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"

modules/nf-core/modules/umitools/dedup/main.nf

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/modules/umitools/dedup/meta.yml

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nextflow.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ params {
2828
with_umi = false
2929
skip_umi_extract = false
3030
umitools_extract_method = 'string'
31+
umitools_dedup_stats = false
3132
umitools_bc_pattern = null
3233
umi_discard_read = null
3334
save_umi_intermeds = false

nextflow_schema.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,12 @@
7878
"help_text": "More details can be found in the [UMI-tools documentation](https://umi-tools.readthedocs.io/en/latest/reference/extract.html#extract-method).",
7979
"description": "The UMI barcode pattern to use e.g. 'NNNNNN' indicates that the first 6 nucleotides of the read are from the UMI."
8080
},
81+
"umitools_dedup_stats": {
82+
"type": "boolean",
83+
"fa_icon": "fas fa-barcode",
84+
"help_text": "It can be quite time consuming generating these output stats - see [#827](https://github.com/nf-core/rnaseq/issues/827).",
85+
"description": "Generate output stats when running \"umi_tools dedup\"."
86+
},
8187
"umi_discard_read": {
8288
"type": "integer",
8389
"fa_icon": "fas fa-barcode",

subworkflows/nf-core/dedup_umi_umitools.nf

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

workflows/rnaseq.nf

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,8 @@ workflow RNASEQ {
346346
if (params.with_umi) {
347347
// Deduplicate genome BAM file before downstream analysis
348348
DEDUP_UMI_UMITOOLS_GENOME (
349-
ch_genome_bam.join(ch_genome_bam_index, by: [0])
349+
ch_genome_bam.join(ch_genome_bam_index, by: [0]),
350+
params.umitools_dedup_stats
350351
)
351352
ch_genome_bam = DEDUP_UMI_UMITOOLS_GENOME.out.bam
352353
ch_genome_bam_index = DEDUP_UMI_UMITOOLS_GENOME.out.bai
@@ -367,7 +368,8 @@ workflow RNASEQ {
367368

368369
// Deduplicate transcriptome BAM file before read counting with Salmon
369370
DEDUP_UMI_UMITOOLS_TRANSCRIPTOME (
370-
ch_transcriptome_sorted_bam.join(ch_transcriptome_sorted_bai, by: [0])
371+
ch_transcriptome_sorted_bam.join(ch_transcriptome_sorted_bai, by: [0]),
372+
params.umitools_dedup_stats
371373
)
372374

373375
// Name sort BAM before passing to Salmon

0 commit comments

Comments
 (0)