Skip to content

Commit 9ea05fc

Browse files
authored
Merge pull request #1144 from nf-core/interface_to_kmer
Interface to kmer size for pseudoaligners
2 parents ca7467a + 26a8b38 commit 9ea05fc

File tree

4 files changed

+26
-3
lines changed

4 files changed

+26
-3
lines changed

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,22 @@ Special thanks to the following for their contributions to the release:
1717
- [Phil Ewels](https://github.com/ewels)
1818
- [Vlad Savelyev](https://github.com/vladsavelyev)
1919

20+
### Parameters
21+
22+
| Old parameter | New parameter |
23+
| ------------- | ---------------------------- |
24+
| | `--pseudo_aligner_kmer_size` |
25+
26+
> **NB:** Parameter has been **updated** if both old and new parameter information is present.
27+
> **NB:** Parameter has been **added** if just the new parameter information is present.
28+
> **NB:** Parameter has been **removed** if new parameter information isn't present.
29+
2030
### Enhancements & fixes
2131

2232
- [PR #1135](https://github.com/nf-core/rnaseq/pull/1135) - Update [action-tower-launch](https://github.com/marketplace/actions/action-tower-launch) to v2 which supports more variable handling
33+
- [PR #1141](https://github.com/nf-core/rnaseq/pull/1141) - Important! Template update for nf-core/tools v2.11
2334
- [PR #1149](https://github.com/nf-core/rnaseq/pull/1149) - Fix and patch version commands for Fastp, FastQC and UMI-tools modules ([#1103](https://github.com/nf-core/rnaseq/issues/1103))
35+
- [PR #1144](https://github.com/nf-core/rnaseq/pull/1144) - Interface to kmer size for pseudoaligners
2436

2537
## [[3.13.2](https://github.com/nf-core/rnaseq/releases/tag/3.13.2)] - 2023-11-21
2638

conf/modules.config

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,10 @@ process {
7575
}
7676

7777
withName: 'SALMON_INDEX' {
78-
ext.args = params.gencode ? '--gencode' : ''
78+
ext.args = { [
79+
params.gencode ? '--gencode' : '',
80+
params.pseudo_aligner_kmer_size ? "-k ${params.pseudo_aligner_kmer_size}": ''
81+
].join(' ').trim() }
7982
publishDir = [
8083
path: { "${params.outdir}/genome/index" },
8184
mode: params.publish_dir_mode,
@@ -84,7 +87,7 @@ process {
8487
}
8588

8689
withName: 'KALLISTO_INDEX' {
87-
ext.args = { params.gencode ? '--gencode' : '' }
90+
ext.args = params.pseudo_aligner_kmer_size ? "-k ${params.pseudo_aligner_kmer_size}" : ''
8891
publishDir = [
8992
path: { "${params.outdir}/genome/index" },
9093
mode: params.publish_dir_mode,

nextflow.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ params {
5959
// Alignment
6060
aligner = 'star_salmon'
6161
pseudo_aligner = null
62+
pseudo_aligner_kmer_size = 31
6263
seq_center = null
6364
bam_csi_index = false
6465
star_ignore_sjdbgtf = false

nextflow_schema.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,13 @@
361361
"fa_icon": "fas fa-hamburger",
362362
"enum": ["salmon", "kallisto"]
363363
},
364+
"pseudo_aligner_kmer_size": {
365+
"type": "integer",
366+
"default": 31,
367+
"description": "Kmer length passed to indexing step of pseudoaligners",
368+
"help_text": "Failure to set a good kmer size could cause issues with quantification with Kallisto or Salmon. This is mostly an issue for short reads (<50bp), where the default kmer size of 31 is an problem.",
369+
"fa_icon": "fas fa-ruler-horizontal"
370+
},
364371
"bam_csi_index": {
365372
"type": "boolean",
366373
"description": "Create a CSI index for BAM files instead of the traditional BAI index. This will be required for genomes with larger chromosome sizes.",
@@ -397,7 +404,7 @@
397404
},
398405
"min_mapped_reads": {
399406
"type": "number",
400-
"default": 5.0,
407+
"default": 5,
401408
"fa_icon": "fas fa-percentage",
402409
"description": "Minimum percentage of uniquely mapped reads below which samples are removed from further processing.",
403410
"help_text": "Some downstream steps in the pipeline will fail if this threshold is too low."

0 commit comments

Comments
 (0)