Skip to content

Commit cd3a4f5

Browse files
authored
Merge pull request #1151 from nf-core/fix_gtf_flexibility
fix to #1150: reinstate conditional
2 parents b4c6c69 + 456b11b commit cd3a4f5

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ Special thanks to the following for their contributions to the release:
2525
- [PR #1144](https://github.com/nf-core/rnaseq/pull/1144) - Interface to kmer size for pseudoaligners
2626
- [PR #1149](https://github.com/nf-core/rnaseq/pull/1149) - Fix and patch version commands for Fastp, FastQC and UMI-tools modules ([#1103](https://github.com/nf-core/rnaseq/issues/1103))
2727
- [PR #1150](https://github.com/nf-core/rnaseq/pull/1150) - Be more flexible on attribute values in GTFs ([#1132](https://github.com/nf-core/rnaseq/issues/1132))
28+
- [PR #1151](https://github.com/nf-core/rnaseq/pull/1151) - fix to #1150: reinstate conditional
2829

2930
### Parameters
3031

bin/tx2gene.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def discover_transcript_attribute(gtf_file: str, transcripts: Set[str]) -> str:
6262
attributes_str = cols[8]
6363
attributes = dict(re.findall(r'(\S+) "(.*?)(?<!\\)";', attributes_str))
6464

65-
votes.update(key for key, value in attributes.items())
65+
votes.update(key for key, value in attributes.items() if value in transcripts)
6666

6767
if not votes:
6868
# Log a warning if no matching attribute is found

0 commit comments

Comments
 (0)