Skip to content

Commit da99418

Browse files
authored
Merge pull request #1126 from RHReynolds/fix-skip-gtf
Fix pipeline failure when transcript_fasta not provided and skip_gtf_filter is set to TRUE
2 parents 1562e01 + 5e42930 commit da99418

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

CHANGELOG.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,18 @@
33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6+
## dev
7+
8+
### Enhancements and fixes
9+
10+
- [PR #1126](https://github.com/nf-core/rnaseq/pull/1126) - Fixes error when transcript_fasta not provided and skip_gtf_filter set to true
11+
- [#1125](https://github.com/nf-core/rnaseq/issues/1125) - Pipeline fails if transcript_fasta not provided and skip_gtf_filter = true
12+
613
## [[3.13.1](https://github.com/nf-core/rnaseq/releases/tag/3.13.1)] - 2023-11-17
714

815
### Enhancements and fixes
916

10-
- [[PR #1121](https://github.com/nf-core/rnaseq/pull/1121) - Changes for 3.13.1 patch release incl. igenomes star fix
17+
- [PR #1121](https://github.com/nf-core/rnaseq/pull/1121) - Changes for 3.13.1 patch release incl. igenomes star fix
1118

1219
## [[3.13.0](https://github.com/nf-core/rnaseq/releases/tag/3.13.0)] - 2023-11-17
1320

subworkflows/local/prepare_genome/main.nf

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ workflow PREPARE_GENOME {
4747
rsem_index // directory: /path/to/rsem/index/
4848
salmon_index // directory: /path/to/salmon/index/
4949
kallisto_index // directory: /path/to/kallisto/index/
50-
hisat2_index // directory: /path/to/hisat2/index/
50+
hisat2_index // directory: /path/to/hisat2/index/
5151
bbsplit_index // directory: /path/to/rsem/index/
5252
gencode // boolean: whether the genome is from GENCODE
5353
is_aws_igenome // boolean: whether the genome files are from AWS iGenomes
@@ -139,14 +139,13 @@ workflow PREPARE_GENOME {
139139
} else {
140140
ch_transcript_fasta = Channel.value(file(transcript_fasta))
141141
}
142-
if (gencode) {
142+
if (gencode) {
143143
PREPROCESS_TRANSCRIPTS_FASTA_GENCODE ( ch_transcript_fasta )
144144
ch_transcript_fasta = PREPROCESS_TRANSCRIPTS_FASTA_GENCODE.out.fasta
145145
ch_versions = ch_versions.mix(PREPROCESS_TRANSCRIPTS_FASTA_GENCODE.out.versions)
146146
}
147147
} else {
148148
ch_transcript_fasta = MAKE_TRANSCRIPTS_FASTA ( ch_fasta, ch_gtf ).transcript_fasta
149-
ch_versions = ch_versions.mix(GTF_FILTER.out.versions)
150149
ch_versions = ch_versions.mix(MAKE_TRANSCRIPTS_FASTA.out.versions)
151150
}
152151

@@ -268,7 +267,7 @@ workflow PREPARE_GENOME {
268267
ch_versions = ch_versions.mix(SALMON_INDEX.out.versions)
269268
}
270269
}
271-
270+
272271
//
273272
// Uncompress Kallisto index or generate from scratch if required
274273
//

0 commit comments

Comments
 (0)