Skip to content

Commit de6584d

Browse files
authored
Merge pull request #1025 from drpatelh/updates
Add public_aws_ecr.config and use in CI tests
2 parents b705ef6 + 65651d6 commit de6584d

File tree

5 files changed

+63
-3
lines changed

5 files changed

+63
-3
lines changed

.github/workflows/cloud_tests_full.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
compute_env: ${{ secrets.TOWER_CE_AWS_CPU }}
3131
workdir: "${{ secrets.TOWER_BUCKET_AWS }}/work/rnaseq/work-${{ github.sha }}"
3232
run_name: "aws_rnaseq_full_${{ matrix.aligner }}"
33-
profiles: test_full_aws
33+
profiles: test_full_aws,public_aws_ecr
3434
parameters: |
3535
{
3636
"hook_url": "${{ secrets.MEGATESTS_ALERTS_SLACK_HOOK_URL }}",

.github/workflows/cloud_tests_small.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
compute_env: ${{ secrets.TOWER_CE_AWS_CPU }}
2626
workdir: "${{ secrets.TOWER_BUCKET_AWS }}/work/rnaseq/work-${{ github.sha }}"
2727
run_name: "aws_rnaseq_small"
28-
profiles: test
28+
profiles: test,public_aws_ecr
2929
parameters: |
3030
{
3131
"outdir": "${{ secrets.TOWER_BUCKET_AWS }}/rnaseq/results-test-${{ github.sha }}"

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
### Enhancements & fixes
99

1010
- [PR #1016](https://github.com/nf-core/rnaseq/pull/1016) - Updated pipeline template to [nf-core/tools 2.8](https://github.com/nf-core/tools/releases/tag/2.8)
11+
- [PR #1025](https://github.com/nf-core/fetchngs/pull/1025) - Add `public_aws_ecr.config` to source mulled containers when using `public.ecr.aws` Docker Biocontainer registry
1112

1213
### Software dependencies
1314

conf/public_aws_ecr.config

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
/*
2+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3+
AWS ECR Config
4+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5+
Config to set public AWS ECR images wherever possible
6+
This improves speed when running on AWS infrastructure.
7+
Use this as an example template when using your own private registry.
8+
----------------------------------------------------------------------------------------
9+
*/
10+
11+
docker.registry = 'public.ecr.aws'
12+
podman.registry = 'public.ecr.aws'
13+
14+
process {
15+
withName: '.*:CAT_FASTQ' {
16+
container = 'quay.io/nf-core/ubuntu:20.04'
17+
}
18+
withName: '.*:DESEQ2_QC' {
19+
container = 'quay.io/biocontainers/mulled-v2-8849acf39a43cdd6c839a369a74c0adc823e2f91:ab110436faf952a33575c64dd74615a84011450b-0'
20+
}
21+
withName: '.*:GUNZIP' {
22+
container = 'quay.io/nf-core/ubuntu:20.04'
23+
}
24+
withName: '.*:HISAT2_ALIGN' {
25+
container = 'quay.io/biocontainers/mulled-v2-a97e90b3b802d1da3d6958e0867610c718cb5eb1:2cdf6bf1e92acbeb9b2834b1c58754167173a410-0'
26+
}
27+
withName: '.*:PREPROCESS_TRANSCRIPTS_FASTA_GENCODE' {
28+
container = 'quay.io/nf-core/ubuntu:20.04'
29+
}
30+
withName: '.*:RSEM_CALCULATEEXPRESSION' {
31+
container = 'quay.io/biocontainers/mulled-v2-cf0123ef83b3c38c13e3b0696a3f285d3f20f15b:64aad4a4e144878400649e71f42105311be7ed87-0'
32+
}
33+
withName: '.*:RSEM_MERGE_COUNTS' {
34+
container = 'quay.io/nf-core/ubuntu:20.04'
35+
}
36+
withName: '.*:RSEM_PREPAREREFERENCE' {
37+
container = 'quay.io/biocontainers/mulled-v2-cf0123ef83b3c38c13e3b0696a3f285d3f20f15b:64aad4a4e144878400649e71f42105311be7ed87-0'
38+
}
39+
withName: '.*:STAR_ALIGN' {
40+
container = 'quay.io/biocontainers/mulled-v2-1fa26d1ce03c295fe2fdcf85831a92fbcbd7e8c2:1df389393721fc66f3fd8778ad938ac711951107-0'
41+
}
42+
withName: '.*:STAR_ALIGN_IGENOMES' {
43+
container = 'quay.io/biocontainers/mulled-v2-1fa26d1ce03c295fe2fdcf85831a92fbcbd7e8c2:59cdd445419f14abac76b31dd0d71217994cbcc9-0'
44+
}
45+
withName: '.*:STAR_GENOMEGENERATE' {
46+
container = 'quay.io/biocontainers/mulled-v2-1fa26d1ce03c295fe2fdcf85831a92fbcbd7e8c2:1df389393721fc66f3fd8778ad938ac711951107-0'
47+
}
48+
withName: '.*:STAR_GENOMEGENERATE_IGENOMES' {
49+
container = 'quay.io/biocontainers/mulled-v2-1fa26d1ce03c295fe2fdcf85831a92fbcbd7e8c2:59cdd445419f14abac76b31dd0d71217994cbcc9-0'
50+
}
51+
withName: '.*:UNTAR' {
52+
container = 'quay.io/nf-core/ubuntu:20.04'
53+
}
54+
}

nextflow.config

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,14 @@ profiles {
230230
executor.cpus = 16
231231
executor.memory = 60.GB
232232
}
233+
public_aws_ecr {
234+
includeConfig 'conf/public_aws_ecr.config'
235+
}
233236
test { includeConfig 'conf/test.config' }
234237
test_full { includeConfig 'conf/test_full.config' }
235-
test_full_aws { includeConfig 'conf/test_full.config' }
238+
test_full_aws {
239+
includeConfig 'conf/test_full.config'
240+
}
236241
test_full_gcp {
237242
includeConfig 'conf/test_full.config'
238243
params.input = 'https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/samplesheet/v3.10/samplesheet_full_gcp.csv'

0 commit comments

Comments
 (0)