Skip to content

Commit ee5b7f6

Browse files
authored
Merge pull request #807 from MatthiasZepper/issue797-skip_umitools_extract
Issue797 skip umitools extract
2 parents d1e5490 + b5981a3 commit ee5b7f6

File tree

7 files changed

+36
-18
lines changed

7 files changed

+36
-18
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414

1515
- [[#764](https://github.com/nf-core/rnaseq/issues/764)] - Test fails when using GCP due to missing tools in the basic biocontainer
1616
- [[#791](https://github.com/nf-core/rnaseq/issues/791)] - Add outputs for umitools dedup summary stats
17+
- [[#797](https://github.com/nf-core/rnaseq/issues/797)] - Add `--skip_umi_extract` to account for pre-existing UMIs header embeddings.
1718
- [[#798](https://github.com/nf-core/rnaseq/issues/798)] - Decompress transcript fasta error
1819
- [[#799](https://github.com/nf-core/rnaseq/issues/799)] - Issue with using `--retain_unpaired` with the `FASTQC_UMITOOLS_TRIMGALORE:TRIMGALORE` module
1920
- [[#802](https://github.com/nf-core/rnaseq/issues/802)] - `--bam_csi_index` error generated if `--skip_alignment` specified
2021
- [[#808](https://github.com/nf-core/rnaseq/issues/808)] - Auto-detect usage of Illumina iGenomes reference
2122
- [[#814](https://github.com/nf-core/rnaseq/issues/814)] - Use decimal values for `--min_mapped_reads`
2223
- Updated pipeline template to [nf-core/tools 2.3.2](https://github.com/nf-core/tools/releases/tag/2.3.2)
2324

25+
### Parameters
26+
27+
| Old parameter | New parameter |
28+
|-------------------------------|---------------------------------------|
29+
| | `--skip_umi_extract` |
30+
2431
### Software dependencies
2532

2633
Note, since the pipeline is now using Nextflow DSL2, each process will be run with its own [Biocontainer](https://biocontainers.pro/#/registry). This means that on occasion it is entirely possible for the pipeline to be using different versions of the same tool. However, the overall software dependency changes compared to the last release have been listed below for reference.

conf/modules.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ if (!params.skip_trimming) {
207207
}
208208
}
209209

210-
if (params.with_umi) {
210+
if (params.with_umi && !params.skip_umi_extract) {
211211
process {
212212
withName: '.*:FASTQC_UMITOOLS_TRIMGALORE:UMITOOLS_EXTRACT' {
213213
ext.args = [

docs/output.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ If multiple libraries/runs have been provided for the same sample in the input s
9494

9595
[UMI-tools](https://github.com/CGATOxford/UMI-tools) deduplicates reads based on unique molecular identifiers (UMIs) to address PCR-bias. Firstly, the UMI-tools `extract` command removes the UMI barcode information from the read sequence and adds it to the read name. Secondly, reads are deduplicated based on UMI identifier after mapping as highlighted in the [UMI-tools dedup](#umi-tools-dedup) section.
9696

97+
To facilitate processing of input data which has the UMI barcode already embedded in the read name from the start, `--skip_umi_extract` can be specified in conjunction with `--with_umi`.
98+
9799
### TrimGalore
98100

99101
<details markdown="1">

nextflow.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ params {
2626

2727
// UMI handling
2828
with_umi = false
29+
skip_umi_extract = false
2930
umitools_extract_method = 'string'
3031
umitools_bc_pattern = null
3132
umi_discard_read = null

nextflow_schema.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,11 @@
6565
"description": "UMI pattern to use. Can be either 'string' (default) or 'regex'.",
6666
"help_text": "More details can be found in the [UMI-tools documentation](https://umi-tools.readthedocs.io/en/latest/reference/extract.html#extract-method).\n"
6767
},
68+
"skip_umi_extract": {
69+
"type": "boolean",
70+
"fa_icon": "fas fa-compress-alt",
71+
"description": "Skip the UMI extraction from the read in case the UMIs have been moved to the headers in advance of the pipeline run."
72+
},
6873
"umitools_bc_pattern": {
6974
"type": "string",
7075
"fa_icon": "fas fa-barcode",

subworkflows/nf-core/fastqc_umitools_trimgalore.nf

Lines changed: 19 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

workflows/rnaseq.nf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ workflow RNASEQ {
224224
ch_cat_fastq,
225225
params.skip_fastqc || params.skip_qc,
226226
params.with_umi,
227+
params.skip_umi_extract,
227228
params.skip_trimming,
228229
params.umi_discard_read
229230
)

0 commit comments

Comments
 (0)