Skip RUNDIRPARSER if no rundir information is available#167
Skip RUNDIRPARSER if no rundir information is available#167maxulysse merged 6 commits intonf-core:devfrom
Conversation
|
nf-core/test-datasets#1836 Needs to be merged before I can add a nf-test. |
|
@beatrizsavinhas Since you reported the issue it would be nice to have your input as well. Is the automatic skip enough or do we need more information about the run directory? 🙂 |
|
I think this is great! 🌟
|
Sounds great, will fix! Thank you! 🙏 |
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
@maxulysse Is this Ok to merge now? I'm thinking the template update could be taken care of in another PR? |
Fixes #166. The RUNDIRPARSER module is now skipped if there is no rundir information.
With this in place, I see no need to further document the rundir. It currently says it is optional and now it can be left empty without the pipeline breaking.
We probably should add a test for this (basically have a sample sheet with no rundir information), I have not done this (yet).
PR checklist
If you've added a new tool - have you followed the pipeline conventions in the contribution docsIf necessary, also make a PR on the nf-core/seqinspector branch on the nf-core/test-datasets repository.nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).Usage Documentation indocs/usage.mdis updated.Output Documentation indocs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).