Skip to content

Commit efdced2

Browse files
authored
Merge branch 'dev' into fix-api-doc-headers
2 parents f54e123 + b14b504 commit efdced2

File tree

93 files changed

+2476
-918
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

93 files changed

+2476
-918
lines changed

.github/actions/create-lint-wf/action.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ runs:
1515
cd create-lint-wf
1616
export NXF_WORK=$(pwd)
1717
18-
# Set up Nextflow
1918
- name: Install Nextflow
2019
uses: nf-core/setup-nextflow@v2
2120
with:
@@ -65,6 +64,12 @@ runs:
6564
run: find nf-core-testpipeline -type f -exec sed -i 's/zenodo.XXXXXX/zenodo.123456/g' {} \;
6665
working-directory: create-lint-wf
6766

67+
# Add empty ro-crate file
68+
- name: add empty ro-crate file
69+
shell: bash
70+
run: touch nf-core-testpipeline/ro-crate-metadata.json
71+
working-directory: create-lint-wf
72+
6873
# Run nf-core pipelines linting
6974
- name: nf-core pipelines lint
7075
shell: bash

.github/workflows/create-lint-wf.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,12 @@ concurrency:
2727
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
2828
cancel-in-progress: true
2929

30-
env:
31-
NXF_ANSI_LOG: false
32-
3330
jobs:
3431
MakeTestWorkflow:
3532
runs-on: ${{ github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
3633
env:
3734
NXF_ANSI_LOG: false
35+
3836
strategy:
3937
matrix:
4038
NXF_VER:

.github/workflows/create-test-lint-wf-template.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ jobs:
5151
needs: prepare-matrix
5252
env:
5353
NXF_ANSI_LOG: false
54+
5455
strategy:
5556
matrix:
5657
TEMPLATE: ${{ fromJson(needs.prepare-matrix.outputs.all_features) }}
@@ -147,11 +148,22 @@ jobs:
147148
run: find my-prefix-testpipeline -type f -exec sed -i 's/zenodo.XXXXXX/zenodo.123456/g' {} \;
148149
working-directory: create-test-lint-wf
149150

151+
# Add empty ro-crate file
152+
- name: add empty ro-crate file
153+
run: touch my-prefix-testpipeline/ro-crate-metadata.json
154+
working-directory: create-test-lint-wf
155+
150156
# Run nf-core linting
151157
- name: nf-core pipelines lint
152158
run: nf-core --log-file log.txt --hide-progress pipelines lint --dir my-prefix-testpipeline --fail-warned
153159
working-directory: create-test-lint-wf
154160

161+
# Run code style linting
162+
- name: run pre-commit
163+
shell: bash
164+
run: pre-commit run --all-files
165+
working-directory: create-test-lint-wf
166+
155167
# Run bump-version
156168
- name: nf-core pipelines bump-version
157169
run: nf-core --log-file log.txt pipelines bump-version --dir my-prefix-testpipeline/ 1.1

.github/workflows/create-test-wf.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,13 @@ concurrency:
2727
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
2828
cancel-in-progress: true
2929

30-
env:
31-
NXF_ANSI_LOG: false
32-
3330
jobs:
3431
RunTestWorkflow:
3532
# use the runner given by the input if it is dispatched manually, run on github if it is a rerun or on self-hosted by default
3633
runs-on: ${{ github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
3734
env:
3835
NXF_ANSI_LOG: false
36+
3937
strategy:
4038
matrix:
4139
NXF_VER:

.github/workflows/pytest.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ jobs:
132132
133133
- name: Test with pytest
134134
run: |
135-
python3 -m pytest tests/${{matrix.test}} --color=yes --cov --durations=0 && exit_code=0|| exit_code=$?
135+
python3 -m pytest tests/${{matrix.test}} --color=yes --cov --cov-config=.coveragerc --durations=0 && exit_code=0|| exit_code=$?
136136
# don't fail if no tests were collected, e.g. for test_licence.py
137137
if [ "${exit_code}" -eq 5 ]; then
138138
echo "No tests were collected"
@@ -198,7 +198,7 @@ jobs:
198198
coverage report
199199
coverage xml
200200
201-
- uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4
201+
- uses: codecov/codecov-action@5c47607acb93fed5485fdbf7232e8a31425f672a # v5
202202
with:
203203
files: coverage.xml
204204
env:

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ ENV/
113113
# Jetbrains IDEs
114114
.idea
115115
pip-wheel-metadata
116-
.vscode
117116
.*.sw?
118117

119118
# Textual

.gitpod.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,4 @@ tasks:
99
1010
vscode:
1111
extensions:
12-
- esbenp.prettier-vscode # Markdown/CommonMark linting and style checking for Visual Studio Code
13-
- EditorConfig.EditorConfig # override user/workspace settings with settings found in .editorconfig files
14-
- Gruntfuggly.todo-tree # Display TODO and FIXME in a tree view in the activity bar
15-
- mechatroner.rainbow-csv # Highlight columns in csv files in different colors
16-
- nextflow.nextflow # Nextflow syntax highlighting
17-
- oderwat.indent-rainbow # Highlight indentation level
18-
- streetsidesoftware.code-spell-checker # Spelling checker for source code
19-
- charliermarsh.ruff # Code linter Ruff
12+
- nf-core.nf-core-extensionpack # https://github.com/nf-core/vscode-extensionpack

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
repos:
22
- repo: https://github.com/astral-sh/ruff-pre-commit
3-
rev: v0.7.1
3+
rev: v0.8.2
44
hooks:
55
- id: ruff # linter
66
args: [--fix, --exit-non-zero-on-fix] # sort imports and fix

CHANGELOG.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,33 @@
1010
- fix workflow_dispatch trigger and parse more review comments in awsfulltest ([#3235](https://github.com/nf-core/tools/pull/3235))
1111
- Add resource limits to Gitpod profile([#3255](https://github.com/nf-core/tools/pull/3255))
1212
- Fix a typo ([#3268](https://github.com/nf-core/tools/pull/3268))
13+
- Remove `def` from `nextflow.config` and add `trace_report_suffix` param ([#3296](https://github.com/nf-core/tools/pull/3296))
14+
- Move `includeConfig 'conf/modules.config'` next to `includeConfig 'conf/base.config'` to not overwrite tests profiles configurations ([#3301](https://github.com/nf-core/tools/pull/3301))
15+
- Use `params.monochrome_logs` in the template and update nf-core components ([#3310](https://github.com/nf-core/tools/pull/3310))
16+
- Fix some typos and improve writing in `usage.md` and `CONTRIBUTING.md` ([#3302](https://github.com/nf-core/tools/pull/3302))
17+
- Add `manifest.contributors` to `nextflow.config` ([#3311](https://github.com/nf-core/tools/pull/3311))
1318

1419
### Download
1520

1621
- First steps towards fixing [#3179](https://github.com/nf-core/tools/issues/3179): Modify `prioritize_direct_download()` to retain Seqera Singularity https:// Container URIs and hardcode Seqera Containers into `gather_registries()` ([#3244](https://github.com/nf-core/tools/pull/3244)).
22+
- Further steps towards fixing [#3179](https://github.com/nf-core/tools/issues/3179): Enable limited support for `oras://` container paths (_only absolute URIs, no flexible registries like with Docker_) and prevent unnecessary image downloads for Seqera Container modules with `reconcile_seqera_container_uris()` ([#3293](https://github.com/nf-core/tools/pull/3293)).
23+
- Update dawidd6/action-download-artifact action to v7 ([#3306](https://github.com/nf-core/tools/pull/3306))
1724

1825
### Linting
1926

27+
- allow mixed `str` and `dict` entries in lint config ([#3228](https://github.com/nf-core/tools/pull/3228))
28+
- fix meta_yml linting test failing due to module.process_name always being "" ([#3317](https://github.com/nf-core/tools/pull/3317))
29+
- fix module section regex matching wrong things ([#3321](https://github.com/nf-core/tools/pull/3321))
30+
2031
### Modules
2132

2233
- add a panel around diff previews when updating ([#3246](https://github.com/nf-core/tools/pull/3246))
2334

2435
### Subworkflows
2536

37+
- Add `nf-core subworkflows patch` command ([#2861](https://github.com/nf-core/tools/pull/2861))
38+
- Improve subworkflow nf-test migration warning ([#3298](https://github.com/nf-core/tools/pull/3298))
39+
2640
### General
2741

2842
- Include .nf-core.yml in `nf-core pipelines bump-version` ([#3220](https://github.com/nf-core/tools/pull/3220))
@@ -36,6 +50,20 @@
3650
- add `--dir/-d` option to schema commands ([#3247](https://github.com/nf-core/tools/pull/3247))
3751
- Update pre-commit hook astral-sh/ruff-pre-commit to v0.7.1 ([#3250](https://github.com/nf-core/tools/pull/3250))
3852
- fix headers in api docs ([#3323](https://github.com/nf-core/tools/pull/3323))
53+
- handle new schema structure in `nf-core pipelines create-params-file` ([#3276](https://github.com/nf-core/tools/pull/3276))
54+
- Update Gitpod image to use Miniforge instead of Miniconda([#3274](https://github.com/nf-core/tools/pull/3274))
55+
- Update pre-commit hook astral-sh/ruff-pre-commit to v0.7.3 ([#3275](https://github.com/nf-core/tools/pull/3275))
56+
- Add hint to solve git errors with a synced repo ([#3279](https://github.com/nf-core/tools/pull/3279))
57+
- Update pre-commit hook astral-sh/ruff-pre-commit to v0.7.4 ([#3282](https://github.com/nf-core/tools/pull/3282))
58+
- Update codecov/codecov-action action to v5 ([#3283](https://github.com/nf-core/tools/pull/3283))
59+
- Update python:3.12-slim Docker digest to 2a6386a ([#3284](https://github.com/nf-core/tools/pull/3284))
60+
- Update pre-commit hook astral-sh/ruff-pre-commit to v0.8.0 ([#3299](https://github.com/nf-core/tools/pull/3299))
61+
- Update gitpod/workspace-base Docker digest to 12853f7 ([#3309](https://github.com/nf-core/tools/pull/3309))
62+
- Run pre-commit when testing linting the template pipeline ([#3280](https://github.com/nf-core/tools/pull/3280))
63+
- Update pre-commit hook astral-sh/ruff-pre-commit to v0.8.2 ([#3325](https://github.com/nf-core/tools/pull/3325))
64+
- Make CLI prompt less nf-core specific ([#3326](https://github.com/nf-core/tools/pull/3326))
65+
- Update gitpod vscode extensions to use nf-core extension pack ([#3327](https://github.com/nf-core/tools/pull/3327))
66+
3967

4068
## [v3.0.2 - Titanium Tapir Patch](https://github.com/nf-core/tools/releases/tag/3.0.2) - [2024-10-11]
4169

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:3.12-slim@sha256:032c52613401895aa3d418a4c563d2d05f993bc3ecc065c8f4e2280978acd249
1+
FROM python:3.12-slim@sha256:2b0079146a74e23bf4ae8f6a28e1b484c6292f6fb904cbb51825b4a19812fcd8
22
33
description="Docker image containing requirements for nf-core/tools"
44

0 commit comments

Comments
 (0)