refactor: switch to using shell.cmd()

This swaps the internal implementation to use the new shell.cmd() API.
This avoids the need for wrapping with double quotes which should also
mean better compatibility on Windows.

Author: nfischer

index.js

@@ -9,11 +9,20 @@ const proxyifyCmd = (t, ...cmdStart) => {
     newArgs.push(cmdStart[0]);
 
     // Wrap all subsequent arguments in quotes
-    newArgs = newArgs.concat(cmdStart.slice(1)
-      .concat(args)
-      .map((x) => JSON.stringify(x)));
-    // Run this command in the shell
-    return origShell.exec.call(this.stdout, newArgs.join(' '));
+    newArgs = newArgs
+      .concat(cmdStart.slice(1))
+      .concat(args);
+    // Run this command in the shell with globbing temporarily disabled.
+    // 'noglob' is part of ShellJS internals, but hopefully this will stay
+    // around. We cannot achieve the same with `set('-f')` because we need to
+    // know the previous state in order to reset globbing back the way it was.
+    const oldGlob = origShell.config.noglob;
+    try {
+      origShell.config.noglob = true;
+      return origShell.cmd.call(this.stdout, newArgs);
+    } finally {
+      origShell.config.noglob = oldGlob;
+    }
   };
   // Store the list of commands, in case we have a subcommand chain
   t[cmdArrayAttr] = cmdStart;

test/test.js

@@ -289,6 +289,26 @@ describe('proxy', function describeproxy() {
       done();
     });
 
+    it('other shelljs commands can still glob', (done) => {
+      const fa = 'a.txt';
+      const fglob = '*.txt';
+      shell.exec('echo hello world').to(fa);
+      shell.exec('echo hello world').to(fglob);
+
+      if (unix()) {
+        shell.__native.rm(fglob);
+      } else {
+        shell.del(fglob);
+      }
+      fs.existsSync(fglob).should.equal(false);
+      fs.existsSync(fa).should.equal(true);
+
+      shell.rm('*.txt');
+      fs.existsSync(fglob).should.equal(false);
+      fs.existsSync(fa).should.equal(false);
+      done();
+    });
+
     it('escapes quotes', (done) => {
       if (!unix()) {
         // Windows doesn't support `"` as a character in a filename, see