Skip to content

Commit 41d14cd

Browse files
authored
(refactor) move prettier to devDependencies and update prettier (#67)
1 parent 5582ea6 commit 41d14cd

File tree

3 files changed

+23
-20
lines changed

3 files changed

+23
-20
lines changed

examples/apps/log.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,11 @@ GPT.on(Events.SLOT_RENDER_ENDED, event => {
1212

1313
if (!event.isEmpty && event.size) {
1414
console.log(
15-
`ad creative '${event.creativeId}' is rendered to slot '${divId}' of size '${event
16-
.size[0]}x${event.size[1]}'`,
15+
`ad creative '${
16+
event.creativeId
17+
}' is rendered to slot '${divId}' of size '${event.size[0]}x${
18+
event.size[1]
19+
}'`,
1720
event,
1821
targeting
1922
);

package.json

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,20 @@
2525
"bugs": {
2626
"url": "https://github.com/nfl/react-gpt/issues"
2727
},
28-
"files": ["*.md", "docs", "es", "src", "dist", "lib"],
28+
"files": [
29+
"*.md",
30+
"docs",
31+
"es",
32+
"src",
33+
"dist",
34+
"lib"
35+
],
2936
"dependencies": {
3037
"deep-equal": "^1.0.1",
3138
"eventemitter3": "^2.0.2",
3239
"exenv": "^1.2.2",
3340
"hoist-non-react-statics": "^1.0.5",
3441
"invariant": "^2.2.2",
35-
"prettier": "^1.7.0",
3642
"throttle-debounce": "^1.0.1"
3743
},
3844
"devDependencies": {
@@ -75,6 +81,7 @@
7581
"karma-webpack": "^1.7.0",
7682
"mocha": "^3.1.2",
7783
"phantom": "^2.0.4",
84+
"prettier": "^1.9.2",
7885
"prop-types": "^15.5.10",
7986
"querystring": "^0.2.0",
8087
"radium": "^0.18.1",
@@ -100,21 +107,16 @@
100107
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
101108
"build": "npm run clean && npm run compile",
102109
"build:es": "BABEL_ENV=es babel --copy-files ./src -d es",
103-
"build:umd":
104-
"NODE_ENV=development webpack src/index.js dist/react-gpt.js",
105-
"build:umd:min":
106-
"NODE_ENV=production webpack -p src/index.js dist/react-gpt.min.js",
110+
"build:umd": "NODE_ENV=development webpack src/index.js dist/react-gpt.js",
111+
"build:umd:min": "NODE_ENV=production webpack -p src/index.js dist/react-gpt.min.js",
107112
"bundlesize": "npm run build:umd:min && bundlesize",
108113
"clean": "rimraf lib coverage dist lib es",
109114
"compile": "babel src --out-dir lib",
110-
"examples":
111-
"webpack-dev-server --config examples/webpack.config.js --content-base examples/apps --inline",
115+
"examples": "webpack-dev-server --config examples/webpack.config.js --content-base examples/apps --inline",
112116
"lint": "eslint --fix src test examples",
113-
"start":
114-
"npm run build && env BABEL_ENV=examples node examples/server/index.js",
117+
"start": "npm run build && env BABEL_ENV=examples node examples/server/index.js",
115118
"pretest": "npm run build",
116-
"prepublish":
117-
"npm run build && npm run build:es && npm run build:umd && npm run build:umd:min",
119+
"prepublish": "npm run build && npm run build:es && npm run build:umd && npm run build:umd:min",
118120
"test": "npm run lint && karma start",
119121
"update-apilist": "node ./scripts/updateAPIList.js"
120122
},

src/createManager.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,10 @@ export class AdManager extends EventEmitter {
190190
].forEach(eventType => {
191191
["pubads", "content", "companionAds"].forEach(service => {
192192
// there is no API to remove listeners.
193-
this.googletag
194-
[service]()
195-
.addEventListener(
196-
eventType,
197-
this._onEvent.bind(this, eventType)
198-
);
193+
this.googletag[service]().addEventListener(
194+
eventType,
195+
this._onEvent.bind(this, eventType)
196+
);
199197
});
200198
});
201199
this._listening = true;

0 commit comments

Comments
 (0)