S7 theme element rewrite (#73)

* S7 theme element rewrite

* news bullet and version bump

* checks and pkgdown need ggplot2 dev version

* adjust tests and expectations for ggplot2 v4

* ggpath dev version as well

* update release bullets with new approach from nflfastR

* update get started article

Author: mrcaseb

.github/workflows/test-coverage.yaml

@@ -26,7 +26,7 @@ jobs:
       - uses: r-lib/actions/setup-r-dependencies@v2
         with:
           extra-packages: any::covr, any::xml2
-          needs: coverage
+          needs: check
 
       - name: Test coverage
         run: |

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: nflplotR
 Title: NFL Logo Plots in 'ggplot2' and 'gt'
-Version: 1.4.0.9003
+Version: 1.4.0.9004
 Authors@R: 
     person("Sebastian", "Carl", , "[email protected]", role = c("aut", "cre"))
 Description: A set of functions to visualize National Football League
@@ -14,16 +14,17 @@ Imports:
     cachem (>= 1.0.0),
     cli (>= 3.0.0),
     data.table (>= 1.14.0),
-    ggpath (>= 1.0.1),
-    ggplot2 (>= 3.3.0),
+    ggpath (>= 1.0.2.9000),
+    ggplot2 (>= 3.5.2),
     grid,
     gt (>= 0.8.0),
     lifecycle,
     magick (>= 2.7.3),
     memoise (>= 2.0.0),
     nflreadr (>= 1.3.2),
     rlang (>= 0.4.11),
-    scales (>= 1.1.0)
+    scales (>= 1.1.0),
+    S7 (>= 0.2.0)
 Suggests: 
     base64enc (>= 0.1-3),
     covr,
@@ -35,6 +36,12 @@ Suggests:
     vdiffr (>= 1.0.2),
     webshot2 (>= 0.1.1)
 Config/testthat/edition: 3
+Config/Needs/check: 
+  tidyverse/ggplot2,
+  mrcaseb/ggpath
+Config/Needs/website: 
+  tidyverse/ggplot2,
+  mrcaseb/ggpath
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.3.2

NAMESPACE

@@ -1,10 +1,5 @@
 # Generated by roxygen2: do not edit by hand
 
-S3method(element_grob,element_nfl_headshot)
-S3method(element_grob,element_nfl_logo)
-S3method(element_grob,element_nfl_wordmark)
-S3method(grobHeight,axisImageGrob)
-S3method(grobWidth,axisImageGrob)
 export(.nflplotR_clear_cache)
 export(GeomNFLheads)
 export(GeomNFLlogo)
@@ -34,7 +29,9 @@ export(scale_fill_nfl)
 export(valid_team_names)
 import(data.table)
 import(grid)
-importFrom(ggplot2,element_grob)
+importFrom(ggpath,element_path)
+importFrom(ggplot2,draw_element)
+importFrom(ggplot2,element)
 importFrom(graphics,par)
 importFrom(lifecycle,deprecated)
 importFrom(nflreadr,nflverse_sitrep)

NEWS.md

@@ -5,6 +5,7 @@
 * All geoms and theme elements will print more informative warnings about team abbreviation, or player ID mismatches.
 * The gt logo rendering functions now add alt text for accessibility and to silence an annoying pkgdown warning. (#69)
 * nflplotR now requires R 4.1 because magick needs this R version. This also follows the [Tidyverse R version support rules](https://www.tidyverse.org/blog/2019/04/r-version-support/). (#71)
+* Rewrite theme elements in S7 to fully work with ggplot2 v4. This means nflplotR now requires ggplot2 v4! nflplotR is a ggplot2 extension and if ggplot2 version jumps make breaking changes, then it's best for the extension to not try to be downwards compatible. The theme system is now fully powered by ggpath. (#73)
 
 # nflplotR 1.4.0
 

R/nflplotR-package.R

@@ -6,7 +6,7 @@
 ## usethis namespace: start
 #' @import data.table
 #' @import grid
-#' @importFrom ggplot2 element_grob
+#' @importFrom ggplot2 draw_element element
 #' @importFrom graphics par
 #' @importFrom lifecycle deprecated
 #' @importFrom rlang .data %||%