fix(jjb): escape Groovy DSL braces to avoid JJB parsing errors

Escaped all { and } in the embedded Groovy pipeline DSL using double braces ({{, }}) to prevent Jenkins Job Builder (JJB) from misinterpreting them as Python format placeholders.
This resolves the unexpected '{' in field name error when running jenkins-jobs test or update.

Also moved the groovy script to the script folder for better readability

Signed-off-by: Manimaran M <manim@redhat.com>

Author: Manimaran-MM

jobs/scripts/trigger-fsal-on-new-patch.groovy

@@ -0,0 +1,61 @@
+pipeline {{
+    agent {{ label 'cico-workspace' }}
+
+    stages {{
+        stage('Trigger FSAL Jobs in Parallel') {{
+            steps {{
+                script {{
+                    def gerritParams = [
+                        'GERRIT_PATCHSET_REVISION', 'GERRIT_REFSPEC', 'GERRIT_PROJECT', 'GERRIT_HOST'
+                    ]
+
+                    def sharedParams = gerritParams.collect {{ paramName ->
+                        string(name: paramName, value: env.getProperty(paramName) ?: '')
+                    }}
+
+                    def jobList = ['fsal-cephfs', 'fsal-vfs', 'fsal-gpfs', 'fsal-rgw']
+                    def results = [:]
+                    def messages = ["**FSAL Job Results:**\\n"]
+
+                    parallel jobList.collectEntries {{ job ->
+                        [(job): {{
+                            def build = build job: job, parameters: sharedParams, propagate: false, wait: true
+                            results[job] = build
+
+                            def msg = ''
+                            try {{
+                                def jobUrl = build.absoluteUrl
+                                def artifactUrl = "${{jobUrl}}artifact/result_message.txt"
+                                sh "curl -s -o tmp_result_message_${{job}}.txt '${{artifactUrl}}'"
+                                msg = readFile("tmp_result_message_${{job}}.txt").trim()
+                            }} catch (Exception e) {{
+                                msg = "**🔴 ${{job}}: ERROR fetching result_message.txt**"
+                            }}
+
+                            messages << msg
+                        }}]
+                    }}
+
+                    def finalMessage = messages.join("\\n")
+                    writeFile file: 'gerrit_message.txt', text: finalMessage
+
+                    def notifyFlag = '--notify NONE'
+                    if (finalMessage.contains('FAILED')) {{
+                        notifyFlag = '--notify ALL'
+                    }}
+
+                    withCredentials([file(credentialsId: 'GERRITHUB_PRIVATE_KEY', variable: 'GERRITHUB_KEY_FILE')]) {{
+                        sh """
+                            ssh -i $GERRITHUB_KEY_FILE -l jenkins-glusterorg -o StrictHostKeyChecking=no -p 29418 $GERRIT_HOST \\
+                                gerrit review \\
+                                $notifyFlag \\
+                                --message "'$(cat gerrit_message.txt)'" \\
+                                --project $GERRIT_PROJECT \\
+                                $GERRIT_PATCHSET_REVISION
+                        """
+                    }}
+                }}
+            }}
+        }}
+    }}
+}}

jobs/trigger-fsal-on-new-patch.yml

@@ -38,65 +38,4 @@
               branches:
                 - branch-pattern: "**"
                   branch-compare-type: ANT
-    dsl: |
-      pipeline {
-        agent { label 'cico-workspace' }
-
-        stages {
-          stage('Trigger FSAL Jobs in Parallel') {
-            steps {
-              script {
-                def gerritParams = [
-                  'GERRIT_PATCHSET_REVISION', 'GERRIT_REFSPEC', 'GERRIT_PROJECT','GERRIT_HOST'
-                ]
-
-                def sharedParams = gerritParams.collect { paramName ->
-                  string(name: paramName, value: env.getProperty(paramName) ?: '')
-                }
-
-                def jobList = ['fsal-cephfs', 'fsal-vfs', 'fsal-gpfs', 'fsal-rgw']
-                def results = [:]
-                def messages = ["**FSAL Job Results:**\\n"]
-
-                parallel jobList.collectEntries { job ->
-                  [(job): {
-                    def build = build job: job, parameters: sharedParams, propagate: false, wait: true
-                    results[job] = build
-
-                    def msg = ''
-                    try {
-                      def jobUrl = build.absoluteUrl
-                      def artifactUrl = "\${jobUrl}artifact/result_message.txt"
-                      sh "curl -s -o tmp_result_message_\${job}.txt '\${artifactUrl}'"
-                      msg = readFile("tmp_result_message_\${job}.txt").trim()
-                    } catch (Exception e) {
-                      msg = "**🔴 \${job}: ERROR fetching result_message.txt**"
-                    }
-
-                    messages << msg
-                  }]
-                }
-
-                def finalMessage = messages.join("\\n")
-                writeFile file: 'gerrit_message.txt', text: finalMessage
-
-                def notifyFlag = '--notify NONE' // default
-                if (finalMessage.contains('FAILED')) {
-                  notifyFlag = '--notify ALL'
-                }
-                
-                withCredentials([file(credentialsId: 'GERRITHUB_PRIVATE_KEY', variable: 'GERRITHUB_KEY_FILE')]) {
-                  sh """
-                    ssh -i \$GERRITHUB_KEY_FILE -l jenkins-glusterorg -o StrictHostKeyChecking=no -p 29418 \$GERRIT_HOST \\
-                      gerrit review \\
-                      $notifyFlag \\
-                      --message "'$(cat gerrit_message.txt)'" \\
-                      --project $GERRIT_PROJECT \\
-                      $GERRIT_PATCHSET_REVISION
-                  '''
-                }
-              }
-            }
-          }
-        }
-      }
+    dsl: !include-raw: scripts/trigger-fsal-on-new-patch.groovy