forcedCombinations ignoring incompatible (NOT SOLVED)

[cryptotester]

UPDATE

Update 2:

It seems that forcedCombinations makes a dna containing incomatible items possible.

Update 1:
I don't know what I was doing, for testint I changed Zombie#7.png to Zombie#700.png, to get more occurrences of it... can that be the cause for messing results up?

---

Hi,

I configured a few forced combinations based on the background trait, which is the first layer in the hierarchy.

Note, I want the Background to be a trait, that's why I separated the backgrounds from the body. I'd like that the "Zombie_Green" background forces a "Zombie" over it. But I want to allow Zomby to have a different background than the Zombie_Green.

Maybe I'm missing a trick, using nested folders (but need some guidance because I tried and didn't really made sense of thme, in my setup). Would be really cool to have some help.

Here my layers configuration:

const layerConfigurations = [
  {
    growEditionSizeTo: 100,
    namePrefix: "My collection",
    layersOrder: [
      { name: "Background",
        options: {
          bypassDNA: true,
        },
      },
      { name: "Body" },
      { name: "Head" },
      { name: "Eyes" },
      { name: "Mouth" },
    ],
  },
];

Here my forcedCombinations:

const forcedCombinations = {
  Blue: ["Cop"],
  Zombie_Green: ["Zombie"],
};

I configured also a bunch of incompatible combinations for the Zombie e.g.:

const incompatible = {
  Cop: ["Zombified", "Zombie_Eyes"],
  Zombie: ["Blue_Eyes", "Smile", "Sunglasses", "Baseball Cap", "Cigarette", "... many more ..."],
};

The problem I have, is that in the generated collection I'm getting zombies, which still have the traits I specifically marked as incompatible.

I checked the code in main.js and I found which part of the code seems responsible for this:

  // Does this layer include a forcedDNA item? ya? just return it.
  const forcedPick = layer.elements.find((element) =>
    forcedDNA.includes(element.name)
  );
  if (forcedPick) {
    debugLogs
      ? console.log(chalk.yellowBright(`Force picking ${forcedPick.name}/n`))
      : null;
    if (forcedPick.sublayer) {
      return dnaSequence.concat(
        pickRandomElement(
          forcedPick,
          dnaSequence,
          `${parentId}.${forcedPick.id}`,
          incompatibleDNA,
          forcedDNA,
          bypassDNA,
          zIndex
        )
      );
    }
    let dnaString = `${parentId}.${forcedPick.id}:${forcedPick.zindex}${forcedPick.filename}${bypassDNA}`;
    return dnaSequence.push(dnaString);
  }

I debugged this and the dnaString returned indeed contains those traits that I marked incompatible with the Zombie type.

I commented this line:

    // let dnaString = `${parentId}.${forcedPick.id}:${forcedPick.zindex}${forcedPick.filename}${bypassDNA}`;

I did re-run the build, this time I don't get anymore the incompatible combinations, however, the rarity of the zombie decreased drastically. Before I was getting more or less 7% as I configured it with weight #7 (out of a total of 100).

Now I get only 2%.

Can you suggest a fix for my issue? Thank you.

[cryptotester]

@nftchef I think that forcedCombinations needs an update, it needs an extra check to see if the forced combination still has some incompatible traits. How would you advise to add that? THX

[cryptotester]

To make it work, I had to avoid using forced combinations.
I ended up using incompatible, instead. Rather than forcing some combinations I marked all incompatible ones... not ideal though.