NH-3807 - .netstandard 2.0 project

Compiling

Author: ngbrown

src/NHibernate.DomainModel/NHibernate.DomainModel.csproj

@@ -2,7 +2,8 @@
   <Import Project="../../build-common/NHibernate.props" />
   <PropertyGroup>
     <Description>The Domain Model used by the Unit Tests.</Description>
-    <TargetFramework>net461</TargetFramework>
+    <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
+    <DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>
     <IsTestProject>true</IsTestProject>
     <NoWarn>$(NoWarn);3001;3002;3003;3005</NoWarn>
   </PropertyGroup>

src/NHibernate.Driver.Firebird/NHibernate.Driver.Firebird.csproj

@@ -5,7 +5,8 @@
     <Description>Driver for Firebird to be used with NHibernate 5.</Description>
     <PackageTags>NHibernate; Driver; firebird; firebirsql; firebirdclient; ADO.Net; Core</PackageTags>
 
-    <TargetFramework>net461</TargetFramework>
+    <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
+    <DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>
     <NoWarn>$(NoWarn);3001;3002;3003;3005;1591</NoWarn>
     <SignAssembly>True</SignAssembly>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>

src/NHibernate.Driver.MySql/NHibernate.Driver.MySql.csproj

@@ -5,7 +5,8 @@
     <Description>Driver for MySql and MariaDB to be used with NHibernate 5.</Description>
     <PackageTags>NHibernate; Driver; MySql; MySql.Data; Connector/NET; C/Net; ADO.Net; Core</PackageTags>
 
-    <TargetFramework>net461</TargetFramework>
+    <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
+    <DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>
     <NoWarn>$(NoWarn);3001;3002;3003;3005;1591</NoWarn>
     <SignAssembly>True</SignAssembly>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>

src/NHibernate.Driver.PostgreSql/NHibernate.Driver.PostgreSql.csproj

@@ -5,7 +5,8 @@
     <Description>Driver for PostgreSQL to be used with NHibernate 5.</Description>
     <PackageTags>NHibernate; Driver; Npgsql; PostgreSQL; Postgres; ADO.Net; Core</PackageTags>
 
-    <TargetFramework>net461</TargetFramework>
+    <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
+    <DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>
     <NoWarn>$(NoWarn);3001;3002;3003;3005;1591</NoWarn>
     <SignAssembly>True</SignAssembly>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>

src/NHibernate.Driver.SqlServer/NHibernate.Driver.SqlServer.csproj

@@ -5,7 +5,8 @@
     <Description>Driver for Microsoft SQL Server to be used with NHibernate 5.</Description>
     <PackageTags>NHibernate; Driver; SqlClient; SqlServer; SQL Server; ADO.Net; Core</PackageTags>
 
-    <TargetFramework>net461</TargetFramework>
+    <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
+    <DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>
     <NoWarn>$(NoWarn);3001;3002;3003;3005;1591</NoWarn>
     <SignAssembly>True</SignAssembly>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>

src/NHibernate.Example.Web/NHibernate.Example.Web.csproj

@@ -1,7 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFramework>net461</TargetFramework>
+    <TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
+    <DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>
   </PropertyGroup>
 
   <ItemGroup>

src/NHibernate.Test.VisualBasic/NHibernate.Test.VisualBasic.vbproj

@@ -2,12 +2,15 @@
   <Import Project="../../build-common/NHibernate.props" />
   <PropertyGroup>
     <Description>The Visual Basic Unit Tests for NHibernate.</Description>
-    <TargetFramework>net461</TargetFramework>
+    <TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
     <IsTestProject>true</IsTestProject>
     <NoWarn>$(NoWarn);3001;3002;3003;3005</NoWarn>
     <OptionExplicit>On</OptionExplicit>
     <OptionStrict>On</OptionStrict>
   </PropertyGroup>
+  <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.0'">
+    <Compile Remove="Issues\NH3302\**" />  <!--"Like" not supported in netcoreapp2.0.-->
+  </ItemGroup>
   <ItemGroup>
     <None Remove="**\*.hbm.xml" />
   </ItemGroup>

src/NHibernate.Test/Ado/BatcherFixture.cs

@@ -90,8 +90,12 @@ public void OneRoundTripUpdate()
 		[Description("SqlClient: The batcher should run all different INSERT queries in only one roundtrip.")]
 		public void SqlClientOneRoundTripForUpdateAndInsert()
 		{
+#if !NETCOREAPP2_0
 			if (Sfi.Settings.BatcherFactory is SqlClientBatchingBatcherFactory == false)
+#endif
+			{
 				Assert.Ignore("This test is for SqlClientBatchingBatcher only");
+			}
 
 			FillDb();
 
@@ -128,8 +132,12 @@ public void SqlClientOneRoundTripForUpdateAndInsert()
 		[Description("SqlClient: The batcher log output should be formatted")]
 		public void BatchedoutputShouldBeFormatted()
 		{
+#if !NETCOREAPP2_0
 			if (Sfi.Settings.BatcherFactory is SqlClientBatchingBatcherFactory == false)
+#endif
+			{
 				Assert.Ignore("This test is for SqlClientBatchingBatcher only");
+			}
 
 			using (var sqlLog = new SqlLogSpy())
 			{

src/NHibernate.Test/Async/Ado/BatcherFixture.cs

@@ -102,8 +102,12 @@ public async Task OneRoundTripUpdateAsync()
 		[Description("SqlClient: The batcher should run all different INSERT queries in only one roundtrip.")]
 		public async Task SqlClientOneRoundTripForUpdateAndInsertAsync()
 		{
+#if !NETCOREAPP2_0
 			if (Sfi.Settings.BatcherFactory is SqlClientBatchingBatcherFactory == false)
+#endif
+			{
 				Assert.Ignore("This test is for SqlClientBatchingBatcher only");
+			}
 
 			await (FillDbAsync());
 
@@ -140,8 +144,12 @@ public async Task SqlClientOneRoundTripForUpdateAndInsertAsync()
 		[Description("SqlClient: The batcher log output should be formatted")]
 		public async Task BatchedoutputShouldBeFormattedAsync()
 		{
+#if !NETCOREAPP2_0
 			if (Sfi.Settings.BatcherFactory is SqlClientBatchingBatcherFactory == false)
+#endif
+			{
 				Assert.Ignore("This test is for SqlClientBatchingBatcher only");
+			}
 
 			using (var sqlLog = new SqlLogSpy())
 			{

src/NHibernate.Test/Async/Component/Basic/ComponentWithUniqueConstraintTests.cs

@@ -10,7 +10,6 @@
 
 using System;
 using System.Data.Common;
-using System.Data.Odbc;
 using System.Data.SqlClient;
 using System.Linq;
 using NHibernate.Cfg.MappingSchema;