add support for SSL CA cert verification (#3)

Author: dpassante

plugins/doc_fragments/cloudstack.py

@@ -51,9 +51,16 @@ class ModuleDocFragment(object):
       - If not given, the C(CLOUDSTACK_REGION) env variable is considered.
     type: str
     default: cloudstack
+  api_verify_ssl_cert:
+    description:
+      - CA authority cert file.
+      - If not given, the C(CLOUDSTACK_VERIFY) env variable is considered.
+      - As the last option, the value is taken from the ini config file, also see the notes.
+      - Fallback value is C(null) if not specified.
+    type: str
 requirements:
   - python >= 2.6
-  - cs >= 0.6.10
+  - cs >= 0.9.0
 notes:
   - Ansible uses the C(cs) library's configuration method if credentials are not
     provided by the arguments C(api_url), C(api_key), C(api_secret).

plugins/module_utils/cloudstack.py

@@ -35,6 +35,7 @@ def cs_argument_spec():
         api_http_method=dict(choices=['get', 'post'], default=os.environ.get('CLOUDSTACK_METHOD')),
         api_timeout=dict(type='int', default=os.environ.get('CLOUDSTACK_TIMEOUT')),
         api_region=dict(default=os.environ.get('CLOUDSTACK_REGION') or 'cloudstack'),
+        api_verify_ssl_cert=dict(default=os.environ.get('CLOUDSTACK_VERIFY')),
     )
 
 
@@ -125,13 +126,15 @@ def get_api_config(self):
             'secret': self.module.params.get('api_secret') or config.get('secret'),
             'timeout': self.module.params.get('api_timeout') or config.get('timeout') or 10,
             'method': self.module.params.get('api_http_method') or config.get('method') or 'get',
+            'verify': self.module.params.get('api_verify_ssl_cert') or config.get('verify'),
         }
         self.result.update({
             'api_region': api_region,
             'api_url': api_config['endpoint'],
             'api_key': api_config['key'],
             'api_timeout': int(api_config['timeout']),
             'api_http_method': api_config['method'],
+            'api_verify_ssl_cert': api_config['verify'],
         })
         if not all([api_config['endpoint'], api_config['key'], api_config['secret']]):
             self.fail_json(msg="Missing api credentials: can not authenticate")

requirements.txt

@@ -1 +1 @@
-cs>=0.6.1
+cs>=0.9.0