Deprecate first zone as default zone

Test container 1.4.0

Author: resmo

.github/workflows/integration.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   integration-test:
-    name: Integration test group${{matrix.group}} Py${{ matrix.python-version }}
+    name: Integration v${{ matrix.container-version }} Ansible-${{ matrix.ansible-branch }} group${{ matrix.group }} Py${{ matrix.python-version }}
     defaults:
       run:
         working-directory: ansible_collections/ngine_io/cloudstack
@@ -24,6 +24,11 @@ jobs:
         group:
         - 1
         - 2
+        ansible-branch:
+        - devel
+        container-version:
+        - 1.4.0
+        - 1.2.0
     steps:
     - name: Check out code
       uses: actions/checkout@v2
@@ -38,7 +43,7 @@ jobs:
     - name: Install ansible and collection dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install ansible
+        pip install https://github.com/ansible/ansible/archive/${{ matrix.ansible-branch }}.tar.gz
         pip install -r requirements.txt
 
     - name: Build and install collection
@@ -59,6 +64,8 @@ jobs:
         --continue-on-error
         --coverage
         shippable/cs/group${{ matrix.group }}/
+      env:
+        ANSIBLE_CLOUDSTACK_CONTAINER: quay.io/ansible/cloudstack-test-container:${{ matrix.container-version }}
 
     - name: Generate coverage report.
       run: >-

plugins/module_utils/cloudstack.py

@@ -478,6 +478,11 @@ def get_zone(self, key=None):
 
         # use the first zone if no zone param given
         if not zone:
+            self.module.deprecate(
+                msg="Using first zone as default is deprecated because of unreliable API, zone needs to be defined.",
+                version="2.0.0",
+                collection_name="ngine_io.cloudstack"
+            )
             self.zone = zones['zone'][0]
             self.result['zone'] = self.zone['name']
             return self._get_by_key(key, self.zone)

plugins/modules/cs_template.py

@@ -691,7 +691,7 @@ def main():
         ),
         hypervisor=dict(),
         requires_hvm=dict(type='bool'),
-        password_enabled=dict(type='bool'),
+        password_enabled=dict(type='bool', no_log=False),
         template_tag=dict(),
         sshkey_enabled=dict(type='bool'),
         format=dict(choices=['QCOW2', 'RAW', 'VHD', 'OVA']),

tests/integration/targets/cs_cluster/tasks/main.yml

@@ -2,6 +2,7 @@
 - name: setup cluster is absent
   cs_cluster:
     name: "{{ cs_resource_prefix }}-cluster"
+    zone: "{{ cs_resource_prefix }}-zone"
     state: absent
   register: cluster
 - name: verify setup cluster is absent
@@ -36,6 +37,7 @@
 
 - name: test fail if missing name
   cs_cluster:
+    zone: "{{ cs_resource_prefix }}-zone"
   register: cluster
   ignore_errors: true
 - name: verify results of fail if missing name
@@ -170,6 +172,7 @@
 - name: test disable cluster in check mode
   cs_cluster:
     name: "{{ cs_resource_prefix }}-cluster"
+    zone: "{{ cs_resource_prefix }}-zone"
     state: disabled
   register: cluster
   check_mode: true
@@ -187,6 +190,7 @@
 - name: test disable cluster
   cs_cluster:
     name: "{{ cs_resource_prefix }}-cluster"
+    zone: "{{ cs_resource_prefix }}-zone"
     state: disabled
   register: cluster
 - name: verify test disable cluster
@@ -203,6 +207,7 @@
 - name: test disable cluster idempotence
   cs_cluster:
     name: "{{ cs_resource_prefix }}-cluster"
+    zone: "{{ cs_resource_prefix }}-zone"
     state: disabled
   register: cluster
 - name: verify test disable cluster idempotence
@@ -218,6 +223,7 @@
 - name: test enable cluster in check mode
   cs_cluster:
     name: "{{ cs_resource_prefix }}-cluster"
+    zone: "{{ cs_resource_prefix }}-zone"
     state: enabled
   register: cluster
   check_mode: true
@@ -235,6 +241,7 @@
 - name: test enable cluster
   cs_cluster:
     name: "{{ cs_resource_prefix }}-cluster"
+    zone: "{{ cs_resource_prefix }}-zone"
     state: enabled
   register: cluster
 - name: verify test enable cluster
@@ -251,6 +258,7 @@
 - name: test enable cluster idempotence
   cs_cluster:
     name: "{{ cs_resource_prefix }}-cluster"
+    zone: "{{ cs_resource_prefix }}-zone"
     state: enabled
   register: cluster
 - name: verify test enable cluster idempotence

tests/integration/targets/cs_host/tasks/main.yml

@@ -1,6 +1,7 @@
 ---
 - name: test fail missing params
   cs_host:
+    zone: "{{ cs_common_zone_basic }}"
   register: host
   ignore_errors: true
 - name: verify test fail missing url if host is not existent
@@ -12,6 +13,7 @@
 - name: test fail missing params if host is not existent
   cs_host:
     name: sim
+    zone: "{{ cs_common_zone_basic }}"
   register: host
   ignore_errors: true
 - name: verify test fail missing params if host is not existent
@@ -23,6 +25,7 @@
 - name: test create a host in check mode
   cs_host:
     name: sim
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -43,6 +46,7 @@
 - name: test create a host
   cs_host:
     name: sim
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -77,6 +81,7 @@
 - name: test create a host idempotence
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -104,6 +109,7 @@
 - name: test update host in check mode
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -133,6 +139,7 @@
 - name: test update host
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -161,6 +168,7 @@
 - name: test update host idempotence
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -190,6 +198,7 @@
 - name: test update host remove host_tags
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -218,6 +227,7 @@
 - name: test update host remove host_tags idempotence
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     url: "http://sim/c0-basic/h2"
     cluster: C0-basic
     pod: POD0-basic
@@ -246,6 +256,7 @@
 - name: test put host in maintenance in check mode
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     allocation_state: maintenance
@@ -267,6 +278,7 @@
 - name: test put host in maintenance
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     allocation_state: maintenance
@@ -287,6 +299,7 @@
 - name: test put host in maintenance idempotence
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     allocation_state: maintenance
@@ -307,6 +320,7 @@
 - name: test put host out of maintenance in check mode
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     allocation_state: enabled
@@ -328,6 +342,7 @@
 - name: test put host out of maintenance
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     allocation_state: enabled
@@ -348,6 +363,7 @@
 - name: test put host out of maintenance idempotence
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     allocation_state: enabled
@@ -368,6 +384,7 @@
 - name: test remove host in check mode
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     state: absent
@@ -389,6 +406,7 @@
 - name: test remove host
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     state: absent
@@ -409,6 +427,7 @@
 - name: test remove host idempotence
   cs_host:
     name: "{{ host_hostname }}"
+    zone: "{{ cs_common_zone_basic }}"
     cluster: C0-basic
     pod: POD0-basic
     state: absent

tests/integration/targets/cs_instance/tasks/absent.yml

@@ -2,6 +2,7 @@
 - name: test destroy instance in check mode
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: absent
   register: instance
   check_mode: true
@@ -15,6 +16,7 @@
 - name: test destroy instance
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: absent
   register: instance
 - name: verify destroy instance
@@ -27,6 +29,7 @@
 - name: test destroy instance idempotence
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: absent
   register: instance
 - name: verify destroy instance idempotence
@@ -38,6 +41,7 @@
 - name: test recover to stopped state and update a deleted instance in check mode
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     service_offering: "{{ test_cs_instance_offering_1 }}"
     state: stopped
   register: instance
@@ -51,6 +55,7 @@
 - name: test recover to stopped state and update a deleted instance
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     service_offering: "{{ test_cs_instance_offering_1 }}"
     state: stopped
   register: instance
@@ -65,6 +70,7 @@
 - name: test recover to stopped state and update a deleted instance idempotence
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     service_offering: "{{ test_cs_instance_offering_1 }}"
     state: stopped
   register: instance
@@ -79,6 +85,7 @@
 - name: test expunge instance in check mode
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: expunged
   register: instance
   check_mode: true
@@ -93,6 +100,7 @@
 - name: test expunge instance
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: expunged
   register: instance
 - name: verify test expunge instance
@@ -106,6 +114,7 @@
 - name: test expunge instance idempotence
   cs_instance:
     name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: expunged
   register: instance
 - name: verify test expunge instance idempotence

tests/integration/targets/cs_instance/tasks/absent_display_name.yml

@@ -2,6 +2,7 @@
 - name: test destroy instance with display_name
   cs_instance:
     display_name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: absent
   register: instance
 - name: verify destroy instance with display_name
@@ -14,6 +15,7 @@
 - name: test destroy instance with display_name idempotence
   cs_instance:
     display_name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: absent
   register: instance
 - name: verify destroy instance with display_name idempotence
@@ -25,6 +27,7 @@
 - name: test recover to stopped state and update a deleted instance with display_name
   cs_instance:
     display_name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     service_offering: "{{ test_cs_instance_offering_1 }}"
     state: stopped
   register: instance
@@ -39,5 +42,6 @@
 # force expunge, only works with admin permissions
 - cs_instance:
     display_name: "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
+    zone: "{{ cs_common_zone_basic }}"
     state: expunged
   failed_when: false