ignore policy scaling factor of value 0

Author: resmo

scalr/policy/__init__.py

@@ -7,23 +7,23 @@
 class PolicyAdapter(ABC):
     def configure(self, config: PolicyConfig) -> None:
         self.name = config.name
-        self.target = config.target
-        self.query = config.query
-        self.config = config.config
+        self.target = config.target or 1
+        self.query = config.query or ""
+        self.config = config.config or dict()
 
     def get_scaling_factor(self) -> float:
         try:
             current = self.get_current()
         except Exception as ex:
             log.error(ex)
-            return 1
+            return 0
 
         log.info("Current metric: %s", current)
         log.info("Target: %s", self.target)
         try:
             return self.target / current
         except ZeroDivisionError:
-            return 1
+            return 0
 
     @abstractclassmethod
     def get_current(self) -> float:

scalr/scalr.py

@@ -66,11 +66,17 @@ def get_factor(self, policy_configs: List[PolicyConfig]) -> float:
             policy.configure(config=policy_config)
             policy_factor: float = policy.get_scaling_factor()
             log.debug(f"Policy scaling factor: {policy_factor}")
+
+            if policy_factor == 0:
+                log.debug(f"Ignoring factor 0, keep current scaling factor: {scaling_factor}")
+                continue
+
             if policy_factor > scaling_factor:
                 scaling_factor = policy_factor
                 log.debug(f"Set scaling factor: {scaling_factor}")
-            else:
-                log.debug(f"Keep scaling factor: {scaling_factor}")
+                continue
+
+            log.debug(f"Keep current scaling factor: {scaling_factor}")
         return scaling_factor
 
     def scale(self, diff: int, cloud: CloudAdapter) -> None: