Skip to content

Commit 32cff72

Browse files
authored
Fix threshold values and typo in ci.yml (#1208)
* add write permissions for updating badge and pushing test results * set benchmark alert back to 175% * set both thresholds to 150% * fix typo * fix perf test
1 parent 75ec1a9 commit 32cff72

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ jobs:
270270
contents: write
271271
runs-on: ubuntu-22.04
272272
needs: build-unsigned-snapshot
273+
273274
steps:
274275
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
275276
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
@@ -329,11 +330,7 @@ jobs:
329330
benchmark-data-dir-path: ""
330331
# Set auto-push to false since GitHub API token is not given
331332
auto-push: false
332-
<<<<<<< Updated upstream
333-
alert-threshold: '175%'
334-
=======
335333
alert-threshold: '150%'
336-
>>>>>>> Stashed changes
337334
gh-pages-branch: "benchmark-results"
338335
fail-on-alert: true
339336

0 commit comments

Comments
 (0)