Skip to content

Ensure in progress requests are processed before resetting the gRPC connection with the management plane #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure in progress requests are processed before resetting the gRPC connection with the management plane #1391

wants to merge 1 commit into from

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Nov 17, 2025

Proposed changes

Ensure in progress requests are processed before resetting the gRPC connection with the management plane.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Nov 17, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 56.25000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.20%. Comparing base (b1947ec) to head (cd41a35).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
internal/command/command_service.go 50.00% 16 Missing and 2 partials ⚠️
internal/command/command_plugin.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   86.31%   86.20%   -0.11%     
==========================================
  Files         102      102              
  Lines       12603    12633      +30     
==========================================
+ Hits        10878    10890      +12     
- Misses       1249     1265      +16     
- Partials      476      478       +2
Files with missing lines Coverage Δ
internal/config/config.go 87.37% <100.00%> (+0.07%) ⬆️
internal/config/defaults.go 100.00% <ø> (ø)
internal/config/flags.go 100.00% <ø> (ø)
internal/config/types.go 87.65% <ø> (ø)
internal/command/command_plugin.go 75.74% <50.00%> (ø)
internal/command/command_service.go 76.47% <50.00%> (-3.91%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1947ec...cd41a35. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhurley dhurley marked this pull request as ready for review November 19, 2025 15:51
@dhurley dhurley requested a review from a team as a code owner November 19, 2025 15:51
sean-breen
sean-breen reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@sean-breen sean-breen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests around the case where len(cs.requestsInProgress) > 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-breen sean-breen sean-breen left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@dhurley dhurley

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhurley @sean-breen