Skip to content

Commit 6a12005

Browse files
authored
Update docs to fix master references (#25)
1 parent 81e8566 commit 6a12005

File tree

17 files changed

+274
-219
lines changed

17 files changed

+274
-219
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Steps to reproduce the behavior:
2020
A clear and concise description of what you expected to happen.
2121

2222
**Your environment:**
23-
- Version of the NGINX Config Role or specific commit
23+
- Version of the NGINX Config role or specific commit
2424
- Version of Ansible
2525
- Target deployment platform
2626

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Describe the use case and detail of the change. If this PR addresses an issue on
44
### Checklist
55
Before creating a PR, run through this checklist and mark each as complete.
66

7-
- [ ] I have read the [CONTRIBUTING](https://github.com/nginxinc/ansible-role-nginx-config/blob/master/CONTRIBUTING.md) document
7+
- [ ] I have read the [CONTRIBUTING](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/CONTRIBUTING.md) document
88
- [ ] I have added Molecule tests that prove my fix is effective or that my feature works
99
- [ ] I have checked that all Molecule tests pass after adding my changes
1010
- [ ] I have updated any relevant documentation (`defaults/main/*.yml`, `README.md` and `CHANGELOG.md`)

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
- name: "(Debian/Ubuntu) Cleanup config and try to install modules"
77
env:
88
scenario: cleanup_module
9-
- name: "(Alpine) Cleanup config and try to install modules"
9+
- name: "(Alpine Linux) Cleanup config and try to install modules"
1010
env:
1111
scenario: cleanup_module_alpine
1212
- name: "(CentOS) Cleanup config and try to install modules"
@@ -15,7 +15,7 @@ jobs:
1515
- name: "(Debian/Ubuntu) Test config templates"
1616
env:
1717
scenario: default
18-
- name: "(Alpine) Test config templates"
18+
- name: "(Alpine Linux) Test config templates"
1919
env:
2020
scenario: default_alpine
2121
- name: "(CentOS) Test config templates"
@@ -24,7 +24,7 @@ jobs:
2424
- name: "(Debian/Ubuntu) Install stable branch and push a config"
2525
env:
2626
scenario: stable_push
27-
- name: "(Alpine) Install stable branch and push a config"
27+
- name: "(Alpine Linux) Install stable branch and push a config"
2828
env:
2929
scenario: stable_push_alpine
3030
- name: "(CentOS) Install stable branch and push a config"

CHANGELOG.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Changelog
22

3-
## 0.2.0 (Unreleased)
3+
## 0.2.0 (September 13, 2020)
44

55
BREAKING CHANGES:
66

@@ -12,8 +12,11 @@ Make sure you only use one variable or the other, since they will overwrite each
1212

1313
FEATURES:
1414

15-
* Add Alpine 3.12 to the list of supported platforms
16-
* Remove Alpine 3.8 from the list of supported platforms
15+
* A new variable has been introduced:
16+
* `nginx_debug_tasks` -- Print task related information to give you a better insight into the current progress of the role.
17+
* Improved tasks naming conventions.
18+
* Add Alpine `3.12` to the list of supported platforms.
19+
* Remove Alpine `3.8` from the list of supported platforms .
1720

1821
ENHANCEMENTS:
1922

CONTRIBUTING.md

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,26 @@ The following is a set of guidelines for contributing to the NGINX Ansible role.
1414
* [Git Guidelines](#git-guidelines)
1515
* [Ansible Guidelines](#ansible-guidelines)
1616

17-
[Code of Conduct](https://github.com/nginxinc/ansible-role-nginx-config/blob/master/CODE_OF_CONDUCT.md)
17+
[Code of Conduct](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/CODE_OF_CONDUCT.md)
1818

1919
## Ask a Question
2020

21-
Don't know how something works? Curious if the role can achieve your desired functionality. Please open an Issue on GitHub with the label `question`.
21+
Don't know how something works? Curious if the role can achieve your desired functionality? Please open an Issue on GitHub with the label `question`.
2222

2323
## Getting Started
2424

25-
Follow our [Installation Guide](https://github.com/nginxinc/ansible-role-nginx-config/blob/master/README.md#Installation) to install Ansible and Molecule and get ready to use the NGINX Ansible role.
25+
Follow our [Installation Guide](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/README.md#Installation) to install Ansible and Molecule and get ready to use the NGINX Ansible role.
2626

2727
### Project Structure
2828

2929
* The NGINX Ansible role is written in `yaml` and supports NGINX Open Source and NGINX Plus.
30-
* The project follows the standard [Ansible role directory structure](https://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse_roles.html)
31-
* The main code is found in `tasks/`
32-
* The main variables can be found in `defaults/main/*.yml`
33-
* Configuration templates for NGINX can be found in `templates/`
30+
* The project follows the standard [Ansible role directory structure](https://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse_roles.html):
31+
* The main code is found in `tasks/`.
32+
* The main variables can be found in `defaults/main/*.yml`.
33+
* "Constant" variables can be found in `vars/main.yml`.
34+
* Configuration templates for NGINX can be found in `templates/`.
3435
* [Molecule](https://molecule.readthedocs.io/) tests can be found in `molecule/`.
35-
* CI/CD is done via Travis using `.travis.yml` deployment yaml files
36+
* CI/CD is done via Travis using `.travis.yml` deployment `yaml` files.
3637

3738
## Contributing
3839

@@ -46,8 +47,8 @@ To suggest an enhancement, please create an issue on GitHub with the label `enha
4647

4748
### Open a Pull Request
4849

49-
* Fork the repo, create a branch, submit a PR when your changes are **tested** (ideally using Molecule) and ready for review
50-
* Fill in [our pull request template](https://github.com/nginxinc/ansible-role-nginx-config/blob/master/.github/PULL_REQUEST_TEMPLATE.md)
50+
* Fork the repo, create a branch, submit a PR when your changes are **tested** (ideally using Molecule) and ready for review.
51+
* Fill in [our pull request template](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/.github/PULL_REQUEST_TEMPLATE.md).
5152

5253
Note: if you’d like to implement a new feature, please consider creating a feature request issue first to start a discussion about the feature.
5354

@@ -63,10 +64,10 @@ Note: if you’d like to implement a new feature, please consider creating a fea
6364

6465
### Git Guidelines
6566

66-
* Keep a clean, concise and meaningful git commit history on your branch (within reason), rebasing locally and squashing before submitting a PR
67-
* Follow the guidelines of writing a good commit message as described here <https://chris.beams.io/posts/git-commit/> and summarised in the next few points
68-
* In the subject line, use the present tense ("Add feature" not "Added feature")
69-
* In the subject line, use the imperative mood ("Move cursor to..." not "Moves cursor to...")
70-
* Limit the subject line to 72 characters or less
71-
* Reference issues and pull requests liberally after the subject line
72-
* Add more detailed description in the body of the git message (`git commit -a` to give you more space and time in your text editor to write a good message instead of `git commit -am`)
67+
* Keep a clean, concise and meaningful git commit history on your branch (within reason), rebasing locally and squashing before submitting a PR.
68+
* Follow the guidelines of writing a good commit message as described here <https://chris.beams.io/posts/git-commit/> and summarised in the next few points:
69+
* In the subject line, use the present tense ("Add feature" not "Added feature").
70+
* In the subject line, use the imperative mood ("Move cursor to..." not "Moves cursor to...").
71+
* Limit the subject line to 72 characters or less.
72+
* Reference issues and pull requests liberally after the subject line.
73+
* Add more detailed description in the body of the git message (`git commit -a` to give you more space and time in your text editor to write a good message instead of `git commit -am`).

README.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,11 @@ Alpine:
4444
- 3.12
4545
CentOS:
4646
- 6
47-
- 7
47+
- 7.4+
4848
- 8
4949
Debian:
5050
- stretch
5151
- buster
52-
FreeBSD:
53-
- 11.2+
54-
- 12
5552
RedHat:
5653
- 6
5754
- 7.4+
@@ -62,6 +59,7 @@ SUSE/SLES:
6259
Ubuntu:
6360
- xenial
6461
- bionic
62+
- eoan
6563
- focal
6664
```
6765
@@ -100,13 +98,14 @@ SUSE/SLES:
10098
Ubuntu:
10199
- xenial
102100
- bionic
101+
- eoan
103102
- focal
104103
```
105104
106105
Role Variables
107106
--------------
108107
109-
This role has multiple variables. The descriptions and defaults for all these variables can be found in the **`defaults/main`** directory in the following files:
108+
This role has multiple variables. The descriptions and defaults for all these variables can be found in the **`defaults/main/`** directory in the following files:
110109

111110
- **[defaults/main/main.yml](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/defaults/main/main.yml):** NGINX simple config variables
112111
- **[defaults/main/template.yml](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/defaults/main/template.yml):** NGINX config template variables
@@ -115,7 +114,7 @@ This role has multiple variables. The descriptions and defaults for all these va
115114
Example Playbooks
116115
-----------------
117116

118-
Working functional playbook examples can be found in the **`molecule/common`** directory in the following files:
117+
Working functional playbook examples can be found in the **`molecule/common/`** directory in the following files:
119118

120119
- **[molecule/common/playbooks/cleanup_module_converge.yml](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/molecule/common/playbooks/cleanup_module_converge.yml):** Cleanup an NGINX config and configure NGINX supported modules
121120
- **[molecule/common/playbooks/default_converge.yml](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/molecule/common/playbooks/default_converge.yml):** Use the NGINX config templating variables to create an NGINX config
@@ -126,10 +125,14 @@ Do note that if you install this repository via Ansible Galaxy, you will have to
126125
Other NGINX Roles
127126
-----------------
128127

129-
You can find an Ansible collection of roles to help you install and configure NGINX Controller [here](https://github.com/nginxinc/ansible-collection-nginx_controller)
128+
You can find an Ansible role to install NGINX [here](https://github.com/nginxinc/ansible-role-nginx)
130129

131130
You can find an Ansible role to help you install and configure NGINX App Protect [here](https://github.com/nginxinc/ansible-role-nginx-app-protect)
132131

132+
You can find an Ansible collection of roles to help you install and configure NGINX Controller [here](https://github.com/nginxinc/ansible-collection-nginx_controller)
133+
134+
You can find an Ansible role to install NGINX Unit [here](https://github.com/nginxinc/ansible-role-nginx-unit)
135+
133136
License
134137
-------
135138

defaults/main/main.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ nginx_config_start: true
55

66
# Print NGINX configuration file to terminal after executing playbook.
77
nginx_config_debug_output: false
8+
# Print NGINX configuration file to terminal after executing playbook.
9+
nginx_config_debug_tasks: false
810

911
# Remove previously existing NGINX configuration files (files ending in *.conf).
1012
# You can specify a list of paths you wish to remove.

handlers/main.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
---
2-
- name: "(Handler: All OSs) Run NGINX"
2+
- name: "(Handler) Run NGINX"
33
block:
4-
- name: "(Handler: All OSs) Start NGINX"
4+
- name: "(Handler) Start NGINX"
55
service:
66
name: nginx
77
state: started
88
enabled: yes
9-
notify: "(Handler: All OSs) Check NGINX"
9+
notify: "(Handler) Check NGINX"
1010

11-
- name: "(Handler: All OSs) Check NGINX"
11+
- name: "(Handler) Check NGINX"
1212
command: "nginx -t"
13-
notify: "(Handler: All OSs) Start NGINX"
13+
notify: "(Handler) Start NGINX"
1414
changed_when: false
1515

16-
- name: "(Handler: All OSs) Reload NGINX"
16+
- name: "(Handler) Reload NGINX"
1717
command: "nginx -s reload"
1818
changed_when: false
1919
when:

molecule/common/Dockerfile.j2

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,27 +17,27 @@ ENV {{ var }} {{ value }}
1717
RUN \
1818
if [ $(command -v apt-get) ]; then \
1919
apt-get update \
20-
&& DEBIAN_FRONTEND=noninteractive apt-get install -y python3 sudo bash ca-certificates iproute2 python3-apt aptitude systemd systemd-sysv procps curl \
20+
&& DEBIAN_FRONTEND=noninteractive apt-get install -y aptitude bash ca-certificates curl iproute2 python-apt python3 python3-apt procps sudo systemd systemd-sysv \
2121
&& apt-get clean; \
2222
elif [ $(command -v dnf) ]; then \
2323
dnf makecache \
24-
&& dnf --assumeyes install /usr/bin/python3 /usr/bin/python3-config /usr/bin/dnf-3 bash iproute \
24+
&& dnf --assumeyes install bash iproute /usr/bin/dnf-3 /usr/bin/python3 /usr/bin/python3-config \
2525
&& dnf clean all; \
2626
elif [ $(command -v yum) ]; then \
2727
yum makecache fast \
28-
&& yum install -y /usr/bin/python /usr/bin/python2-config sudo yum-plugin-ovl bash iproute \
28+
&& yum install -y bash iproute /usr/bin/python /usr/bin/python2-config sudo yum-plugin-ovl \
2929
&& sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf \
3030
&& yum clean all; \
3131
elif [ $(command -v zypper) ]; then \
3232
zypper refresh \
33-
&& zypper install -y python3 sudo bash iproute2 \
33+
&& zypper install -y bash iproute2 python3 sudo \
3434
&& zypper clean -a; \
3535
elif [ $(command -v apk) ]; then \
3636
apk update \
37-
&& apk add --no-cache python3 sudo bash ca-certificates curl openrc; \
37+
&& apk add --no-cache bash ca-certificates curl openrc python3 sudo; \
3838
echo 'rc_provide="loopback net"' >> /etc/rc.conf; \
3939
elif [ $(command -v xbps-install) ]; then \
4040
xbps-install -Syu \
41-
&& xbps-install -y python3 sudo bash ca-certificates iproute2 \
41+
&& xbps-install -y bash ca-certificates iproute2 python3 sudo \
4242
&& xbps-remove -O; \
4343
fi

tasks/conf/debug-output.yml

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)