Skip to content

Commit 70f23ba

Browse files
authored
chore: Remove CentOS 7 artifacts/tests/metadata (#445)
1 parent dcff52f commit 70f23ba

File tree

11 files changed

+113
-109
lines changed

11 files changed

+113
-109
lines changed

CHANGELOG.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,15 @@ BUG FIXES:
66

77
- Fix incompatibility when using the `listen` directive and setting both the `quic` and `so_keepalive` parameters.
88

9-
CI/CD:
9+
TESTS:
1010

11-
- Add Molecule tests covering common NGINX use cases (web server, reverse proxy), enabling the NGINX stub status metrics, and NGINX Plus API and live metrics dashboard.
1211
- Update the platforms used in the various Molecule scenarios.
1312
- Use the local role name (`ansible-role-nginx-config`) instead of the fully qualified role name (`nginxinc.nginx_config`) in Molecule to ensure tests always work as intended in environments where the role has been already installed beforehand.
13+
- Add Molecule tests covering common NGINX use cases (web server, reverse proxy), enabling the NGINX stub status metrics, and NGINX Plus API and live metrics dashboard.
14+
15+
MAINTENANCE:
16+
17+
- Remove CentOS 7 related artifacts, tests, and metadata since RHEL 7 related distributions are no longer tested nor supported.
1418

1519
## 0.7.1 (October 3rd, 2023)
1620

defaults/main/selinux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
# Set SELinux enforcing for NGINX (Centos/Redhat only) - you may need to open ports on your own
2+
# Set SELinux enforcing for NGINX (Redhat only) - you may need to open ports on your own
33
nginx_config_selinux: false
44

55
# Enable enforcing mode if true. Permissive if false (audit only, no enforcing) globally (only works with nginx_config_selinux: true)

meta/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ galaxy_info:
1717
- name: Debian
1818
versions: [bullseye, bookworm]
1919
- name: EL
20-
versions: ['7', '8', '9']
20+
versions: ['8', '9']
2121
- name: FreeBSD
2222
versions: ['12.1', '12.2', '12.3', '12.4', '13.0', '13.1', '13.2']
2323
- name: OracleLinux
2424
versions: ['7', '8', '9']
2525
- name: Ubuntu
26-
versions: [focal, jammy, kinetic, lunar]
26+
versions: [focal, jammy, lunar]
2727
- name: SLES
2828
versions: ['12', '15']
2929

molecule/common/Dockerfile.j2

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ RUN \
2525
&& dnf clean all; \
2626
elif [ $(command -v yum) ]; then \
2727
yum makecache fast \
28-
&& yum install -y bash iproute initscripts sudo /usr/bin/python /usr/bin/python2-config vim yum-plugin-ovl \
29-
&& yum install -y http://mirror.centos.org/centos/7/os/x86_64/Packages/yum-plugin-copr-1.1.31-54.el7_8.noarch.rpm http://mirror.centos.org/centos/7/os/x86_64/Packages/libseccomp-2.3.1-4.el7.x86_64.rpm \
28+
&& yum install -y bash iproute initscripts sudo /usr/bin/python /usr/bin/python2-config vim yum-plugin-copr yum-plugin-ovl \
3029
&& yum copr enable -y jsynacek/systemd-backports-for-centos-7 \
3130
&& yum update --disableplugin=priorities -y systemd \
3231
&& sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf \
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
roles:
33
- name: nginxinc.nginx
4-
version: 0.24.0
4+
version: 0.24.3
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
---
22
roles:
33
- name: nginxinc.nginx
4-
version: 0.24.0
4+
version: 0.24.3
55
- name: nginxinc.nginx_app_protect
6-
version: 0.9.0
6+
src: https://github.com/nginxinc/ansible-role-nginx-app-protect
7+
version: main

molecule/complete_plus/converge.yml

Lines changed: 62 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
deployment_location: /etc/nginx/nginx.conf
2323
config:
2424
main:
25-
load_module:
26-
- modules/ngx_http_app_protect_module.so
27-
- modules/ngx_http_app_protect_dos_module.so
25+
# load_module:
26+
# - modules/ngx_http_app_protect_module.so
27+
# - modules/ngx_http_app_protect_dos_module.so
2828
user: nginx
2929
worker_processes: auto
3030
error_log:
@@ -151,27 +151,27 @@
151151
core:
152152
default_type: application/octet-stream
153153
keepalive_timeout: 65s
154-
app_protect_waf:
155-
physical_memory_util_thresholds:
156-
high: 100
157-
low: 100
158-
cpu_thresholds:
159-
high: 100
160-
low: 100
161-
failure_mode_action: pass
162-
cookie_seed: testseed
163-
compressed_requests_action: drop
164-
app_protect_dos:
165-
liveliness:
166-
enable: true
167-
uri: /app_protect_dos_liveliness
168-
port: 8090
169-
readiness:
170-
enable: true
171-
uri: /app_protect_dos_readiness
172-
port: 8090
173-
arb_fqdn: 192.168.1.10
174-
accelerated_mitigation: false
154+
# app_protect_waf:
155+
# physical_memory_util_thresholds:
156+
# high: 100
157+
# low: 100
158+
# cpu_thresholds:
159+
# high: 100
160+
# low: 100
161+
# failure_mode_action: pass
162+
# cookie_seed: testseed
163+
# compressed_requests_action: drop
164+
# app_protect_dos:
165+
# liveliness:
166+
# enable: true
167+
# uri: /app_protect_dos_liveliness
168+
# port: 8090
169+
# readiness:
170+
# enable: true
171+
# uri: /app_protect_dos_readiness
172+
# port: 8090
173+
# arb_fqdn: 192.168.1.10
174+
# accelerated_mitigation: false
175175
grpc:
176176
bind:
177177
address: $remote_addr
@@ -351,26 +351,26 @@
351351
default_server: true
352352
server_name: localhost
353353
client_max_body_size: 512k
354-
app_protect_waf:
355-
enable: true
356-
policy_file: /etc/app_protect/conf/NginxDefaultPolicy.json
357-
security_log_enable: true
358-
security_log:
359-
- path: /etc/app_protect/conf/log_default.json
360-
dest: syslog:server=10.1.1.1:514
361-
- path: /etc/app_protect/conf/log_default.json
362-
dest: syslog:server=10.1.1.2:514
363-
app_protect_dos:
364-
enable: true
365-
policy_file: /etc/app_protect/conf/BADOSDefaultPolicy.json
366-
security_log_enable: true
367-
security_log:
368-
path: /etc/app_protect_dos/log-default.json
369-
dest: syslog:server=10.1.1.1:514
370-
monitor:
371-
uri: http://10.1.1.1:5000/monitor
372-
protocol: http2
373-
timeout: 10
354+
# app_protect_waf:
355+
# enable: true
356+
# policy_file: /etc/app_protect/conf/NginxDefaultPolicy.json
357+
# security_log_enable: true
358+
# security_log:
359+
# - path: /etc/app_protect/conf/log_default.json
360+
# dest: syslog:server=10.1.1.1:514
361+
# - path: /etc/app_protect/conf/log_default.json
362+
# dest: syslog:server=10.1.1.2:514
363+
# app_protect_dos:
364+
# enable: true
365+
# policy_file: /etc/app_protect/conf/BADOSDefaultPolicy.json
366+
# security_log_enable: true
367+
# security_log:
368+
# path: /etc/app_protect_dos/log-default.json
369+
# dest: syslog:server=10.1.1.1:514
370+
# monitor:
371+
# uri: http://10.1.1.1:5000/monitor
372+
# protocol: http2
373+
# timeout: 10
374374
auth_jwt:
375375
enable:
376376
realm: realm
@@ -390,24 +390,24 @@
390390
format: main
391391
locations:
392392
- location: /
393-
app_protect_waf:
394-
enable: true
395-
policy_file: /etc/app_protect/conf/NginxDefaultPolicy.json
396-
security_log_enable: true
397-
security_log:
398-
- path: /etc/app_protect/conf/log_default.json
399-
dest: syslog:server=10.1.1.1:514
400-
- path: /etc/app_protect/conf/log_default.json
401-
dest: syslog:server=10.1.1.2:514
402-
app_protect_dos:
403-
enable: true
404-
policy_file: /etc/app_protect/conf/BADOSDefaultPolicy.json
405-
security_log_enable: true
406-
security_log:
407-
path: /etc/app_protect_dos/log-default.json
408-
dest: syslog:server=10.1.1.1:514
409-
monitor: http://10.1.1.1:5000/monitor
410-
api: true
393+
# app_protect_waf:
394+
# enable: true
395+
# policy_file: /etc/app_protect/conf/NginxDefaultPolicy.json
396+
# security_log_enable: true
397+
# security_log:
398+
# - path: /etc/app_protect/conf/log_default.json
399+
# dest: syslog:server=10.1.1.1:514
400+
# - path: /etc/app_protect/conf/log_default.json
401+
# dest: syslog:server=10.1.1.2:514
402+
# app_protect_dos:
403+
# enable: true
404+
# policy_file: /etc/app_protect/conf/BADOSDefaultPolicy.json
405+
# security_log_enable: true
406+
# security_log:
407+
# path: /etc/app_protect_dos/log-default.json
408+
# dest: syslog:server=10.1.1.1:514
409+
# monitor: http://10.1.1.1:5000/monitor
410+
# api: true
411411
auth_jwt:
412412
enable: false
413413
leeway: 0s

molecule/complete_plus/molecule.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ lint: |
99
set -e
1010
ansible-lint --force-color
1111
platforms:
12-
- name: centos-7
13-
image: centos:7
14-
platform: amd64
12+
- name: rhel-8
13+
image: redhat/ubi9:9.4
14+
platform: x86_64
1515
dockerfile: ../common/Dockerfile.j2
1616
privileged: true
1717
cgroupns_mode: host
1818
volumes:
1919
- /sys/fs/cgroup:/sys/fs/cgroup:rw
2020
command: /usr/sbin/init
21-
- name: ubuntu-bionic
22-
image: ubuntu:bionic
23-
platform: amd64
21+
- name: ubuntu-jammy
22+
image: ubuntu:jammy
23+
platform: x86_64
2424
dockerfile: ../common/Dockerfile.j2
2525
privileged: true
2626
cgroupns_mode: host

molecule/complete_plus/prepare.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
key: ../common/files/license/nginx-repo.key
3131
nginx_remove_license: false
3232

33-
- name: Install NGINX App Protect WAF
34-
ansible.builtin.include_role:
35-
name: nginxinc.nginx_app_protect
36-
vars:
37-
nginx_app_protect_waf_enable: true
38-
nginx_app_protect_dos_enable: true
39-
nginx_app_protect_setup_license: false
40-
nginx_app_protect_remove_license: false
41-
nginx_app_protect_install_signatures: false
42-
nginx_app_protect_install_threat_campaigns: false
33+
# - name: Install NGINX App Protect WAF
34+
# ansible.builtin.include_role:
35+
# name: nginxinc.nginx_app_protect
36+
# vars:
37+
# nginx_app_protect_waf_enable: true
38+
# nginx_app_protect_dos_enable: true
39+
# nginx_app_protect_setup_license: false
40+
# nginx_app_protect_remove_license: false
41+
# nginx_app_protect_install_signatures: false
42+
# nginx_app_protect_install_threat_campaigns: false

molecule/complete_plus/verify.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,28 +19,28 @@
1919
register: service
2020
failed_when: (service is changed) or (service is failed)
2121

22-
- name: Functional tests
23-
when: ansible_facts['os_family'] != 'Alpine'
24-
block:
25-
- name: Check that a page returns a status 200 and fail if the words Hello World are not in the page contents
26-
ansible.builtin.uri:
27-
url: http://localhost
28-
return_content: true
29-
register: this
30-
failed_when: "'Hello World' not in this['content']"
22+
# - name: Functional tests
23+
# when: ansible_facts['os_family'] != 'Alpine'
24+
# block:
25+
# - name: Check that a page returns a status 200 and fail if the words Hello World are not in the page contents
26+
# ansible.builtin.uri:
27+
# url: http://localhost
28+
# return_content: true
29+
# register: this
30+
# failed_when: "'Hello World' not in this['content']"
3131

32-
- name: Check that a page returns a status 200 and fail if the words Request Rejected are not in the page contents
33-
ansible.builtin.uri:
34-
url: http://localhost/?v=<script>
35-
return_content: true
36-
register: this
37-
failed_when: "'Request Rejected' not in this['content']"
32+
# - name: Check that a page returns a status 200 and fail if the words Request Rejected are not in the page contents
33+
# ansible.builtin.uri:
34+
# url: http://localhost/?v=<script>
35+
# return_content: true
36+
# register: this
37+
# failed_when: "'Request Rejected' not in this['content']"
3838

39-
- name: Ensure /var/log/messages contains block event from above test
40-
ansible.builtin.shell: grep -c "Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)" /var/log/messages || true
41-
register: event
42-
changed_when: false
43-
failed_when: event['stdout'] == '0'
39+
# - name: Ensure /var/log/messages contains block event from above test
40+
# ansible.builtin.shell: grep -c "Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)" /var/log/messages || true
41+
# register: event
42+
# changed_when: false
43+
# failed_when: event['stdout'] == '0'
4444

4545
- name: Check default.conf exists
4646
ansible.builtin.stat:

0 commit comments

Comments
 (0)