Update GitHub Actions (#171)

Author: alessfg

.github/workflows/molecule.yml

@@ -25,25 +25,25 @@ jobs:
           - stable_push
     steps:
       - name: Check out the codebase
-        if: "!(matrix.scenario == 'plus' && github.event.pull_request.head.repo.full_name != github.repository)"
+        if: "!(contains(matrix.scenario, 'plus') && github.event.pull_request.head.repo.full_name != github.repository)"
         uses: actions/[email protected]
 
       - name: Set up Python 3
-        if: "!(matrix.scenario == 'plus' && github.event.pull_request.head.repo.full_name != github.repository)"
+        if: "!(contains(matrix.scenario, 'plus') && github.event.pull_request.head.repo.full_name != github.repository)"
         uses: actions/[email protected]
         with:
           python-version: 3.x
 
       - name: Install Molecule dependencies
-        if: "!(matrix.scenario == 'plus' && github.event.pull_request.head.repo.full_name != github.repository)"
+        if: "!(contains(matrix.scenario, 'plus') && github.event.pull_request.head.repo.full_name != github.repository)"
         run: pip3 install -r .github/workflows/requirements/requirements_molecule.txt
 
       - name: Install Ansible base dependencies
         if: "!(contains(matrix.scenario, 'plus') && github.event.pull_request.head.repo.full_name != github.repository)"
         run: ansible-galaxy install -r .github/workflows/requirements/requirements_ansible.yml
 
       - name: Run Molecule tests
-        if: "!(matrix.scenario == 'plus' && github.event.pull_request.head.repo.full_name != github.repository)"
+        if: "!(contains(matrix.scenario, 'plus') && github.event.pull_request.head.repo.full_name != github.repository)"
         run: molecule test -s ${{ matrix.scenario }}
         env:
           PY_COLORS: "1"

CHANGELOG.md

@@ -212,6 +212,8 @@ ENHANCEMENTS:
 * Replace Molecule tests using Debian stretch with Debian buster (stretch has reached its EoL), and update list of supported platforms.
 * Replace Ansible base with Ansible core. Ansible core will be the "core" Ansible release moving forward from Ansible `2.11`.
 * Update GitHub actions to add a workflow dispatch option.
+* Update GitHub actions `if` conditionals to use the `contains` function instead of checking for exact names.
+* Remove Debian Buster from the `plus` Molecule scenario since it often fails in the GitHub Actions CI/CD pipeline.
 * Replace "yes"/"no" boolean values with "true"/"false" to comply with YAML spec `1.2`.
 * Ensure the default values for the `nginx.conf` template match the default values found on a fresh NGINX installation.
 

molecule/plus/molecule.yml

@@ -17,13 +17,6 @@ platforms:
     volumes:
       - "/sys/fs/cgroup:/sys/fs/cgroup:rw"
     command: "/usr/sbin/init"
-  - name: debian-buster
-    image: debian:buster-slim
-    dockerfile: ../common/Dockerfile.j2
-    privileged: true
-    volumes:
-      - "/sys/fs/cgroup:/sys/fs/cgroup:rw"
-    command: "/sbin/init"
   - name: ubuntu-bionic
     image: ubuntu:bionic
     dockerfile: ../common/Dockerfile.j2