Replace "yes"/"no" boolean values with "true"/"false" (#414)

alessfg · web-flow · commit fb391a09cce1 · 2021-06-02T17:47:44.000+02:00
diff --git a/.github/workflows/galaxy.yml b/.github/workflows/galaxy.yml
@@ -1,6 +1,6 @@
 ---
 name: Ansible Galaxy import
-on:
+"on":
   release:
     types:
       - published
diff --git a/.github/workflows/molecule.yml b/.github/workflows/molecule.yml
@@ -1,6 +1,6 @@
 ---
 name: Molecule CI/CD
-on:
+"on":
   pull_request:
     branches:
       - main
diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml
@@ -1,6 +1,6 @@
 ---
 name: Release Drafter
-on:
+"on":
   pull_request:
     types:
       - opened
diff --git a/.yamllint b/.yamllint
@@ -10,4 +10,3 @@ rules:
     level: error
   comments-indentation: disable
   line-length: disable
-  truthy: disable
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ ENHANCEMENTS:
 
 *   Replace Ansible base with Ansible core. Ansible core will be the "core" Ansible release moving forward from Ansible `2.11`.
 *   Update GitHub actions to add a workflow dispatch option.
+*   Replace "yes"/"no" boolean values with "true"/"false" to comply with YAML spec `1.2`.
 
 BUG FIXES:
 
diff --git a/handlers/main.yml b/handlers/main.yml
@@ -1,13 +1,13 @@
 ---
 - name: (Handler) Systemd daemon-reload
   systemd:
-    daemon_reload: yes
+    daemon_reload: true
 
 - name: (Handler) Start/reload NGINX
   service:
     name: nginx
     state: reloaded
-    enabled: yes
+    enabled: true
   when:
     - nginx_start | bool
     - not ansible_check_mode | bool
@@ -18,8 +18,8 @@
   args:
     chdir: /etc/nginx/
   register: config_check
-  ignore_errors: yes
-  check_mode: no
+  ignore_errors: true
+  check_mode: false
   changed_when: false
   listen: (Handler) Run NGINX
 
diff --git a/molecule/default/verify.yml b/molecule/default/verify.yml
@@ -6,16 +6,16 @@
       package:
         name: nginx
         state: present
-      check_mode: yes
+      check_mode: true
       register: install
       failed_when: (install is changed) or (install is failed)
 
     - name: Check if NGINX service is running
       service:
         name: nginx
         state: started
-        enabled: yes
-      check_mode: yes
+        enabled: true
+      check_mode: true
       register: service
       failed_when: (service is changed) or (service is failed)
 
diff --git a/molecule/module/verify.yml b/molecule/module/verify.yml
@@ -6,16 +6,16 @@
       package:
         name: nginx
         state: present
-      check_mode: yes
+      check_mode: true
       register: install
       failed_when: (install is changed) or (install is failed)
 
     - name: Check if NGINX service is running
       service:
         name: nginx
         state: started
-        enabled: yes
-      check_mode: yes
+        enabled: true
+      check_mode: true
       register: service
       failed_when: (service is changed) or (service is failed)
 
diff --git a/molecule/plus/prepare.yml b/molecule/plus/prepare.yml
@@ -7,12 +7,12 @@
       copy:
         content: "{{ lookup('env','NGINX_CRT') | b64decode }}"
         dest: ../../files/license/nginx-repo.crt
-        force: no
+        force: false
         mode: 0444
 
     - name: Create ephemeral license key file from b64 decoded env var
       copy:
         content: "{{ lookup('env','NGINX_KEY') | b64decode }}"
         dest: ../../files/license/nginx-repo.key
-        force: no
+        force: false
         mode: 0444
diff --git a/molecule/plus/verify.yml b/molecule/plus/verify.yml
@@ -6,16 +6,16 @@
       package:
         name: nginx-plus
         state: present
-      check_mode: yes
+      check_mode: true
       register: install
       failed_when: (install is changed) or (install is failed)
 
     - name: Check if NGINX Plus service is running
       service:
         name: nginx
         state: started
-        enabled: yes
-      check_mode: yes
+        enabled: true
+      check_mode: true
       register: service
       failed_when: (service is changed) or (service is failed)
 
diff --git a/molecule/source/verify.yml b/molecule/source/verify.yml
@@ -6,8 +6,8 @@
       service:
         name: nginx
         state: started
-        enabled: yes
-      check_mode: yes
+        enabled: true
+      check_mode: true
       register: service
       failed_when: (service is changed) or (service is failed)
 
diff --git a/tasks/amplify/install-amplify.yml b/tasks/amplify/install-amplify.yml
@@ -10,7 +10,7 @@
 
 - name: Copy NGINX configurator agent configuration template
   copy:
-    remote_src: yes
+    remote_src: true
     src: /etc/amplify-agent/agent.conf.default
     dest: /etc/amplify-agent/agent.conf
     mode: 0644
diff --git a/tasks/amplify/setup-debian.yml b/tasks/amplify/setup-debian.yml
@@ -4,14 +4,14 @@
     filename: nginx-amplify
     repo: "deb [arch=amd64] https://packages.amplify.nginx.com/{{ ansible_facts['distribution'] | lower }}/
           {{ ansible_facts['distribution_release'] | lower }} amplify-agent"
-    update_cache: yes
+    update_cache: true
     mode: 0644
   when: ansible_facts['distribution_release'] != "focal"
 
 - name: (Ubuntu 20.04) Add NGINX Amplify agent repository
   apt_repository:
     filename: nginx-amplify
     repo: deb [arch=amd64] https://packages.amplify.nginx.com/py3/ubuntu focal amplify-agent
-    update_cache: yes
+    update_cache: true
     mode: 0644
   when: ansible_facts['distribution_release'] == "focal"
diff --git a/tasks/amplify/setup-redhat.yml b/tasks/amplify/setup-redhat.yml
@@ -4,6 +4,6 @@
     name: nginx-amplify
     baseurl: http://packages.amplify.nginx.com/{{ (ansible_facts['distribution'] == "Amazon") | ternary('amzn/', 'centos/') }}/$releasever/$basearch/
     description: NGINX Amplify Agent
-    enabled: yes
-    gpgcheck: yes
+    enabled: true
+    gpgcheck: true
     mode: 0644
diff --git a/tasks/config/debug-output.yml b/tasks/config/debug-output.yml
@@ -2,7 +2,7 @@
 - name: Register NGINX config
   command: nginx -T
   ignore_errors: "{{ ansible_check_mode }}"
-  check_mode: no
+  check_mode: false
   changed_when: false
   register: config_full
 
diff --git a/tasks/keys/setup-keys.yml b/tasks/keys/setup-keys.yml
@@ -27,5 +27,5 @@
   rpm_key:
     fingerprint: 573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62
     key: "{{ keysite }}"
-    validate_certs: "{{ (ansible_facts['distribution_major_version'] is version('6', '==')) | ternary('no', 'yes') }}"
+    validate_certs: "{{ (ansible_facts['distribution_major_version'] is version('6', '==')) | ternary('false', 'true') }}"
   when: ansible_facts['os_family'] in ['RedHat', 'Suse']
diff --git a/tasks/main.yml b/tasks/main.yml
@@ -8,7 +8,7 @@
   when:
     - nginx_install | bool
     - (nginx_install_from == "nginx_repository" or nginx_type == "plus")
-  ignore_errors: yes
+  ignore_errors: true
   tags: nginx_check_support
 
 - name: Set up prerequisites
diff --git a/tasks/opensource/install-alpine.yml b/tasks/opensource/install-alpine.yml
@@ -10,6 +10,6 @@
     name: "nginx{{ nginx_version | default('') }}"
     repository: "{{ nginx_repository | default(nginx_default_repository_alpine) }}"
     state: "{{ nginx_state }}"
-    update_cache: yes
+    update_cache: true
   ignore_errors: "{{ ansible_check_mode }}"
   notify: (Handler) Run NGINX
diff --git a/tasks/opensource/install-bsd.yml b/tasks/opensource/install-bsd.yml
@@ -37,15 +37,15 @@
     - name: (OpenBSD) Install NGINX package
       openbsd_pkg:
         name: "nginx{{ nginx_version | default('') }}"
-        build: no
+        build: false
         state: "{{ nginx_state }}"
       when: nginx_bsd_install_packages | bool
       notify: (Handler) Run NGINX
 
     - name: (OpenBSD) Install NGINX port
       openbsd_pkg:
         name: "nginx{{ nginx_version | default('') }}"
-        build: yes
+        build: true
         state: "{{ nginx_state }}"
       when: not nginx_bsd_install_packages | bool
       notify: (Handler) Run NGINX
diff --git a/tasks/opensource/install-debian.yml b/tasks/opensource/install-debian.yml
@@ -3,7 +3,7 @@
   apt_repository:
     filename: nginx
     repo: "{{ item }}"
-    update_cache: yes
+    update_cache: true
     mode: 0644
   loop: "{{ nginx_repository | default(nginx_default_repository_debian) }}"
 
diff --git a/tasks/opensource/install-redhat.yml b/tasks/opensource/install-redhat.yml
@@ -4,15 +4,15 @@
     name: nginx
     baseurl: "{{ nginx_repository | default(nginx_default_repository_redhat) }}"
     description: NGINX Repository
-    enabled: yes
-    gpgcheck: yes
+    enabled: true
+    gpgcheck: true
     mode: 0644
   when: ansible_facts['distribution_major_version'] is version('8', '<')
 
 - name: (CentOS/RHEL 8) Configure NGINX repository
   blockinfile:
     path: /etc/yum.repos.d/nginx.repo
-    create: yes
+    create: true
     block: |
       [nginx]
       baseurl = {{ nginx_repository | default(nginx_default_repository_redhat) }}
@@ -29,6 +29,6 @@
     state: "{{ nginx_state }}"
     disablerepo: "*"
     enablerepo: nginx
-    update_cache: yes
+    update_cache: true
   ignore_errors: "{{ ansible_check_mode }}"
   notify: (Handler) Run NGINX
diff --git a/tasks/opensource/install-source.yml b/tasks/opensource/install-source.yml
diff --git a/tasks/opensource/install-suse.yml b/tasks/opensource/install-suse.yml
diff --git a/tasks/plus/install-debian.yml b/tasks/plus/install-debian.yml
diff --git a/tasks/plus/install-freebsd.yml b/tasks/plus/install-freebsd.yml
diff --git a/tasks/plus/install-redhat.yml b/tasks/plus/install-redhat.yml
diff --git a/tasks/plus/install-suse.yml b/tasks/plus/install-suse.yml
diff --git a/tasks/plus/setup-license.yml b/tasks/plus/setup-license.yml
diff --git a/tasks/prerequisites/install-dependencies.yml b/tasks/prerequisites/install-dependencies.yml
diff --git a/tasks/prerequisites/setup-selinux.yml b/tasks/prerequisites/setup-selinux.yml

-Original file line number
+Diff line change
@@ @@ -1,6 +1,6 @@ @@
 ---
 name: Release Drafter
 -on:
 +"on":
   pull_request:
     types:
       - opened