Skip to content

Conversation

@SPR0STO
Copy link

@SPR0STO SPR0STO commented Jul 18, 2025

Proposed changes

This PR resolves a false-negative failure that occurs in --check (dry-run) mode when validating environment compatibility.

Specifically, two delegated tasks:

  • Extract the version of Jinja2 installed on your Ansible host
  • Extract the list of Ansible collections installed on your Ansible host

use ansible.builtin.command with delegate_to: localhost and register, but do not explicitly disable check-mode.

In dry-run mode, these tasks are silently skipped, leaving the registered variables empty and causing downstream assert tasks to fail — even when the environment is valid.

This PR adds check_mode: no to both command tasks, ensuring they run in dry-run mode as well. These are harmless, read-only queries that are safe in all execution modes.

Fixes #906

Checklist

@SPR0STO SPR0STO requested a review from a team as a code owner July 18, 2025 18:57
@github-actions
Copy link

github-actions bot commented Jul 18, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the bug Something isn't working label Jul 18, 2025
@SPR0STO
Copy link
Author

SPR0STO commented Jul 18, 2025

I have hereby read the F5 CLA and agree to its terms

@SPR0STO SPR0STO closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

false-negative on check in dry-run mode

1 participant