fix #906: prevent false-negative on check in dry-run mode #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR resolves a false-negative failure that occurs in
--check(dry-run) mode when validating environment compatibility.Specifically, two delegated tasks:
use
ansible.builtin.commandwithdelegate_to: localhostandregister, but do not explicitly disable check-mode.In dry-run mode, these tasks are silently skipped, leaving the registered variables empty and causing downstream
asserttasks to fail — even when the environment is valid.This PR adds
check_mode: noto both command tasks, ensuring they run in dry-run mode as well. These are harmless, read-only queries that are safe in all execution modes.Fixes #906
Checklist
defaults/main/*.yml,README.mdandCHANGELOG.md).