fix: compatibility with Debian 13 (trixie)

[hax0rbana-adam]

Proposed changes

Download the apt signing key to a file instead of using apt_key (which has been deprecated). Without this change, this role no longer functions on Debian 13 (trixie), which is the latest stable version, as the apt-key executable no longer exists.

The implementation mirrors what was done in the last example in the apt_repository module

Checklist

• I have read the contributing guidelines.
• I have signed the F5 Contributor License Agreement (CLA).
• If applicable, I have added Molecule tests that prove my fix is effective or that my feature works. (n/a)
• If applicable, I have checked that any relevant Molecule tests pass after adding my changes. (n/a)
• I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md). (n/a)

[github-actions]

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
_{Posted by the CLA Assistant Lite bot.}

[hax0rbana-adam]

I have hereby read the F5 CLA and agree to its terms

[hax0rbana-adam]

I have hereby read the F5 CLA and agree to its terms

[hax0rbana-adam]

Is there anything I can do to help move this MR along?

[nemca]

Thank you, for this fix!
I'm not the maintainer of this repository, but I have a suggestion for this PR - also need to add debian-trixie to the Molecule tests.
Something like this:

  - name: debian-trixie
    image: debian:trixie-slim
    dockerfile: ../common/Dockerfile.j2
    privileged: true
    cgroupns_mode: host
    volumes:
      - /sys/fs/cgroup:/sys/fs/cgroup:rw
    command: /sbin/init

need to be added to molecule/${SCENARIO}/molecule.yml to platforms array.
List of scenarios you can see here.
And then you can test it in your local Docker via:

molecule test -s ${SCENARIO} -- --limit debian-trixie

And also support platforms should be updated in README.md.
I tested these changes locally and everything works, both in the molecule and in my infrastructure for default scenario.

[hax0rbana-adam]

Thank you for the feedback. I've updated the README, but I've not done the changes for molecule yet because I'm not familiar with it, nor do I have docker installed to test the proposed changes.

• Are you suggesting that the exact same block needs to be added to 16 different files?
  • And are these molecule files not able to be generated somehow (via a Makefile, an ansible playbook, or something)?
• Is there a way to test the proposed change without installing and configuring Docker?

I'm not opposed to adding the molecule into this PR, but I'm hesitant to add code that hasn't been tested. I also don't want to add to what already sounds like a maintenance nightmare of copying and pasting the same block of yaml in 16 different places (if I understand correctly).

[nemca]

Are you suggesting that the exact same block needs to be added to 16 different files?

Yes, that's exactly how it's done now in this repo.
But personally, I prefer the DRY idea — all common settings, such as the platform list, can be moved to a .config/molecule/config.yml. This is a constant path for searching a config in Molecule.
But the thing is that the platforms in all scenarios are different, which is probably why it was decided to keep its own version for each scenario.

Is there a way to test the proposed change without installing and configuring Docker?

Molecule has support many drivers, you can found its in molecule-plugins repo.
By the way, tests will be run into this PR in CI after status will change or set approve.

I'm not opposed to adding the molecule into this PR, but I'm hesitant to add code that hasn't been tested. I also don't want to add to what already sounds like a maintenance nightmare of copying and pasting the same block of yaml in 16 different places (if I understand correctly).

I guess we need wait a someone of mainteiners.
If this ideas will be interesting and approve I can make this change to your fork, after local testing, and you can push its to this PR.

[hax0rbana-adam]

Yeah, if you could send me a tested patch to the molecule parts, I'd love to include it here. Anything I can do to help get it approved and onto a new release is most welcome.

I might even be able to find a computer that can use Vagrant to test out the changes myself.

[nemca]

Yeah, if you could send me a tested patch to the molecule parts, I'd love to include it here. Anything I can do to help get it approved and onto a new release is most welcome.

I might even be able to find a computer that can use Vagrant to test out the changes myself.

@hax0rbana-adam Could you please give me (@nemca) permission to push my branch to your fork repo?
Right now I got error:

$ git push --set-upstream origin nemca/ref/molecule
ERROR: Permission to hax0rbana-adam/ansible-role-nginx.git denied to nemca.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I've done refactoring:

• move molecule driver and platform settings to config.yml
• add debian-trixie platform to default molecule platforms
• remove ubuntu-oracular from default molecule platforms
• remove ubuntu-focal platform from molecule default platforms
• remove alpine-3.18 platform from molecule default platforms
• add Debian 13 to nginx_supported_distributions
• add ubuntu-plucky to molecule default platforms
• set version=1.29.2 to Debian in Molecule downgrade converge.yml